This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add tests ensuring rotates persist
ClosedPublic

Authored by pmatos on Jun 5 2023, 1:16 AM.

Details

Summary

Due to the nature of WebAssembly, it's always better to keep
rotates instead of trying to optimize it. Commit 9485d983
disabled the generation of fsh for rotates, however these
tests ensure that future changes don't change the behaviour for
the Wasm backend that tends to have different optimization
requirements than other architectures. Also see:
https://github.com/llvm/llvm-project/issues/62703

Diff Detail

Event Timeline

pmatos created this revision.Jun 5 2023, 1:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 1:16 AM
Herald added subscribers: asb, wingo, sunfish and 2 others. · View Herald Transcript
pmatos requested review of this revision.Jun 5 2023, 1:16 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 5 2023, 1:16 AM
dschuff accepted this revision.Jun 5 2023, 5:42 PM
This revision is now accepted and ready to land.Jun 5 2023, 5:42 PM
This revision was automatically updated to reflect the committed changes.