This is an archive of the discontinued LLVM Phabricator instance.

[BOLT] Instrumentation: Add support for MacOS counters
ClosedPublic

Authored by Elvina on Jun 1 2023, 9:44 AM.

Details

Summary

This patch adds support for generation of getter counters for AArch64 MacOS

continuation of work https://reviews.llvm.org/D151899

Elvina Yakubova,
Advanced Software Technology Lab, Huawei

Diff Detail

Event Timeline

Elvina created this revision.Jun 1 2023, 9:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 9:44 AM
Elvina requested review of this revision.Jun 1 2023, 9:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 9:44 AM
rafauler added inline comments.Jun 26 2023, 4:52 PM
bolt/include/bolt/Core/MCPlusBuilder.h
1980–1985 ↗(On Diff #527463)

Let's avoid publishing this to the target-independent interface. Make it a local helper in AArch64MCPlusBuilder

bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp
1357

nit: TempReg -> ReturnValReg

1361

assert on size being 2

Elvina updated this revision to Diff 536240.EditedJun 30 2023, 7:38 AM
Elvina marked 3 inline comments as done.

Updated diff based on comments - createGetter is local now

This revision is now accepted and ready to land.Aug 18 2023, 5:37 PM
yota9 accepted this revision.Aug 24 2023, 8:35 AM

LGTM

This revision was automatically updated to reflect the committed changes.