User Details
- User Since
- Dec 10 2019, 7:33 AM (198 w, 1 d)
Thu, Sep 7
@Amir Thanks for the review and for your help!
Wed, Sep 6
@Amir gentle ping
Fri, Sep 1
@Amir I disabled meta-merge-fdata.test for aarch64, as we need to correctly handle .plt.got for this case. I'll add separate patch for this soon
Fixed internal-call-instrument.s test
Thu, Aug 31
rebase
added fix for instrumentation-ind-call.c and basic-instrumentation.test
Wed, Aug 30
updated the diff to check for printf only
added %cflags to bolt-address-translation-internal-call.test
Tue, Aug 29
Trying another approach, with UNSUPPORTED target
Aug 26 2023
@rafauler Thanks for fixing this. I noticed the issue just now
Aug 25 2023
Aug 24 2023
@rafauler Thanks for reviewing this!
removed BL and B checks in convertIndirectCallToLoad
rebase
rebase + add syscalls for AArch64
Aug 21 2023
Remove comment in meta-merge-fdata.test
remove CodePointerSize parameter
Aug 10 2023
Setting -mno-sse flag back
Aug 8 2023
add check for Darwin OS, so we'll not get error during building with clang on Linux (see here https://github.com/llvm/llvm-project/issues/63255#issuecomment-1589716433)
rebase
Jul 27 2023
Gentle ping
Jul 24 2023
added more tests, moved some from X86 to the common level
Jul 6 2023
Jun 30 2023
Fixed Cmake, added clang-format plugs
Updated diff based on comments - createGetter is local now
Thanks for reviewing this! Fixed everything you mentioned
updated diff according to comments
Jun 2 2023
clang-format
clang-format
Jun 1 2023
May 23 2023
Hello! I tested the patch on our binaries, and everything looks fine. But on the small tests, as Rafael mentioned, I also ran into "BOLT-ERROR: JITLink failed: Unsupported aarch64 relocation:274: R_AARCH64_ADR_PREL_L021 " crash. It seems that the problem appears only when using lld linker (small tests use it).
Mar 12 2023
LGTM
Jul 5 2022
Mar 9 2022
Reverted changes for HugePageSize
Feb 10 2022
Feb 8 2022
Nov 11 2020
Anastasia, thank you
Failure on test "linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp" looks bogus. I had the same issue with another PR https://reviews.llvm.org/D89972 and other people also faced it https://reviews.llvm.org/D89895
Nov 10 2020
Nov 6 2020
Nov 5 2020
@SjoerdMeijer thanks for the review!
@bryanpkc does everything look fine? Can I commit it?
Oct 29 2020
Merged all into one AArch64SchedTSV110.td, removed aarch64-cpus.c test from this patch
Gentle ping :)
Oct 23 2020
Failure on test "linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp" looks bogus. I found the same cases https://reviews.llvm.org/D89895 and https://reviews.llvm.org/D89964.
Oct 22 2020
Jul 23 2020
Jul 17 2020
Thanks to everyone for looking at this!
Sync with master