Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Elvina (Elvina Yakubova)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 10 2019, 7:33 AM (198 w, 1 d)

Recent Activity

Thu, Sep 7

Elvina added a comment to D159094: [BOLT][test] Fix cross-compilation tests after D151920.

@Amir Thanks for the review and for your help!

Thu, Sep 7, 2:08 PM · Restricted Project, Restricted Project
Elvina committed rG6678f602c243: [BOLT][test] Fix cross-compilation tests after D151920 (authored by Elvina).
[BOLT][test] Fix cross-compilation tests after D151920
Thu, Sep 7, 2:06 PM · Restricted Project
Elvina closed D159094: [BOLT][test] Fix cross-compilation tests after D151920.
Thu, Sep 7, 2:06 PM · Restricted Project, Restricted Project
Elvina updated the summary of D159094: [BOLT][test] Fix cross-compilation tests after D151920.
Thu, Sep 7, 6:03 AM · Restricted Project, Restricted Project

Wed, Sep 6

Elvina added a comment to D159094: [BOLT][test] Fix cross-compilation tests after D151920.

@Elvina – please update the title and summary. Looks good otherwise.

Wed, Sep 6, 1:22 PM · Restricted Project, Restricted Project
Elvina retitled D159094: [BOLT][test] Fix cross-compilation tests after D151920 from Fix failed tests to [BOLT][test] Fix failed tests.
Wed, Sep 6, 1:18 PM · Restricted Project, Restricted Project
Elvina added a comment to D159094: [BOLT][test] Fix cross-compilation tests after D151920.

@Amir gentle ping

Wed, Sep 6, 12:45 PM · Restricted Project, Restricted Project

Fri, Sep 1

Elvina added a comment to D159094: [BOLT][test] Fix cross-compilation tests after D151920.

@Amir I disabled meta-merge-fdata.test for aarch64, as we need to correctly handle .plt.got for this case. I'll add separate patch for this soon

Fri, Sep 1, 2:06 PM · Restricted Project, Restricted Project
Elvina retitled D159094: [BOLT][test] Fix cross-compilation tests after D151920 from Temporarily move failed test to runtime to Fix failed tests.
Fri, Sep 1, 2:05 PM · Restricted Project, Restricted Project
Elvina updated the diff for D159094: [BOLT][test] Fix cross-compilation tests after D151920.

Fixed internal-call-instrument.s test

Fri, Sep 1, 1:56 PM · Restricted Project, Restricted Project
Elvina updated the diff for D159094: [BOLT][test] Fix cross-compilation tests after D151920.
Fri, Sep 1, 12:45 PM · Restricted Project, Restricted Project
Elvina committed rG777e268b8168: [BOLT][test] Enable exceptions_split tests for AArch64 (authored by Elvina).
[BOLT][test] Enable exceptions_split tests for AArch64
Fri, Sep 1, 12:49 AM · Restricted Project
Elvina closed D158899: [BOLT][test] Enable exceptions_split tests for AArch64.
Fri, Sep 1, 12:48 AM · Restricted Project, Restricted Project

Thu, Aug 31

Elvina updated the diff for D159094: [BOLT][test] Fix cross-compilation tests after D151920.

rebase

Thu, Aug 31, 4:32 PM · Restricted Project, Restricted Project
Elvina updated the diff for D159094: [BOLT][test] Fix cross-compilation tests after D151920.

added fix for instrumentation-ind-call.c and basic-instrumentation.test

Thu, Aug 31, 3:22 PM · Restricted Project, Restricted Project

Wed, Aug 30

Elvina added a comment to D158899: [BOLT][test] Enable exceptions_split tests for AArch64.

updated the diff to check for printf only

Wed, Aug 30, 12:55 PM · Restricted Project, Restricted Project
Elvina updated the diff for D158899: [BOLT][test] Enable exceptions_split tests for AArch64.
Wed, Aug 30, 12:55 PM · Restricted Project, Restricted Project
Elvina added a comment to D159094: [BOLT][test] Fix cross-compilation tests after D151920.

@Elvina, could you please try %cflags change for the two test cases instead of disabling them?

Wed, Aug 30, 12:49 PM · Restricted Project, Restricted Project
Elvina updated the diff for D159094: [BOLT][test] Fix cross-compilation tests after D151920.

added %cflags to bolt-address-translation-internal-call.test

Wed, Aug 30, 12:45 PM · Restricted Project, Restricted Project

Tue, Aug 29

Elvina added a comment to D151920: [BOLT] Instrumentation: Fix tests.

Hi Elvina, this stack broke aarch64 buildbot: https://lab.llvm.org/buildbot/#/builders/221/builds/17715. You should've received a notification. Please prioritize fixing it or revert if it can't be fixed quickly.

Tue, Aug 29, 3:05 PM · Restricted Project, Restricted Project
Elvina updated the diff for D159094: [BOLT][test] Fix cross-compilation tests after D151920.

Trying another approach, with UNSUPPORTED target

Tue, Aug 29, 2:17 PM · Restricted Project, Restricted Project
Elvina updated the diff for D159094: [BOLT][test] Fix cross-compilation tests after D151920.
Tue, Aug 29, 7:25 AM · Restricted Project, Restricted Project
Elvina updated the diff for D159094: [BOLT][test] Fix cross-compilation tests after D151920.
Tue, Aug 29, 7:21 AM · Restricted Project, Restricted Project
Elvina requested review of D159094: [BOLT][test] Fix cross-compilation tests after D151920.
Tue, Aug 29, 7:12 AM · Restricted Project, Restricted Project

Aug 26 2023

Elvina added a comment to D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.

@rafauler Thanks for fixing this. I noticed the issue just now

Aug 26 2023, 12:56 AM · Restricted Project, Restricted Project

Aug 25 2023

Elvina requested review of D158899: [BOLT][test] Enable exceptions_split tests for AArch64.
Aug 25 2023, 2:45 PM · Restricted Project, Restricted Project

Aug 24 2023

Elvina committed rG83cb541f806d: [BOLT][Instrumentation][test] Fix tests (authored by Elvina).
[BOLT][Instrumentation][test] Fix tests
Aug 24 2023, 9:36 AM · Restricted Project
Elvina committed rG87e9c42495aa: [BOLT][Instrumentation] AArch64 instrumentation support in runtime (authored by Elvina).
[BOLT][Instrumentation] AArch64 instrumentation support in runtime
Aug 24 2023, 9:36 AM · Restricted Project
Elvina committed rG70405a0bf70f: [BOLT][Instrumentation] Add support for MacOS counters (authored by Elvina).
[BOLT][Instrumentation] Add support for MacOS counters
Aug 24 2023, 9:36 AM · Restricted Project
Elvina committed rG6e4c230525fb: [BOLT][Instrumentation] Initial instrumentation support for AArch64 (authored by Elvina).
[BOLT][Instrumentation] Initial instrumentation support for AArch64
Aug 24 2023, 9:35 AM · Restricted Project
Elvina closed D151920: [BOLT] Instrumentation: Fix tests.
Aug 24 2023, 9:35 AM · Restricted Project, Restricted Project
Elvina closed D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.
Aug 24 2023, 9:35 AM · Restricted Project, Restricted Project
Elvina closed D151901: [BOLT] Instrumentation: Add support for MacOS counters.
Aug 24 2023, 9:35 AM · Restricted Project, Restricted Project
Elvina closed D151899: [BOLT] Instrumentation: Initial instrumentation support for AArch64.
Aug 24 2023, 9:35 AM · Restricted Project, Restricted Project, Unknown Object (Project)
Elvina added a comment to D151899: [BOLT] Instrumentation: Initial instrumentation support for AArch64.

@rafauler @yota9 Thanks :)

Aug 24 2023, 8:46 AM · Restricted Project, Restricted Project, Unknown Object (Project)
Elvina added a comment to D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.

@rafauler Thanks for reviewing this!

Aug 24 2023, 8:45 AM · Restricted Project, Restricted Project
Elvina updated the diff for D151899: [BOLT] Instrumentation: Initial instrumentation support for AArch64.

removed BL and B checks in convertIndirectCallToLoad

Aug 24 2023, 7:49 AM · Restricted Project, Restricted Project, Unknown Object (Project)
Elvina updated the diff for D151899: [BOLT] Instrumentation: Initial instrumentation support for AArch64.

rebase

Aug 24 2023, 3:12 AM · Restricted Project, Restricted Project, Unknown Object (Project)
Elvina updated the diff for D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.

rebase + add syscalls for AArch64

Aug 24 2023, 2:51 AM · Restricted Project, Restricted Project

Aug 21 2023

Elvina updated the diff for D151920: [BOLT] Instrumentation: Fix tests.

Remove comment in meta-merge-fdata.test

Aug 21 2023, 8:36 AM · Restricted Project, Restricted Project
Elvina updated the diff for D151899: [BOLT] Instrumentation: Initial instrumentation support for AArch64.

remove CodePointerSize parameter

Aug 21 2023, 8:31 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Aug 10 2023

Elvina updated the diff for D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.

Setting -mno-sse flag back

Aug 10 2023, 8:08 AM · Restricted Project, Restricted Project
Elvina added inline comments to D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.
Aug 10 2023, 8:05 AM · Restricted Project, Restricted Project

Aug 8 2023

Elvina updated the diff for D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.

add check for Darwin OS, so we'll not get error during building with clang on Linux (see here https://github.com/llvm/llvm-project/issues/63255#issuecomment-1589716433)

Aug 8 2023, 7:59 AM · Restricted Project, Restricted Project
Elvina updated the diff for D151899: [BOLT] Instrumentation: Initial instrumentation support for AArch64.

rebase

Aug 8 2023, 7:56 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jul 27 2023

Elvina added a comment to D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.

Gentle ping

Jul 27 2023, 4:40 AM · Restricted Project, Restricted Project

Jul 24 2023

Elvina updated the diff for D151920: [BOLT] Instrumentation: Fix tests.

added more tests, moved some from X86 to the common level

Jul 24 2023, 6:39 AM · Restricted Project, Restricted Project

Jul 6 2023

Elvina added a comment to D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.

I wonder why is this diff not showing up on top of the D151899 diff stack anymore? Isn't it dependent on that stack?

Jul 6 2023, 11:13 PM · Restricted Project, Restricted Project

Jun 30 2023

Elvina added inline comments to D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.
Jun 30 2023, 9:50 AM · Restricted Project, Restricted Project
Elvina updated the diff for D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.
Jun 30 2023, 9:48 AM · Restricted Project, Restricted Project
Elvina updated the diff for D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.
Jun 30 2023, 8:32 AM · Restricted Project, Restricted Project
Elvina updated the diff for D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.
Jun 30 2023, 8:29 AM · Restricted Project, Restricted Project
Elvina updated the diff for D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.

Fixed Cmake, added clang-format plugs

Jun 30 2023, 7:51 AM · Restricted Project, Restricted Project
Elvina added inline comments to D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.
Jun 30 2023, 7:48 AM · Restricted Project, Restricted Project
Elvina updated the diff for D151901: [BOLT] Instrumentation: Add support for MacOS counters.

Updated diff based on comments - createGetter is local now

Jun 30 2023, 7:40 AM · Restricted Project, Restricted Project
Elvina added a comment to D151899: [BOLT] Instrumentation: Initial instrumentation support for AArch64.

Thanks for reviewing this! Fixed everything you mentioned

Jun 30 2023, 7:28 AM · Restricted Project, Restricted Project, Unknown Object (Project)
Elvina updated the diff for D151899: [BOLT] Instrumentation: Initial instrumentation support for AArch64.

updated diff according to comments

Jun 30 2023, 7:22 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jun 2 2023

Elvina updated the diff for D151920: [BOLT] Instrumentation: Fix tests.
Jun 2 2023, 2:20 PM · Restricted Project, Restricted Project
Elvina updated the diff for D151920: [BOLT] Instrumentation: Fix tests.
Jun 2 2023, 1:42 PM · Restricted Project, Restricted Project
Elvina updated the diff for D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.

clang-format

Jun 2 2023, 1:32 PM · Restricted Project, Restricted Project
Elvina updated the diff for D151920: [BOLT] Instrumentation: Fix tests.
Jun 2 2023, 8:50 AM · Restricted Project, Restricted Project
Elvina updated the diff for D151899: [BOLT] Instrumentation: Initial instrumentation support for AArch64.

clang-format

Jun 2 2023, 8:11 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jun 1 2023

Elvina requested review of D151942: [BOLT] Instrumentation: AArch64 instrumentation support in runtime.
Jun 1 2023, 2:37 PM · Restricted Project, Restricted Project
Elvina updated the diff for D151920: [BOLT] Instrumentation: Fix tests.
Jun 1 2023, 12:43 PM · Restricted Project, Restricted Project
Elvina requested review of D151920: [BOLT] Instrumentation: Fix tests.
Jun 1 2023, 12:40 PM · Restricted Project, Restricted Project
Elvina requested review of D151901: [BOLT] Instrumentation: Add support for MacOS counters.
Jun 1 2023, 9:45 AM · Restricted Project, Restricted Project
Elvina requested review of D151899: [BOLT] Instrumentation: Initial instrumentation support for AArch64.
Jun 1 2023, 9:36 AM · Restricted Project, Restricted Project, Unknown Object (Project)

May 23 2023

Elvina added a comment to D147544: [BOLT] Move from RuntimeDyld to JITLink.

Hello! I tested the patch on our binaries, and everything looks fine. But on the small tests, as Rafael mentioned, I also ran into "BOLT-ERROR: JITLink failed: Unsupported aarch64 relocation:274: R_AARCH64_ADR_PREL_L021 " crash. It seems that the problem appears only when using lld linker (small tests use it).

May 23 2023, 6:10 PM · Restricted Project, Restricted Project

Mar 12 2023

Elvina accepted D145465: [BOLT][NFC] Return instruction list from createInstrIncMemory.

LGTM

Mar 12 2023, 7:23 PM · Restricted Project, Restricted Project

Jul 5 2022

Elvina committed rG35155a071678: [BOLT] Change mutex implementation (authored by Elvina).
[BOLT] Change mutex implementation
Jul 5 2022, 10:24 PM · Restricted Project
Elvina closed D129162: [BOLT] Change mutex implementation.
Jul 5 2022, 10:24 PM · Restricted Project, Restricted Project
Elvina updated the summary of D129162: [BOLT] Change mutex implementation.
Jul 5 2022, 2:45 PM · Restricted Project, Restricted Project
Elvina added a comment to D129089: [BOLT] Fix concurrent hash table modification in the instrumentation runtime.

@michoecho, thank you for the investigation and the patch. Both changes look good to me.

@yota9, @Elvina, great. Could you submit a patch with __atomic_test_and_set()?

Jul 5 2022, 2:44 PM · Restricted Project, Restricted Project
Elvina updated the diff for D129162: [BOLT] Change mutex implementation.
Jul 5 2022, 2:42 PM · Restricted Project, Restricted Project
Elvina updated the summary of D129162: [BOLT] Change mutex implementation.
Jul 5 2022, 2:37 PM · Restricted Project, Restricted Project
Elvina removed a reviewer for D129162: [BOLT] Change mutex implementation: rafaelauler.
Jul 5 2022, 2:35 PM · Restricted Project, Restricted Project
Elvina requested review of D129162: [BOLT] Change mutex implementation.
Jul 5 2022, 2:35 PM · Restricted Project, Restricted Project

Mar 9 2022

Elvina added a comment to D119267: [BOLT] Divide RegularPageSize for X86 and AArch64 cases.

Could you please add "[BOLT]" to the title?

ld uses 64K alignment of LOAD segments by default.

I wonder if in that case the alignment of the segment will be 0x10000 as well?

Mar 9 2022, 12:48 PM · Restricted Project, Restricted Project
Elvina retitled D119267: [BOLT] Divide RegularPageSize for X86 and AArch64 cases from Divide RegularPageSize for X86 and AArch64 cases to [BOLT] Divide RegularPageSize for X86 and AArch64 cases.
Mar 9 2022, 12:46 PM · Restricted Project, Restricted Project
Elvina updated the diff for D119267: [BOLT] Divide RegularPageSize for X86 and AArch64 cases.

Reverted changes for HugePageSize

Mar 9 2022, 12:44 PM · Restricted Project, Restricted Project

Feb 10 2022

Elvina added inline comments to D119267: [BOLT] Divide RegularPageSize for X86 and AArch64 cases.
Feb 10 2022, 8:04 AM · Restricted Project, Restricted Project

Feb 8 2022

Elvina requested review of D119267: [BOLT] Divide RegularPageSize for X86 and AArch64 cases.
Feb 8 2022, 11:17 AM · Restricted Project, Restricted Project

Nov 11 2020

Elvina committed rG624bced7eec0: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument (authored by Elvina).
[OpenCL] Make Clang recognize -cl-std=1.0 as a value argument
Nov 11 2020, 6:04 AM
Elvina closed D91237: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument.
Nov 11 2020, 6:04 AM · Restricted Project
Elvina added a comment to D91237: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument.

Anastasia, thank you

Nov 11 2020, 6:03 AM · Restricted Project
Elvina added a comment to D91237: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument.

Failure on test "linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp" looks bogus. I had the same issue with another PR https://reviews.llvm.org/D89972 and other people also faced it https://reviews.llvm.org/D89895

Nov 11 2020, 2:49 AM · Restricted Project

Nov 10 2020

Elvina requested review of D91237: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument.
Nov 10 2020, 11:22 PM · Restricted Project

Nov 6 2020

Elvina committed rGc9ca3a3c66a4: [AArch64] Add driver tests for HiSilicon's TSV110 (authored by Elvina).
[AArch64] Add driver tests for HiSilicon's TSV110
Nov 6 2020, 2:52 PM
Elvina committed rG93b99728b167: [AArch64] Add pipeline model for HiSilicon's TSV110 (authored by Elvina).
[AArch64] Add pipeline model for HiSilicon's TSV110
Nov 6 2020, 2:25 PM
Elvina closed D89972: Add pipeline model for HiSilicon's TSV110.
Nov 6 2020, 2:25 PM · Restricted Project, Restricted Project

Nov 5 2020

Elvina added a comment to D89972: Add pipeline model for HiSilicon's TSV110.

@SjoerdMeijer thanks for the review!
@bryanpkc does everything look fine? Can I commit it?

Nov 5 2020, 1:28 AM · Restricted Project, Restricted Project

Oct 29 2020

Elvina updated the diff for D89972: Add pipeline model for HiSilicon's TSV110.

Merged all into one AArch64SchedTSV110.td, removed aarch64-cpus.c test from this patch

Oct 29 2020, 11:58 PM · Restricted Project, Restricted Project
Elvina added inline comments to D89972: Add pipeline model for HiSilicon's TSV110.
Oct 29 2020, 11:58 PM · Restricted Project, Restricted Project
Elvina added a comment to D89972: Add pipeline model for HiSilicon's TSV110.

Gentle ping :)

Oct 29 2020, 4:55 AM · Restricted Project, Restricted Project

Oct 23 2020

Elvina added a comment to D89972: Add pipeline model for HiSilicon's TSV110.

Failure on test "linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp" looks bogus. I found the same cases https://reviews.llvm.org/D89895 and https://reviews.llvm.org/D89964.

Oct 23 2020, 12:17 AM · Restricted Project, Restricted Project
Elvina updated the summary of D89972: Add pipeline model for HiSilicon's TSV110.
Oct 23 2020, 12:11 AM · Restricted Project, Restricted Project

Oct 22 2020

Elvina requested review of D89972: Add pipeline model for HiSilicon's TSV110.
Oct 22 2020, 10:09 AM · Restricted Project, Restricted Project

Jul 23 2020

Elvina added a comment to D83912: [llvm-readobj] Update tests because of changes at llvm-readobj behavior.

Hi @Elvina,

Just to let you know that I had to fix up three clang tests that were using the old behaviour too, prior to committing. I also noticed that you've got the stack the wrong way around - you needed to fix the tests before changing the behaviour in this case to avoid breaking the codebase, even if it was only briefly.

Anyway, these are now committed. I'll update the bug.

Jul 23 2020, 3:03 AM · Restricted Project, Restricted Project

Jul 17 2020

Elvina added a comment to D83912: [llvm-readobj] Update tests because of changes at llvm-readobj behavior.

Thanks to everyone for looking at this!

Jul 17 2020, 10:30 AM · Restricted Project, Restricted Project
Elvina updated the diff for D83912: [llvm-readobj] Update tests because of changes at llvm-readobj behavior.

Sync with master

Jul 17 2020, 10:27 AM · Restricted Project, Restricted Project