@Amir Thanks for the review and for your help!

In D159094#4640029, @Amir wrote:

@Elvina – please update the title and summary. Looks good otherwise.

@Amir gentle ping

@Amir I disabled meta-merge-fdata.test for aarch64, as we need to correctly handle .plt.got for this case. I'll add separate patch for this soon

Fixed internal-call-instrument.s test

rebase

added fix for instrumentation-ind-call.c and basic-instrumentation.test

updated the diff to check for printf only

In D159094#4626791, @maksfb wrote:

@Elvina, could you please try %cflags change for the two test cases instead of disabling them?

added %cflags to bolt-address-translation-internal-call.test

In D151920#4622639, @Amir wrote:

Hi Elvina, this stack broke aarch64 buildbot: https://lab.llvm.org/buildbot/#/builders/221/builds/17715. You should've received a notification. Please prioritize fixing it or revert if it can't be fixed quickly.

Trying another approach, with UNSUPPORTED target

@rafauler Thanks for fixing this. I noticed the issue just now

@rafauler @yota9 Thanks :)

@rafauler Thanks for reviewing this!

removed BL and B checks in convertIndirectCallToLoad

rebase

rebase + add syscalls for AArch64

Remove comment in meta-merge-fdata.test

remove CodePointerSize parameter

Setting -mno-sse flag back

add check for Darwin OS, so we'll not get error during building with clang on Linux (see here https://github.com/llvm/llvm-project/issues/63255#issuecomment-1589716433)

rebase

Gentle ping

added more tests, moved some from X86 to the common level

In D151942#4474686, @rafauler wrote:

I wonder why is this diff not showing up on top of the D151899 diff stack anymore? Isn't it dependent on that stack?

Fixed Cmake, added clang-format plugs

Updated diff based on comments - createGetter is local now

Thanks for reviewing this! Fixed everything you mentioned

updated diff according to comments

clang-format

clang-format

Hello! I tested the patch on our binaries, and everything looks fine. But on the small tests, as Rafael mentioned, I also ran into "BOLT-ERROR: JITLink failed: Unsupported aarch64 relocation:274: R_AARCH64_ADR_PREL_L021 " crash. It seems that the problem appears only when using lld linker (small tests use it).

LGTM

In D129089#3630961, @maksfb wrote:

@michoecho, thank you for the investigation and the patch. Both changes look good to me.

@yota9, @Elvina, great. Could you submit a patch with __atomic_test_and_set()?

In D119267#3313212, @maksfb wrote:

Could you please add "[BOLT]" to the title?

ld uses 64K alignment of LOAD segments by default.

I wonder if in that case the alignment of the segment will be 0x10000 as well?

Reverted changes for HugePageSize

Anastasia, thank you

Failure on test "linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp" looks bogus. I had the same issue with another PR https://reviews.llvm.org/D89972 and other people also faced it https://reviews.llvm.org/D89895

@SjoerdMeijer thanks for the review!
@bryanpkc does everything look fine? Can I commit it?

Merged all into one AArch64SchedTSV110.td, removed aarch64-cpus.c test from this patch

Gentle ping :)

Failure on test "linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp" looks bogus. I found the same cases https://reviews.llvm.org/D89895 and https://reviews.llvm.org/D89964.

In D83912#2161524, @jhenderson wrote:

Hi @Elvina,

Just to let you know that I had to fix up three clang tests that were using the old behaviour too, prior to committing. I also noticed that you've got the stack the wrong way around - you needed to fix the tests before changing the behaviour in this case to avoid breaking the codebase, even if it was only briefly.

Anyway, these are now committed. I'll update the bug.

Thanks to everyone for looking at this!

Sync with master