This is an archive of the discontinued LLVM Phabricator instance.

[NVPTX] Signed char and (unsigned)long overloads of ldg and ldu
ClosedPublic

Authored by jchlanda on Jun 1 2023, 3:48 AM.

Diff Detail

Event Timeline

jchlanda created this revision.Jun 1 2023, 3:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 3:48 AM
jchlanda requested review of this revision.Jun 1 2023, 3:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 3:48 AM
tra accepted this revision.Jun 1 2023, 2:31 PM

I'd change the patch title:

  • [NVPTX] -> [cuda, NVPTX] as these are clang changes, not NVPTX back-end.
  • overloads -> builtins
clang/include/clang/Basic/BuiltinsNVPTX.def
862

One thing that bugs me is that ldg should technically be a TARGET_BUILTIN(..., AND(PTX31,SM_32)).

Oh, well, that train is gone now that pre-sm3x GPUs are no longer supported by NVIDIA anyways.

This revision is now accepted and ready to land.Jun 1 2023, 2:31 PM

I'd change the patch title:

  • [NVPTX] -> [cuda, NVPTX] as these are clang changes, not NVPTX back-end.
  • overloads -> builtins

Sure, will do. Thank you.