This is an archive of the discontinued LLVM Phabricator instance.

Activate OpenMP translation in MLIR execution engine CAPI.
ClosedPublic

Authored by rafaelubalmw on May 26 2023, 11:30 AM.

Details

Summary

We've observed that the MLIR Jit Engine fails when the omp dialect is used due to a failure to register OpenMP-related translations. This small patch addresses this issue.

Diff Detail

Event Timeline

rafaelubalmw created this revision.May 26 2023, 11:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2023, 11:30 AM
rafaelubalmw requested review of this revision.May 26 2023, 11:30 AM
rafaelubalmw retitled this revision from Activate OpenMP translation in MLIR execution engine. to Activate OpenMP translation in MLIR execution engine.May 26 2023, 11:32 AM
rafaelubalmw added reviewers: lhames, shabalin.
rafaelubalmw added a subscriber: sabauma.
rafaelubalmw edited the summary of this revision. (Show Details)Jun 1 2023, 6:36 AM
rafaelubalmw added a reviewer: mehdi_amini.

Can this be tested?

rafaelubalmw retitled this revision from Activate OpenMP translation in MLIR execution engine to Activate OpenMP translation in MLIR execution engine CAPI..

Added unit test

The test for this feature creates an MLIR execution engine using the C API with
an MLIR module containing 'omp' ops. The creation of the execution engine instance
would fail if OpenMP translation had not been activated as expected.

mehdi_amini accepted this revision.Jun 3 2023, 12:59 PM
This revision is now accepted and ready to land.Jun 3 2023, 12:59 PM

Hi @mehdi_amini - I currently don't have commit access to the LLVM repo. If you could merge this approved change, that'd be great. Thanks!

This revision was automatically updated to reflect the committed changes.