Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

sabauma (Spenser Bauman)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 9 2023, 10:05 AM (38 w, 3 d)

Recent Activity

Sep 5 2023

sabauma added a comment to D159382: [mlir][linalg] Fix lowering of tensor.pack operations.

@chelini If there are no other comments, would you mind submitting the change. I do not have commit access.

Sep 5 2023, 11:15 AM · Restricted Project, Restricted Project
sabauma updated the diff for D159382: [mlir][linalg] Fix lowering of tensor.pack operations.

Spelling fix

Sep 5 2023, 7:25 AM · Restricted Project, Restricted Project

Sep 1 2023

sabauma published D159382: [mlir][linalg] Fix lowering of tensor.pack operations for review.
Sep 1 2023, 2:13 PM · Restricted Project, Restricted Project

Jul 14 2023

sabauma added inline comments to D155231: [mlir][tosa] operation printing syntax prettification.
Jul 14 2023, 10:00 AM · Restricted Project, Restricted Project

Jul 7 2023

sabauma added a comment to D154299: [mlir] Implement one-to-n structural conversion for ForOp.

@ingomueller-net Would you be able to submit the change. I do not have commit access.

Jul 7 2023, 7:22 AM · Restricted Project, Restricted Project
sabauma updated the diff for D154299: [mlir] Implement one-to-n structural conversion for ForOp.

Remove InsertionGuard now that https://reviews.llvm.org/D154684 has landed

Jul 7 2023, 5:15 AM · Restricted Project, Restricted Project

Jul 6 2023

sabauma updated the diff for D154299: [mlir] Implement one-to-n structural conversion for ForOp.

Re-add the InsertionGuard

Jul 6 2023, 9:02 AM · Restricted Project, Restricted Project
sabauma added inline comments to D154299: [mlir] Implement one-to-n structural conversion for ForOp.
Jul 6 2023, 8:58 AM · Restricted Project, Restricted Project
sabauma updated the diff for D154299: [mlir] Implement one-to-n structural conversion for ForOp.

test removing insertion guard

Jul 6 2023, 8:34 AM · Restricted Project, Restricted Project
sabauma added inline comments to D154299: [mlir] Implement one-to-n structural conversion for ForOp.
Jul 6 2023, 8:29 AM · Restricted Project, Restricted Project

Jul 5 2023

sabauma added inline comments to D154299: [mlir] Implement one-to-n structural conversion for ForOp.
Jul 5 2023, 5:44 AM · Restricted Project, Restricted Project

Jul 4 2023

sabauma added inline comments to D154299: [mlir] Implement one-to-n structural conversion for ForOp.
Jul 4 2023, 10:45 AM · Restricted Project, Restricted Project
sabauma updated the diff for D154299: [mlir] Implement one-to-n structural conversion for ForOp.

Address comments from @ingomueller-net

Jul 4 2023, 10:42 AM · Restricted Project, Restricted Project

Jul 2 2023

sabauma updated the diff for D154299: [mlir] Implement one-to-n structural conversion for ForOp.

Fix issue where operations created after the signature conversion were generated
inside the loop body rather than after the loop.

Jul 2 2023, 9:16 AM · Restricted Project, Restricted Project
sabauma updated the diff for D154299: [mlir] Implement one-to-n structural conversion for ForOp.

Delete implicitly created body block

Jul 2 2023, 8:24 AM · Restricted Project, Restricted Project
sabauma published D154299: [mlir] Implement one-to-n structural conversion for ForOp for review.
Jul 2 2023, 7:41 AM · Restricted Project, Restricted Project

Jun 22 2023

sabauma added inline comments to D153291: TOSA-to-Linalg lowering for element-wise ops.
Jun 22 2023, 9:09 AM · Restricted Project, Restricted Project

Jun 14 2023

sabauma added a comment to D151707: [mlir][tosa] Improve lowering support for tosa.concat.

Addressed @rsuderman's feedback.

Jun 14 2023, 6:39 AM · Restricted Project, Restricted Project

Jun 13 2023

sabauma updated the diff for D151707: [mlir][tosa] Improve lowering support for tosa.concat.

Address rsuderman's comments on test cases

Jun 13 2023, 6:41 AM · Restricted Project, Restricted Project

Jun 7 2023

sabauma added a comment to D151707: [mlir][tosa] Improve lowering support for tosa.concat.

@rsuderman Could you elaborate more on your last point in the review:

Jun 7 2023, 6:17 AM · Restricted Project, Restricted Project

Jun 6 2023

sabauma added inline comments to D151707: [mlir][tosa] Improve lowering support for tosa.concat.
Jun 6 2023, 3:21 PM · Restricted Project, Restricted Project
sabauma updated the diff for D151707: [mlir][tosa] Improve lowering support for tosa.concat.

Convert additional concat test to use CHECK-DAG

Jun 6 2023, 10:17 AM · Restricted Project, Restricted Project

Jun 2 2023

sabauma added inline comments to D151707: [mlir][tosa] Improve lowering support for tosa.concat.
Jun 2 2023, 2:38 PM · Restricted Project, Restricted Project
sabauma updated the diff for D151707: [mlir][tosa] Improve lowering support for tosa.concat.

Lock down computation of the total size of the output tensor

Jun 2 2023, 2:34 PM · Restricted Project, Restricted Project
sabauma updated the diff for D151707: [mlir][tosa] Improve lowering support for tosa.concat.

Address rsuderman's comments

Jun 2 2023, 1:59 PM · Restricted Project, Restricted Project

May 30 2023

sabauma published D151707: [mlir][tosa] Improve lowering support for tosa.concat for review.
May 30 2023, 7:18 AM · Restricted Project, Restricted Project

May 26 2023

sabauma added a comment to D151095: [mlir][tosa] Implement lowering for tosa.rfft2d.

If there are no other comments, would someone mind submitting this change, since I do not have commit access?

May 26 2023, 12:07 PM · Restricted Project, Restricted Project
sabauma added a comment to D151117: Lowering for 'tosa.scatter'.

to have a working legalization to linalg.

Is there a path from there to linalg? It's not clear to me how it works?
And actually I'm wondering if this lowering could be expressed with a linalg.generic indeed?

May 26 2023, 4:39 AM · Restricted Project, Restricted Project

May 25 2023

sabauma updated the diff for D151228: [tosa] Improve inferred shapes of TOSA operations.

Revert accidental change to file

May 25 2023, 6:56 AM · Restricted Project, Restricted Project
sabauma updated the diff for D151228: [tosa] Improve inferred shapes of TOSA operations.

Address @eric-k256's comments

May 25 2023, 6:55 AM · Restricted Project, Restricted Project
sabauma added a reviewer for D151095: [mlir][tosa] Implement lowering for tosa.rfft2d: eric-k256.
May 25 2023, 6:47 AM · Restricted Project, Restricted Project

May 24 2023

sabauma published D151228: [tosa] Improve inferred shapes of TOSA operations for review.
May 24 2023, 6:54 AM · Restricted Project, Restricted Project

May 22 2023

sabauma published D151095: [mlir][tosa] Implement lowering for tosa.rfft2d for review.
May 22 2023, 8:25 AM · Restricted Project, Restricted Project

May 16 2023

sabauma added a comment to D150439: [mlir][tosa] Fix constant folding of tosa.mul.

@jpienaar Would you mind submitting this change then, since I do not have commit privileges?

May 16 2023, 1:38 PM · Restricted Project, Restricted Project

May 15 2023

sabauma added a comment to D150439: [mlir][tosa] Fix constant folding of tosa.mul.

We should not be folding if the type changes AFAIK (I think that may not be enforced ...). Is this change effectively ensuring it doesn't change types?

May 15 2023, 9:28 AM · Restricted Project, Restricted Project

May 13 2023

sabauma added a reviewer for D150439: [mlir][tosa] Fix constant folding of tosa.mul: jpienaar.
May 13 2023, 6:16 PM · Restricted Project, Restricted Project

May 12 2023

sabauma published D150439: [mlir][tosa] Fix constant folding of tosa.mul for review.
May 12 2023, 6:09 AM · Restricted Project, Restricted Project

May 2 2023

sabauma added a comment to D149582: [mlir][tosa] Fix crash when inferring shape of tosa.equal.

If there are no other comments, could someone with submission privileges please submit the patch?

May 2 2023, 5:15 AM · Restricted Project, Restricted Project

May 1 2023

sabauma published D149582: [mlir][tosa] Fix crash when inferring shape of tosa.equal for review.
May 1 2023, 7:25 AM · Restricted Project, Restricted Project

Apr 10 2023

sabauma published D147810: [mlir][tosa] Lowering of tosa.gather operations with dynamic dimensions for review.
Apr 10 2023, 5:48 AM · Restricted Project, Restricted Project

Mar 24 2023

sabauma added a comment to D146526: [mlir][tosa] Improve performance of tosa.transpose constant folding.

@stellaraccident @GeorgeARM if this change looks acceptable, would one of you mind submitting it? I do not have commit access.

Mar 24 2023, 12:20 PM · Restricted Project, Restricted Project
sabauma added inline comments to D146526: [mlir][tosa] Improve performance of tosa.transpose constant folding.
Mar 24 2023, 10:23 AM · Restricted Project, Restricted Project
sabauma updated the diff for D146526: [mlir][tosa] Improve performance of tosa.transpose constant folding.

Address @stellaraccident's comments

Mar 24 2023, 10:12 AM · Restricted Project, Restricted Project
sabauma added a reviewer for D146526: [mlir][tosa] Improve performance of tosa.transpose constant folding: stellaraccident.
Mar 24 2023, 7:27 AM · Restricted Project, Restricted Project

Mar 23 2023

sabauma updated the diff for D146526: [mlir][tosa] Improve performance of tosa.transpose constant folding.

Avoid converting data to mlir::Attributes in all cases

Mar 23 2023, 6:37 AM · Restricted Project, Restricted Project
sabauma added a reviewer for D146526: [mlir][tosa] Improve performance of tosa.transpose constant folding: rsuderman.
Mar 23 2023, 6:10 AM · Restricted Project, Restricted Project

Mar 22 2023

sabauma published D146526: [mlir][tosa] Improve performance of tosa.transpose constant folding for review.
Mar 22 2023, 5:37 AM · Restricted Project, Restricted Project