D151036 adds an assertions that prohibits iterating over sub- and
super-registers of a null register. This is already the case when
iterating over register units of a null register, and worked by
accident for sub- and super-registers.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I noticed there are some lines like:
2955 unsigned TmpReg = DstReg; 2956 if (UseSrcReg && 2957 getContext().getRegisterInfo()->isSuperOrSubRegisterEq(DstReg, 2958 SrcReg)) { 2959 // If $rs is the same as $rd, we need to use AT. 2960 // If it is not available we exit. 2961 unsigned ATReg = getATReg(IDLoc); 2962 if (!ATReg) 2963 return true; 2964 TmpReg = ATReg; 2965 }
Is UseSrcReg OK for here?
Comment Actions
Whoops, I committed a change with wrong commit message referring to this review (copy&pasted) and the review was closed automatically >_<
Reopening