Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D151055

[PowerPC] Use ABDU to replace ABDS when operands are known to be zero extended
AbandonedPublic
Actions

Authored by lkail on May 21 2023, 8:52 PM.

Details

Reviewers
RKSimon
shchenz
qiucf
nemanjai
Group Reviewers
Restricted Project
Summary

For pwr9 cpu, we can save xvnegsp instruction. Alive2 proof https://alive2.llvm.org/ce/z/LWaEEg.

Diff Detail

Event Timeline

lkail created this revision.May 21 2023, 8:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2023, 8:52 PM
Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. · View Herald Transcript
lkail requested review of this revision.May 21 2023, 8:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2023, 8:52 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
lkail retitled this revision from [PowerPC] Use ABDU node when operands are known to be zero extended to [PowerPC] Use ABDU to replace ABDS when operands are known to be zero extended.May 21 2023, 9:16 PM
lkail mentioned this in rG330319557f6e: [PowerPC] Precommit test for D151055. NFC..May 21 2023, 9:22 PM
lkail updated this revision to Diff 524156.May 21 2023, 9:29 PM
lkail added reviewers: Restricted Project, RKSimon, shchenz, qiucf, nemanjai.
Harbormaster completed remote builds in B233468: Diff 524152.May 21 2023, 9:29 PM
Harbormaster completed remote builds in B233472: Diff 524156.May 21 2023, 10:04 PM
RKSimon added a comment.Jun 15 2023, 3:29 AM

Why not handle this generically in DAGCombiner::visitABD?

RKSimon mentioned this in D153328: [DAG] Fold (abds x, y) -> (abdu x, y) iff both args are known positive.Jun 20 2023, 3:24 AM
lkail abandoned this revision.Jun 20 2023, 4:50 AM

Simon has got a better solution.

RKSimon mentioned this in rGff23856c1c0c: [DAG] Fold (abds x, y) -> (abdu x, y) iff both args are known positive.Jun 20 2023, 7:31 AM

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
PowerPC/
1 line
22 lines
test/
CodeGen/
PowerPC/
12 lines

Diff 524156

View Options

llvm/lib/Target/PowerPC/PPCISelLowering.h

Loading...
View Options

llvm/lib/Target/PowerPC/PPCISelLowering.cpp

Loading...
View Options

llvm/test/CodeGen/PowerPC/vec-zext-abdu.ll

Loading...