This is an archive of the discontinued LLVM Phabricator instance.

[Clang] Remove direct linking of offloading runtimes from the arch tools
ClosedPublic

Authored by jhuber6 on May 17 2023, 11:24 AM.

Details

Summary

The tools amdgpu-arch and nvptx-arch are used to query the supported
GPUs on a system to implement features like --offload-arch=native as
well as generally being useful for setting up tests. However, we
currently directly link these if they are availible. This patch removes
this because it causes many problems on the user not having the libaries
present or misconfigured at build time. Since these are built
unconditionally we shoudl keep the dependencies away from clang.

Fixes https://github.com/llvm/llvm-project/issues/62784

Diff Detail

Event Timeline

jhuber6 created this revision.May 17 2023, 11:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2023, 11:24 AM
jhuber6 requested review of this revision.May 17 2023, 11:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2023, 11:24 AM
jhuber6 updated this revision to Diff 523125.May 17 2023, 11:26 AM

Remove now unused definitions

ye-luo accepted this revision.May 17 2023, 12:38 PM
This revision is now accepted and ready to land.May 17 2023, 12:38 PM
This revision was landed with ongoing or failed builds.May 17 2023, 3:48 PM
This revision was automatically updated to reflect the committed changes.