This is an archive of the discontinued LLVM Phabricator instance.

[mlir] NFC: use !transform.any_op in relevant tests
ClosedPublic

Authored by ftynse on May 17 2023, 8:13 AM.

Details

Summary

Update various tests using Transform dialect extensions to pervasively
use !transform.any_op instead of !pdl.operation. Tests are sometimes
used as source of knowledge for best practices and these were doing the
opposite of what is considered best practices per
https://discourse.llvm.org/t/rfc-type-system-for-the-transform-dialect/65702.

Diff Detail

Event Timeline

ftynse created this revision.May 17 2023, 8:13 AM
Herald added a project: Restricted Project. · View Herald Transcript
ftynse requested review of this revision.May 17 2023, 8:13 AM
Herald added a project: Restricted Project. · View Herald Transcript
nicolasvasilache accepted this revision.May 17 2023, 8:56 AM
This revision is now accepted and ready to land.May 17 2023, 8:56 AM
This revision was automatically updated to reflect the committed changes.