This is an archive of the discontinued LLVM Phabricator instance.

[mlir] don't hardcode PDL_Operation in TestTransformDialectExtensions
ClosedPublic

Authored by ftynse on May 17 2023, 8:14 AM.

Details

Summary

Update operations in Transform dialect extensions used for testing to
use the more generic TransformHandleTypeInterface type constraint
instead of hardcoding PDL_Operation. See
https://discourse.llvm.org/t/rfc-type-system-for-the-transform-dialect/65702
for motivation. This is particularly important as these tests are often
used as source of best practices.

Update tests to use !transform.any_op instead of !pdl.operation.

Depends On D150785

Diff Detail

Event Timeline

ftynse created this revision.May 17 2023, 8:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2023, 8:14 AM
ftynse requested review of this revision.May 17 2023, 8:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2023, 8:14 AM
nicolasvasilache accepted this revision.May 17 2023, 8:56 AM
This revision is now accepted and ready to land.May 17 2023, 8:56 AM