This is an archive of the discontinued LLVM Phabricator instance.

Differential D150586

[clang][AIX] Remove Newly Added Target Dependent Test Case
ClosedPublic

Authored by qiongsiwu1 on May 15 2023, 9:25 AM.

Details

Reviewers
hubert.reinterpretcast
stephenpeckham
MaskRay
cebowleratibm
Commits
rG80cf56ea1bae: [clang][AIX] Remove Newly Added Target Dependent Test Case
Summary

https://reviews.llvm.org/D144190 added a test case that is target dependent and requires assembly code generation, which fails on x64 and aarch64 buildbots. This patch removes the test case. We have test cases for code generation added in https://reviews.llvm.org/D144189 already and this removed case was nice to have.

Diff Detail

Unit TestsFailed

TimeTest
3,760 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases/Linux::auto_memory_profile_test.cpp
460 msx64 debian > Clang.Preprocessor::init.c

Event Timeline

qiongsiwu1 created this revision.May 15 2023, 9:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2023, 9:25 AM
Herald added subscribers: kristof.beyls, nemanjai. · View Herald Transcript
qiongsiwu1 requested review of this revision.May 15 2023, 9:25 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptMay 15 2023, 9:25 AM
qiongsiwu1 added a comment.EditedMay 15 2023, 9:26 AM

I can revise the case and add it as a backend/llc test case with a different patch if we would like to keep it.

qiongsiwu1 mentioned this in D144190: [AIX][clang] Storage Locations for Constant Pointers.May 15 2023, 9:26 AM
stephenpeckham accepted this revision.May 15 2023, 9:52 AM
This revision is now accepted and ready to land.May 15 2023, 9:52 AM
This revision was landed with ongoing or failed builds.May 15 2023, 9:55 AM
Closed by commit rG80cf56ea1bae: [clang][AIX] Remove Newly Added Target Dependent Test Case (authored by qiongsiwu1). · Explain Why
This revision was automatically updated to reflect the committed changes.
qiongsiwu1 added a commit: rG80cf56ea1bae: [clang][AIX] Remove Newly Added Target Dependent Test Case.
qiongsiwu1 mentioned this in D150597: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case.May 15 2023, 11:20 AM
Harbormaster completed remote builds in B232038: Diff 522228.May 15 2023, 12:32 PM
qiongsiwu1 mentioned this in rG1b1f1b9079e2: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case.May 16 2023, 6:44 AM

Revision Contents

PathSize
clang/
test/
CodeGen/
PowerPC/

Diff 522228

clang/test/CodeGen/PowerPC/aix-roptr.c

  • This file was deleted.
// RUN: %clang_cc1 -triple=powerpc-ibm-aix-xcoff -mxcoff-roptr -fdata-sections \
// RUN: -S <%s | FileCheck %s --check-prefix=CHECK32
// RUN: %clang_cc1 -triple=powerpc64-ibm-aix-xcoff -mxcoff-roptr -fdata-sections \
// RUN: -S <%s | FileCheck %s --check-prefix=CHECK64
// RUN: not %clang_cc1 -triple=powerpc-ibm-aix-xcoff -mxcoff-roptr \
// RUN: -S <%s 2>&1 | FileCheck %s --check-prefix=DATA_SECTION_ERR
// RUN: not %clang_cc1 -triple=powerpc64-ibm-aix-xcoff -mxcoff-roptr \
// RUN: -S <%s 2>&1 | FileCheck %s --check-prefix=DATA_SECTION_ERR
// RUN: not %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -mxcoff-roptr \
// RUN: %s 2>&1 | FileCheck %s --check-prefix=TARGET_ROPTR_ERR
char c1 = 10;
char* const c1_ptr = &c1;
// CHECK32: .csect c1_ptr[RO],2
// CHECK32-NEXT: .globl c1_ptr[RO]
// CHECK32-NEXT: .align 2
// CHECK32-NEXT: .vbyte 4, c1[RW]
// CHECK64: .csect c1_ptr[RO],3
// CHECK64-NEXT: .globl c1_ptr[RO]
// CHECK64-NEXT: .align 3
// CHECK64-NEXT: .vbyte 8, c1[RW]
// DATA_SECTION_ERR: error: -mxcoff-roptr is supported only with -fdata-sections
// TARGET_ROPTR_ERR: error: unsupported option '-mxcoff-roptr' for target 'powerpc64le-unknown-linux-gnu'