This is an archive of the discontinued LLVM Phabricator instance.

Differential D150597

[clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case
ClosedPublic

Authored by qiongsiwu1 on May 15 2023, 11:20 AM.

Details

Reviewers
hubert.reinterpretcast
stephenpeckham
Commits
rG1b1f1b9079e2: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case
Summary

https://reviews.llvm.org/D150586 removed a problematic test cases that caused failures on non-ppc buildbots. This patch revises the test case and adds it back.

Diff Detail

Event Timeline

qiongsiwu1 created this revision.May 15 2023, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2023, 11:20 AM
Herald added a subscriber: nemanjai. · View Herald Transcript
qiongsiwu1 requested review of this revision.May 15 2023, 11:20 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptMay 15 2023, 11:20 AM
Harbormaster completed remote builds in B232068: Diff 522274.May 15 2023, 3:01 PM
hubert.reinterpretcast accepted this revision.May 15 2023, 8:36 PM

LGTM; thanks!

This revision is now accepted and ready to land.May 15 2023, 8:36 PM
Closed by commit rG1b1f1b9079e2: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case (authored by qiongsiwu1). · Explain WhyMay 16 2023, 6:44 AM
This revision was automatically updated to reflect the committed changes.
qiongsiwu1 added a commit: rG1b1f1b9079e2: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case.

Revision Contents

PathSize
clang/
test/
CodeGen/
PowerPC/
26 lines

Diff 522590

clang/test/CodeGen/PowerPC/aix-roptr.c

  • This file was added.
// REQUIRES: powerpc-registered-target
// RUN: %clang_cc1 -triple=powerpc-ibm-aix-xcoff -mxcoff-roptr -fdata-sections \
// RUN: -S <%s | FileCheck %s --check-prefix=CHECK32
// RUN: %clang_cc1 -triple=powerpc64-ibm-aix-xcoff -mxcoff-roptr -fdata-sections \
// RUN: -S <%s | FileCheck %s --check-prefix=CHECK64
// RUN: not %clang_cc1 -triple=powerpc-ibm-aix-xcoff -mxcoff-roptr \
// RUN: -S <%s 2>&1 | FileCheck %s --check-prefix=DATA_SECTION_ERR
// RUN: not %clang_cc1 -triple=powerpc64-ibm-aix-xcoff -mxcoff-roptr \
// RUN: -S <%s 2>&1 | FileCheck %s --check-prefix=DATA_SECTION_ERR
// RUN: not %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -mxcoff-roptr \
// RUN: %s 2>&1 | FileCheck %s --check-prefix=TARGET_ROPTR_ERR
char c1 = 10;
char* const c1_ptr = &c1;
// CHECK32: .csect c1_ptr[RO],2
// CHECK32-NEXT: .globl c1_ptr[RO]
// CHECK32-NEXT: .align 2
// CHECK32-NEXT: .vbyte 4, c1[RW]
// CHECK64: .csect c1_ptr[RO],3
// CHECK64-NEXT: .globl c1_ptr[RO]
// CHECK64-NEXT: .align 3
// CHECK64-NEXT: .vbyte 8, c1[RW]
// DATA_SECTION_ERR: error: -mxcoff-roptr is supported only with -fdata-sections
// TARGET_ROPTR_ERR: error: unsupported option '-mxcoff-roptr' for target 'powerpc64le-unknown-linux-gnu'