Change the lowering of SVE integer mla_x/mls_x and mad_x/msb_x
builtins to use dedicated undef (_u) intrinsics.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/include/llvm/IR/IntrinsicsAArch64.td | ||
---|---|---|
1666 | it is not a bug, but just a preference to keep better ordering here, could you move this new definition to be straight below the def int_aarch64_sve_mla ? so the regular and _u intrinsics are defined in the same order as in all other cases. Same request to the mls_u definition. |
The commit message is incorrect because the SVE Clang builtins are not named mla_u and so should read SVE integer mla_x/mls_x builtins Other than that the patch looks good to me with the following suggestions.
llvm/test/CodeGen/AArch64/sve-intrinsics-int-arith-undef.ll | ||
---|---|---|
1307 | Just because this is a big file can you follow the existing scheme of sorting alphabetically (i.e. move the new block just before the @mul functions and prefix the two blocks with ; ; MLA ; ; ; MLS ; accordingly. This just makes it easier to find things when manually scrolling. | |
1379–1387 | As above, please maintain the ordering by moving these declaration just before those for mul. |
it is not a bug, but just a preference to keep better ordering here, could you move this new definition to be straight below the def int_aarch64_sve_mla ? so the regular and _u intrinsics are defined in the same order as in all other cases.
Same request to the mls_u definition.