This is an archive of the discontinued LLVM Phabricator instance.

[llvm] Reduce ComplexDeinterleavingPass.h includes
ClosedPublic

Authored by IncludeGuardian on May 13 2023, 3:03 PM.

Details

Summary

Remove the unnecessary "llvm/IR/PatternMatch.h" include directive from
ComplexDeinterleavingPass.h and move it to the corresponding source
file.

Add missing includes that were transitively included by this header to 2
other source files.

This reduces the total number of preprocessing tokens across the LLVM
source files in lib from (roughly) 1,964,876,961 to 1,935,091,611 - a
reduction of ~1.52%. This should result in a small improvement in
compilation time.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2023, 3:03 PM
IncludeGuardian requested review of this revision.May 13 2023, 3:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2023, 3:03 PM

This was found with IncludeGuardian 0.0.8 and the recommendation was given here https://gist.github.com/IncludeGuardian/d1c99ea959de2f0fe48edbd87bf1491a#file-before-yaml-L4054-L4057

The estimates of token count were run before and after this commit and can be seen here before.yaml (1,964,876,961) and after.yaml (1,935,091,611).

nikic accepted this revision.May 16 2023, 3:37 AM
nikic added a subscriber: nikic.

LGTM. If you need me to commit this for you, please share the Name <email> to use.

This revision is now accepted and ready to land.May 16 2023, 3:37 AM
IncludeGuardian added a subscriber: foad.EditedMay 16 2023, 1:48 PM

If you could commit for me @foad that would be great - Elliot Goodrich <elliotgoodrich@gmail.com>. Thank you!

Elliot just a suggestion, but if you plan to continue contributing to LLVM, please request commit access. You can find the policy in the LLVM Developer Policy, thx!

@lattner I will do that thanks. I still have a bunch of pending changes that should shave off more time from compilation.