The full output of ClangBuildAnalyzer with the removed template line highlighted is here

Corresponding PR (https://github.com/google/googletest/pull/4330) and issue (https://github.com/google/googletest/issues/4329) for GoogleTest.

@fdeazeve Thank you!

@MaskRay seems like ninja on its own after preparing lldb isn't enough to build tests. I've now built llvm, clang, flang, bolt, lldb, + tests - I'm hoping that this is it now!

After the previous attempt, I believe only LLDB was failing to compile. These are the necessary changes needed to fix all of LLDB locally on main.

Run clang-format over changes

Rebasing on main

@MaskRay Thanks. I have updated the title to use [Support] and I will land the additional includes separately to the removal. This was very good advice last attempt as it I did have to revert the change.

Fix XCOFFDump.cpp

Fix CompressionTest.cpp

This was found with IncludeGuardian 0.0.8 and the recommendation was given here https://gist.github.com/IncludeGuardian/4132d5149576a55e0560fae6f8ff4a38#file-before-yaml-L4053-L4055

@MaskRay good idea, I have split into 2 commits and pushed to the main

Fix missing includes for Windows-only files

Add back all includes (bad arc change)

Fix missing include

@barannikov88 no it's not. I was going to commit separately to keep the change small, but it turns out that if I move this to the source file there are no additional changes needed. SmallVector.h has now been moved to Error.cpp as well.

Fix compile issues

This was found with IncludeGuardian 0.0.8.

This is good to review now. Phabricator has become a bit confused after rebasing on top of https://reviews.llvm.org/D151557, I don't know whether it's worth creating a new, cleaner review and close this on?

Run clang-format over patch

Fix missing includes in test, fix formatting, and rebase on top of https://reviews.llvm.org/D151557

Anyone want to give this a final look and approval?

LGTM!

@kadircet Thanks I will run this through the formatter.

Merged as ac73c48e091cff69047ed2dfb972f69ef7a0e9a0

Add missing specialization for clang-include-cleaner/Types.h