[mlir][linalg][vector] Remove TODOs to change print format of iterator_type attribute.

[olegshyshkov]

Summary

There are no current plans to change the print format.

[mehdi_amini]

mlir/lib/Dialect/Vector/IR/VectorOps.cpp

712

Why aren't we upgrading here?

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

void GenericOp::print(OpAsmPrinter &p) {
   genericAttrNamesSet.insert(genericAttrNames.begin(), genericAttrNames.end());
   SmallVector<NamedAttribute, 8> genericAttrs;
   for (auto attr : (*this)->getAttrs()) {
     if (attr.getName() == getIteratorTypesAttrName()) {
       auto iteratorTypes =
           attr.getValue()
               .cast<ArrayAttr>()
               .getAsValueRange<IteratorTypeAttr, utils::IteratorType>();
-      // Convert IteratorType enums into the string representation. This is
-      // needed, because tests still use the old format when 'iterator_types'
-      // attribute is represented as an array of strings.
-      // TODO: Remove this conversion once tests are fixed.
+      // Convert IteratorType enums into the string representation. Iterator
+      // types are printed as an array of string for legacy reasons.
       SmallVector<Attribute> iteratorTypeNames =
           llvm::to_vector(llvm::map_range(
               iteratorTypes, [&](utils::IteratorType t) -> Attribute {
                 return StringAttr::get(getContext(), stringifyIteratorType(t));
               }));
 
       genericAttrs.emplace_back(
           getIteratorTypesAttrName(),
ParseResult GenericOp::parse(OpAsmParser &parser, OperationState &result) {
   // The core linalg traits must contain the information necessary to pass the
   // verifier.
   llvm::SMLoc attributeLocation = parser.getCurrentLocation();
   if (parser.parseAttribute(dictAttr, "_", result.attributes))
     return failure();
   result.attributes.assign(dictAttr.getValue().begin(),
                            dictAttr.getValue().end());
 
-  // Convert array of string into an array of IteratorType enums. This is
-  // needed, because tests still use the old format when 'iterator_types'
-  // attribute is represented as an array of strings.
-  // TODO: Remove this conversion once tests are fixed.
+  // Convert array of string into an array of IteratorType. Iterator
+  // types are printed as an array of string for legacy reasons.
   auto iteratorTypes = dyn_cast_or_null<ArrayAttr>(
       result.attributes.get(getIteratorTypesAttrName(result.name)));
   if (!iteratorTypes) {
     return parser.emitError(attributeLocation)
            << "expected " << getIteratorTypesAttrName(result.name)
            << " array attribute";
   }
 

mlir/lib/Dialect/Vector/IR/VectorOps.cpp

if (parser.parseAttribute(dictAttr) || parser.parseOperand(lhsInfo) ||
       parser.resolveOperand(lhsInfo, types[0], result.operands) ||
       parser.resolveOperand(rhsInfo, types[1], result.operands) ||
       parser.resolveOperand(accInfo, resultType, result.operands) ||
       parser.addTypeToList(resultType, result.types))
     return failure();
   result.attributes.append(dictAttr.getValue().begin(),
                            dictAttr.getValue().end());
 
-  // Convert array of string into an array of IteratyType enums. This is needed,
-  // because tests still use the old format when 'iterator_types' attribute is
-  // represented as an array of strings.
-  // TODO: Remove this conversion once tests are fixed.
+  // Convert array of string into an array of IteratorType. Iterator
+  // types are printed as an array of string for legacy reasons.
   ArrayAttr iteratorTypes =
       result.attributes.get(getIteratorTypesAttrName(result.name))
           .cast<ArrayAttr>();
 
   SmallVector<Attribute> iteratorTypeAttrs;
 
   for (StringRef s : iteratorTypes.getAsValueRange<StringAttr>()) {
     auto maybeIteratorType = symbolizeIteratorType(s);
void ContractionOp::print(OpAsmPrinter &p) {
   traitAttrsSet.insert(attrNames.begin(), attrNames.end());
   SmallVector<NamedAttribute, 8> attrs;
   for (auto attr : (*this)->getAttrs()) {
     if (attr.getName() == getIteratorTypesAttrName()) {
       auto iteratorTypes =
           attr.getValue()
               .cast<ArrayAttr>()
               .getAsValueRange<IteratorTypeAttr, IteratorType>();
-      // Convert IteratorType enums into the string representation. This is
-      // needed, because tests still use the old format when 'iterator_types'
-      // attribute is represented as an array of strings.
-      // TODO: Remove this conversion once tests are fixed.
+      // Convert IteratorType enums into the string representation. Iterator
+      // types are printed as an array of string for legacy reasons.
       SmallVector<Attribute> iteratorTypeNames = llvm::to_vector(
           llvm::map_range(iteratorTypes, [&](IteratorType t) -> Attribute {
             return StringAttr::get(getContext(), stringifyIteratorType(t));
           }));
 
       attrs.emplace_back(getIteratorTypesAttrName(),
                          ArrayAttr::get(getContext(), iteratorTypeNames));
     } else if (traitAttrsSet.count(attr.getName().strref()) > 0)