Page MenuHomePhabricator

olegshyshkov (Oleg Shyshkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 24 2022, 6:32 AM (23 w, 5 d)

Recent Activity

Mon, Jan 9

olegshyshkov accepted D141259: Reupoading: Apply shortened printing/parsing form to linalg.reduce..

Thank you!

Mon, Jan 9, 2:01 AM · Restricted Project, Restricted Project
olegshyshkov added inline comments to D141259: Reupoading: Apply shortened printing/parsing form to linalg.reduce..
Mon, Jan 9, 1:34 AM · Restricted Project, Restricted Project

Dec 23 2022

olegshyshkov accepted D140622: Apply shortened printing/parsing form to linalg.reduce..

Awesome! Thank you!

Dec 23 2022, 5:07 AM · Restricted Project, Restricted Project

Dec 22 2022

olegshyshkov accepted D140535: [mlir][linalg] Reuploading: add a shortened printing/parsing form for linalg.map and linalg.reduce..

Could you please add links to the original review and the revert commit?

Dec 22 2022, 2:55 AM · Restricted Project, Restricted Project

Dec 14 2022

olegshyshkov committed rG07335f9460ff: [mlir] Fix bazel build for https://reviews.llvm.org/D139187. (authored by olegshyshkov).
[mlir] Fix bazel build for https://reviews.llvm.org/D139187.
Dec 14 2022, 8:06 AM · Restricted Project

Nov 21 2022

olegshyshkov committed rG3598c24983be: [mlir][linalg] Change linalg.broadcast `dimensions` attribute to represent… (authored by olegshyshkov).
[mlir][linalg] Change linalg.broadcast `dimensions` attribute to represent…
Nov 21 2022, 4:17 AM · Restricted Project, Restricted Project
olegshyshkov closed D138408: [mlir][linalg] Change linalg.broadcast `dimensions` attribute to represent added dimensions..
Nov 21 2022, 4:17 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D138408: [mlir][linalg] Change linalg.broadcast `dimensions` attribute to represent added dimensions..

Fix tiling test.

Nov 21 2022, 2:00 AM · Restricted Project, Restricted Project
olegshyshkov updated the summary of D138408: [mlir][linalg] Change linalg.broadcast `dimensions` attribute to represent added dimensions..
Nov 21 2022, 1:51 AM · Restricted Project, Restricted Project
olegshyshkov updated the summary of D138408: [mlir][linalg] Change linalg.broadcast `dimensions` attribute to represent added dimensions..
Nov 21 2022, 1:50 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D138408: [mlir][linalg] Change linalg.broadcast `dimensions` attribute to represent added dimensions..
Nov 21 2022, 1:49 AM · Restricted Project, Restricted Project

Nov 18 2022

olegshyshkov committed rG244105f79153: [mlir][linalg] Do not check if added dimension are static in linalg.broadcast. (authored by olegshyshkov).
[mlir][linalg] Do not check if added dimension are static in linalg.broadcast.
Nov 18 2022, 6:51 AM · Restricted Project, Restricted Project
olegshyshkov closed D138291: [mlir][linalg] Do not check if added dimension are static in linalg.broadcast..
Nov 18 2022, 6:51 AM · Restricted Project, Restricted Project
olegshyshkov added a comment to D138291: [mlir][linalg] Do not check if added dimension are static in linalg.broadcast..

Thank you! I'll prepare the follow-up patch.

Nov 18 2022, 6:50 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D138291: [mlir][linalg] Do not check if added dimension are static in linalg.broadcast..

Fix tests.

Nov 18 2022, 5:45 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D138291: [mlir][linalg] Do not check if added dimension are static in linalg.broadcast..
Nov 18 2022, 5:33 AM · Restricted Project, Restricted Project

Nov 11 2022

olegshyshkov added a reverting change for rG41280908e43d: Revert "[mlir][linalg] Replace "string" iterator_types attr with enums in…: rGe6598b053dc7: Revert "Revert "[mlir][linalg] Replace "string" iterator_types attr with enums….
Nov 11 2022, 1:59 AM · Restricted Project, Restricted Project
olegshyshkov committed rGe6598b053dc7: Revert "Revert "[mlir][linalg] Replace "string" iterator_types attr with enums… (authored by olegshyshkov).
Revert "Revert "[mlir][linalg] Replace "string" iterator_types attr with enums…
Nov 11 2022, 1:59 AM · Restricted Project, Restricted Project

Nov 9 2022

olegshyshkov added a reverting change for rGb809d73973bb: [mlir][linalg] Replace "string" iterator_types attr with enums in…: rG41280908e43d: Revert "[mlir][linalg] Replace "string" iterator_types attr with enums in….
Nov 9 2022, 7:01 AM · Restricted Project, Restricted Project
olegshyshkov committed rG41280908e43d: Revert "[mlir][linalg] Replace "string" iterator_types attr with enums in… (authored by olegshyshkov).
Revert "[mlir][linalg] Replace "string" iterator_types attr with enums in…
Nov 9 2022, 7:01 AM · Restricted Project, Restricted Project
olegshyshkov added a reverting change for D137658: [mlir][linalg] Replace "string" iterator_types attr with enums in LinalgInterface.: rG41280908e43d: Revert "[mlir][linalg] Replace "string" iterator_types attr with enums in….
Nov 9 2022, 7:01 AM · Restricted Project, Restricted Project
olegshyshkov committed rGb809d73973bb: [mlir][linalg] Replace "string" iterator_types attr with enums in… (authored by olegshyshkov).
[mlir][linalg] Replace "string" iterator_types attr with enums in…
Nov 9 2022, 6:48 AM · Restricted Project, Restricted Project
olegshyshkov closed D137658: [mlir][linalg] Replace "string" iterator_types attr with enums in LinalgInterface..
Nov 9 2022, 6:48 AM · Restricted Project, Restricted Project
olegshyshkov abandoned D137421: [mlir] Move helper function to work with IteratorTypes to StructuredOpsUtils..
Nov 9 2022, 2:51 AM · Restricted Project, Restricted Project
olegshyshkov added a comment to D137421: [mlir] Move helper function to work with IteratorTypes to StructuredOpsUtils..

I expected that this patch will help reduce the size of https://reviews.llvm.org/D137658, but the gain is so small, I don't think it's worth proceeding. I'll just drop this change.

Nov 9 2022, 2:50 AM · Restricted Project, Restricted Project

Nov 8 2022

olegshyshkov requested review of D137658: [mlir][linalg] Replace "string" iterator_types attr with enums in LinalgInterface..
Nov 8 2022, 10:14 AM · Restricted Project, Restricted Project

Nov 7 2022

olegshyshkov committed rGbada35390ad7: [mlir][NFC] Remove unnecessary attr name getters from StructuredOpsUtils.h. (authored by olegshyshkov).
[mlir][NFC] Remove unnecessary attr name getters from StructuredOpsUtils.h.
Nov 7 2022, 5:41 AM · Restricted Project, Restricted Project
olegshyshkov closed D137544: [mlir][NFC] Remove unnecessary attr name getters from StructuredOpsUtils.h..
Nov 7 2022, 5:41 AM · Restricted Project, Restricted Project
olegshyshkov retitled D137544: [mlir][NFC] Remove unnecessary attr name getters from StructuredOpsUtils.h. from [mlir][NFC] Remove unnecassary attr name getters from StructuredOpsUtils.h. to [mlir][NFC] Remove unnecessary attr name getters from StructuredOpsUtils.h..
Nov 7 2022, 5:38 AM · Restricted Project, Restricted Project
olegshyshkov added a comment to D137544: [mlir][NFC] Remove unnecessary attr name getters from StructuredOpsUtils.h..

Thank you!

Nov 7 2022, 5:36 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D137544: [mlir][NFC] Remove unnecessary attr name getters from StructuredOpsUtils.h..
Nov 7 2022, 5:11 AM · Restricted Project, Restricted Project

Nov 4 2022

olegshyshkov added inline comments to D137421: [mlir] Move helper function to work with IteratorTypes to StructuredOpsUtils..
Nov 4 2022, 2:51 PM · Restricted Project, Restricted Project
olegshyshkov requested review of D137421: [mlir] Move helper function to work with IteratorTypes to StructuredOpsUtils..
Nov 4 2022, 6:46 AM · Restricted Project, Restricted Project
olegshyshkov committed rGfd64de321299: [mlir][linalg] Add BroadcastOp to Linalg structured ops. (authored by olegshyshkov).
[mlir][linalg] Add BroadcastOp to Linalg structured ops.
Nov 4 2022, 4:08 AM · Restricted Project, Restricted Project
olegshyshkov closed D137331: [mlir][linalg] Add BroadcastOp to Linalg structured ops..
Nov 4 2022, 4:07 AM · Restricted Project, Restricted Project
olegshyshkov added a comment to D137331: [mlir][linalg] Add BroadcastOp to Linalg structured ops..

Thank you!

Nov 4 2022, 3:07 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D137331: [mlir][linalg] Add BroadcastOp to Linalg structured ops..

Add a constant to represent unmapped dims.

Nov 4 2022, 3:06 AM · Restricted Project, Restricted Project

Nov 3 2022

olegshyshkov updated the summary of D137331: [mlir][linalg] Add BroadcastOp to Linalg structured ops..
Nov 3 2022, 4:38 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D137331: [mlir][linalg] Add BroadcastOp to Linalg structured ops..
Nov 3 2022, 4:37 AM · Restricted Project, Restricted Project

Oct 28 2022

olegshyshkov added a reverting change for rG7eef3ea5f4fe: Revert "[mlir][linalg] Add nicer builders for `map` and `reduce`.": rGad89eb5b1fcc: Revert "Revert "[mlir][linalg] Add nicer builders for `map` and `reduce`."".
Oct 28 2022, 2:35 AM · Restricted Project, Restricted Project
olegshyshkov committed rGad89eb5b1fcc: Revert "Revert "[mlir][linalg] Add nicer builders for `map` and `reduce`."" (authored by olegshyshkov).
Revert "Revert "[mlir][linalg] Add nicer builders for `map` and `reduce`.""
Oct 28 2022, 2:35 AM · Restricted Project, Restricted Project
olegshyshkov committed rGacdd576d0532: [mlir][linalg] Fix linalg.transpose region builder. (authored by olegshyshkov).
[mlir][linalg] Fix linalg.transpose region builder.
Oct 28 2022, 2:20 AM · Restricted Project, Restricted Project
olegshyshkov closed D136924: [mlir][linalg] Fix linalg.transpose region builder..
Oct 28 2022, 2:20 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D136924: [mlir][linalg] Fix linalg.transpose region builder..
Oct 28 2022, 1:29 AM · Restricted Project, Restricted Project
olegshyshkov added a reverting change for rGaebde2804769: [mlir][linalg] Add nicer builders for `map` and `reduce`.: rG7eef3ea5f4fe: Revert "[mlir][linalg] Add nicer builders for `map` and `reduce`.".
Oct 28 2022, 12:58 AM · Restricted Project, Restricted Project
olegshyshkov committed rG7eef3ea5f4fe: Revert "[mlir][linalg] Add nicer builders for `map` and `reduce`." (authored by olegshyshkov).
Revert "[mlir][linalg] Add nicer builders for `map` and `reduce`."
Oct 28 2022, 12:58 AM · Restricted Project, Restricted Project
olegshyshkov added a reverting change for D136838: [mlir][linalg] Add nicer builders for `map` and `reduce`.: rG7eef3ea5f4fe: Revert "[mlir][linalg] Add nicer builders for `map` and `reduce`.".
Oct 28 2022, 12:58 AM · Restricted Project, Restricted Project

Oct 27 2022

olegshyshkov committed rGaebde2804769: [mlir][linalg] Add nicer builders for `map` and `reduce`. (authored by olegshyshkov).
[mlir][linalg] Add nicer builders for `map` and `reduce`.
Oct 27 2022, 11:51 PM · Restricted Project, Restricted Project
olegshyshkov closed D136838: [mlir][linalg] Add nicer builders for `map` and `reduce`..
Oct 27 2022, 11:51 PM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D136838: [mlir][linalg] Add nicer builders for `map` and `reduce`..

clang-format.

Oct 27 2022, 11:48 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D136838: [mlir][linalg] Add nicer builders for `map` and `reduce`..

Create region empty region in TransposeOp::parse to fix test breakage.

Oct 27 2022, 7:59 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D136838: [mlir][linalg] Add nicer builders for `map` and `reduce`..
Oct 27 2022, 4:45 AM · Restricted Project, Restricted Project
olegshyshkov committed rG7ab21cdc2084: [mlir] Fix `AffineMap.dropResults`. (authored by olegshyshkov).
[mlir] Fix `AffineMap.dropResults`.
Oct 27 2022, 4:35 AM · Restricted Project, Restricted Project
olegshyshkov closed D136833: [mlir] Fix `AffineMap.dropResults`..
Oct 27 2022, 4:35 AM · Restricted Project, Restricted Project
olegshyshkov added a comment to D136833: [mlir] Fix `AffineMap.dropResults`..

Thank you!

Oct 27 2022, 4:34 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D136833: [mlir] Fix `AffineMap.dropResults`..

Replace rbegin()/rend() with std::greater<int>().

Oct 27 2022, 4:33 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D136833: [mlir] Fix `AffineMap.dropResults`..
Oct 27 2022, 3:38 AM · Restricted Project, Restricted Project

Oct 21 2022

olegshyshkov committed rG00ac39574b9f: [mlir][linalg] Add one-shot-bufferize tests for Linalg ops: reduce, map and… (authored by olegshyshkov).
[mlir][linalg] Add one-shot-bufferize tests for Linalg ops: reduce, map and…
Oct 21 2022, 6:40 AM · Restricted Project, Restricted Project
olegshyshkov closed D136431: [mlir][linalg] Add one-shot-bufferize tests for Linalg ops: reduce, map and transpose..
Oct 21 2022, 6:40 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D136431: [mlir][linalg] Add one-shot-bufferize tests for Linalg ops: reduce, map and transpose..

Update tests to check for memrefs.

Oct 21 2022, 6:20 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D136431: [mlir][linalg] Add one-shot-bufferize tests for Linalg ops: reduce, map and transpose..
Oct 21 2022, 1:50 AM · Restricted Project, Restricted Project

Oct 19 2022

olegshyshkov committed rGd261aa88f893: [mlir] Add TransposeOp to Linalg structured ops. (authored by olegshyshkov).
[mlir] Add TransposeOp to Linalg structured ops.
Oct 19 2022, 3:28 AM · Restricted Project, Restricted Project
olegshyshkov closed D135854: [mlir] Add TransposeOp to Linalg structured ops..
Oct 19 2022, 3:28 AM · Restricted Project, Restricted Project

Oct 18 2022

olegshyshkov added inline comments to D135854: [mlir] Add TransposeOp to Linalg structured ops..
Oct 18 2022, 5:30 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D135854: [mlir] Add TransposeOp to Linalg structured ops..

Incorporate changes from https://reviews.llvm.org/D135348.

Oct 18 2022, 5:19 AM · Restricted Project, Restricted Project

Oct 15 2022

olegshyshkov committed rG98eedd406aa0: [mlir][vector] Add a name prefix to tablegen for IteratorType in Vector dialect. (authored by olegshyshkov).
[mlir][vector] Add a name prefix to tablegen for IteratorType in Vector dialect.
Oct 15 2022, 12:03 AM · Restricted Project, Restricted Project
olegshyshkov closed D135980: [mlir][vector] Add a name prefix to tablegen for IteratorType in Vector dialect..
Oct 15 2022, 12:03 AM · Restricted Project, Restricted Project

Oct 14 2022

olegshyshkov requested review of D135980: [mlir][vector] Add a name prefix to tablegen for IteratorType in Vector dialect..
Oct 14 2022, 11:58 AM · Restricted Project, Restricted Project
olegshyshkov added inline comments to D135854: [mlir] Add TransposeOp to Linalg structured ops..
Oct 14 2022, 5:36 AM · Restricted Project, Restricted Project
olegshyshkov added inline comments to D135854: [mlir] Add TransposeOp to Linalg structured ops..
Oct 14 2022, 5:32 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D135854: [mlir] Add TransposeOp to Linalg structured ops..

Address some comments.

Oct 14 2022, 5:29 AM · Restricted Project, Restricted Project

Oct 13 2022

olegshyshkov updated the diff for D135854: [mlir] Add TransposeOp to Linalg structured ops..

clang-format

Oct 13 2022, 2:33 AM · Restricted Project, Restricted Project
olegshyshkov committed rGc38d9cf20e74: [mlir] Remove iterator_types() method from LinalgStructuredInterface. (authored by olegshyshkov).
[mlir] Remove iterator_types() method from LinalgStructuredInterface.
Oct 13 2022, 12:53 AM · Restricted Project, Restricted Project
olegshyshkov closed D135765: [mlir] Remove iterator_types() method from LinalgStructuredInterface..
Oct 13 2022, 12:53 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D135854: [mlir] Add TransposeOp to Linalg structured ops..
Oct 13 2022, 12:47 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D135765: [mlir] Remove iterator_types() method from LinalgStructuredInterface..

Sync and resolve merge conflicts with Linalg::MapOp that was just added in https://reviews.llvm.org/D135754.

Oct 13 2022, 12:32 AM · Restricted Project, Restricted Project

Oct 12 2022

olegshyshkov updated the diff for D135765: [mlir] Remove iterator_types() method from LinalgStructuredInterface..

Typos.

Oct 12 2022, 5:05 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D135765: [mlir] Remove iterator_types() method from LinalgStructuredInterface..
Oct 12 2022, 5:00 AM · Restricted Project, Restricted Project

Sep 30 2022

olegshyshkov committed rGc54bc8bd07dc: [mlir][linalg] Use getIteratorTypeArray instead of raw iterator_type attribute. (authored by olegshyshkov).
[mlir][linalg] Use getIteratorTypeArray instead of raw iterator_type attribute.
Sep 30 2022, 9:04 AM · Restricted Project, Restricted Project
olegshyshkov closed D134888: [mlir][linalg] Use getIteratorTypeArray instead of raw iterator_type attribute..
Sep 30 2022, 9:04 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D134888: [mlir][linalg] Use getIteratorTypeArray instead of raw iterator_type attribute..

Update comments.

Sep 30 2022, 9:00 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D134888: [mlir][linalg] Use getIteratorTypeArray instead of raw iterator_type attribute..

Sync.

Sep 30 2022, 8:49 AM · Restricted Project, Restricted Project
olegshyshkov committed rG1227b8ab54f9: [mlir] Rename getTied* methods to getMatching* in LinalgInterface. (authored by olegshyshkov).
[mlir] Rename getTied* methods to getMatching* in LinalgInterface.
Sep 30 2022, 3:06 AM · Restricted Project, Restricted Project
olegshyshkov closed D134534: [mlir] Rename getTied* methods to getMatching* in LinalgInterface..
Sep 30 2022, 3:06 AM · Restricted Project, Restricted Project
olegshyshkov added a comment to D134534: [mlir] Rename getTied* methods to getMatching* in LinalgInterface..

Thank you for reviewing!

Sep 30 2022, 3:05 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D134534: [mlir] Rename getTied* methods to getMatching* in LinalgInterface..

Sync and fix merge conflicts.

Sep 30 2022, 3:03 AM · Restricted Project, Restricted Project

Sep 29 2022

olegshyshkov added a reviewer for D134888: [mlir][linalg] Use getIteratorTypeArray instead of raw iterator_type attribute.: pifon2a.
Sep 29 2022, 9:01 AM · Restricted Project, Restricted Project
olegshyshkov updated the summary of D134888: [mlir][linalg] Use getIteratorTypeArray instead of raw iterator_type attribute..
Sep 29 2022, 9:00 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D134888: [mlir][linalg] Use getIteratorTypeArray instead of raw iterator_type attribute..
Sep 29 2022, 8:57 AM · Restricted Project, Restricted Project

Sep 27 2022

olegshyshkov committed rG1e7a6c0874f5: [mlir][linalg] Add getIteratorTypesArray to LinalgInterface. (authored by olegshyshkov).
[mlir][linalg] Add getIteratorTypesArray to LinalgInterface.
Sep 27 2022, 7:32 AM · Restricted Project, Restricted Project
olegshyshkov closed D134729: [mlir][linalg] Add getIteratorTypesArray to LinalgInterface..
Sep 27 2022, 7:32 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D134729: [mlir][linalg] Add getIteratorTypesArray to LinalgInterface..

clang-format

Sep 27 2022, 7:27 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D134534: [mlir] Rename getTied* methods to getMatching* in LinalgInterface..

clang-format

Sep 27 2022, 7:22 AM · Restricted Project, Restricted Project
olegshyshkov added inline comments to D134534: [mlir] Rename getTied* methods to getMatching* in LinalgInterface..
Sep 27 2022, 5:46 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D134534: [mlir] Rename getTied* methods to getMatching* in LinalgInterface..

Resolved comments.

Sep 27 2022, 5:44 AM · Restricted Project, Restricted Project
olegshyshkov requested review of D134729: [mlir][linalg] Add getIteratorTypesArray to LinalgInterface..
Sep 27 2022, 4:45 AM · Restricted Project, Restricted Project

Sep 26 2022

olegshyshkov committed rG4f1c12425179: [mlir] Add IteratorType enum to StructuredOpsUtils. (authored by olegshyshkov).
[mlir] Add IteratorType enum to StructuredOpsUtils.
Sep 26 2022, 4:10 AM · Restricted Project, Restricted Project
olegshyshkov closed D134634: [mlir] Add IteratorType enum to StructuredOpsUtils..
Sep 26 2022, 4:10 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D134634: [mlir] Add IteratorType enum to StructuredOpsUtils..

Remove LinalgBase.h. It wasn't used in this patch.

Sep 26 2022, 3:34 AM · Restricted Project, Restricted Project
olegshyshkov updated the diff for D134634: [mlir] Add IteratorType enum to StructuredOpsUtils..

Added file header comments.

Sep 26 2022, 3:14 AM · Restricted Project, Restricted Project