This is an archive of the discontinued LLVM Phabricator instance.

[llvm-profdata] Change default output format of llvm-profdata to ExtBinary
ClosedPublic

Authored by huangjd on May 2 2023, 3:58 PM.

Details

Summary

ExtBinary is compatible to, and more superior than Binary format, which is the current default output format. In the long run we are looking to only support ExtBinary format and Text format (for visual inspection), and drop Binary format as well. Since Binary format was the default, we expect many users are still using it, so let's change the default output format first, and hopefully the usage decreases over time

Diff Detail

Event Timeline

huangjd created this revision.May 2 2023, 3:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2023, 3:58 PM
Herald added a subscriber: wlei. · View Herald Transcript
huangjd requested review of this revision.May 2 2023, 3:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2023, 3:58 PM
huangjd added subscribers: Restricted Project, Restricted Project.May 2 2023, 3:58 PM
efriedma added inline comments.
llvm/tools/llvm-profdata/llvm-profdata.cpp
1188

Fix "(default)"?

huangjd updated this revision to Diff 518898.May 2 2023, 4:06 PM

Edited text

huangjd marked an inline comment as done.May 2 2023, 4:07 PM
davidxl accepted this revision.May 3 2023, 10:59 AM

lgtm

This revision is now accepted and ready to land.May 3 2023, 10:59 AM
hoy accepted this revision.May 3 2023, 11:05 AM
This revision was landed with ongoing or failed builds.May 4 2023, 12:35 PM
This revision was automatically updated to reflect the committed changes.