Page MenuHomePhabricator

snehasish (Snehasish Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2017, 12:15 PM (263 w, 4 d)

Recent Activity

Mon, Jun 27

snehasish committed rG3a1a404ae2d3: [memprof] Return an error for unsupported symbolization. (authored by snehasish).
[memprof] Return an error for unsupported symbolization.
Mon, Jun 27, 9:43 AM · Restricted Project, Restricted Project
snehasish closed D128564: [memprof] Return an error for unsupported symbolization..
Mon, Jun 27, 9:43 AM · Restricted Project, Restricted Project

Fri, Jun 24

snehasish added a comment to D128564: [memprof] Return an error for unsupported symbolization..

Thanks for the quick review.

Fri, Jun 24, 4:53 PM · Restricted Project, Restricted Project
snehasish updated the diff for D128564: [memprof] Return an error for unsupported symbolization..

Add test description.

Fri, Jun 24, 4:52 PM · Restricted Project, Restricted Project
snehasish requested review of D128564: [memprof] Return an error for unsupported symbolization..
Fri, Jun 24, 4:38 PM · Restricted Project, Restricted Project

Wed, Jun 22

snehasish added a comment to D128142: [MemProf] Memprof profile matching and annotation.

I'm still going through PGOInstrumentation.cpp ...

Wed, Jun 22, 2:42 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

snehasish accepted D128141: [MemProf] Basic metadata support and verification.

lgtm with a couple of minor comments.

Tue, Jun 21, 10:01 AM · Restricted Project, Restricted Project

Wed, Jun 15

snehasish committed rGb0c51f00ae68: [memprof] Update the test comments to include -Wl,-no-pie (authored by snehasish).
[memprof] Update the test comments to include -Wl,-no-pie
Wed, Jun 15, 9:49 AM · Restricted Project, Restricted Project
snehasish closed D127808: [memprof] Update the test comments to include -Wl,-no-pie.
Wed, Jun 15, 9:49 AM · Restricted Project, Restricted Project

Tue, Jun 14

snehasish added a comment to D127808: [memprof] Update the test comments to include -Wl,-no-pie.

PTAL, thanks!

Tue, Jun 14, 5:04 PM · Restricted Project, Restricted Project
snehasish updated the diff for D127808: [memprof] Update the test comments to include -Wl,-no-pie.

Update binary names to be consistent.

Tue, Jun 14, 5:01 PM · Restricted Project, Restricted Project
snehasish requested review of D127808: [memprof] Update the test comments to include -Wl,-no-pie.
Tue, Jun 14, 4:32 PM · Restricted Project, Restricted Project

Wed, Jun 1

snehasish committed rG8a87f42fc6ca: [memprof] Print out the segment information in YAML format. (authored by snehasish).
[memprof] Print out the segment information in YAML format.
Wed, Jun 1, 7:26 PM · Restricted Project, Restricted Project
snehasish closed D126840: [memprof] Print out the segment information in YAML format..
Wed, Jun 1, 7:26 PM · Restricted Project, Restricted Project
snehasish committed rG962db7de84d4: [memprof] Update summary output. (authored by snehasish).
[memprof] Update summary output.
Wed, Jun 1, 7:16 PM · Restricted Project, Restricted Project
snehasish closed D126834: [memprof] Update summary output..
Wed, Jun 1, 7:15 PM · Restricted Project, Restricted Project
snehasish added a comment to D126834: [memprof] Update summary output..

I think the 2 changes are unrelated so maybe they should be committed separately?

Split out the segment information print in D126840.

Wed, Jun 1, 5:18 PM · Restricted Project, Restricted Project
snehasish requested review of D126840: [memprof] Print out the segment information in YAML format..
Wed, Jun 1, 5:17 PM · Restricted Project, Restricted Project
snehasish retitled D126834: [memprof] Update summary output. from [memprof] Display segment information, update summary output. to [memprof] Update summary output..
Wed, Jun 1, 5:08 PM · Restricted Project, Restricted Project
snehasish added a comment to D126834: [memprof] Update summary output..

PTAL, thanks!

Wed, Jun 1, 5:02 PM · Restricted Project, Restricted Project
snehasish updated the diff for D126834: [memprof] Update summary output..

Remove summary changes from this patch.
Add another field which tracks the number of mibs we have.

Wed, Jun 1, 4:59 PM · Restricted Project, Restricted Project
snehasish requested review of D126834: [memprof] Update summary output..
Wed, Jun 1, 3:29 PM · Restricted Project, Restricted Project

May 25 2022

snehasish committed rGec51971eae02: [memprof] Keep and display symbol names in the RawMemProfReader. (authored by snehasish).
[memprof] Keep and display symbol names in the RawMemProfReader.
May 25 2022, 2:18 PM · Restricted Project, Restricted Project
snehasish closed D126344: [memprof] Keep and display symbol names in the RawMemProfReader..
May 25 2022, 2:17 PM · Restricted Project, Restricted Project
snehasish added a comment to D126344: [memprof] Keep and display symbol names in the RawMemProfReader..

Thanks for the review.

May 25 2022, 1:54 PM · Restricted Project, Restricted Project
snehasish added a comment to D126344: [memprof] Keep and display symbol names in the RawMemProfReader..

PTAL, thanks!

May 25 2022, 12:09 PM · Restricted Project, Restricted Project
snehasish updated the diff for D126344: [memprof] Keep and display symbol names in the RawMemProfReader..

Update comments.

May 25 2022, 11:26 AM · Restricted Project, Restricted Project

May 24 2022

snehasish updated the diff for D126344: [memprof] Keep and display symbol names in the RawMemProfReader..

Remove unnecessary blank lines.

May 24 2022, 5:11 PM · Restricted Project, Restricted Project
snehasish requested review of D126344: [memprof] Keep and display symbol names in the RawMemProfReader..
May 24 2022, 5:04 PM · Restricted Project, Restricted Project

May 4 2022

snehasish accepted D124953: [memprof] Use unknown_function error type for missing functions.

lgtm

May 4 2022, 12:00 PM · Restricted Project, Restricted Project

May 2 2022

snehasish accepted D124797: [memprof] Only insert dynamic shadow load when needed.

lgtm

May 2 2022, 12:47 PM · Restricted Project, Restricted Project
snehasish accepted D124703: [memprof] Don't instrument PGO and other compiler inserted variables.

lgtm

May 2 2022, 11:22 AM · Restricted Project, Restricted Project

Apr 29 2022

snehasish added inline comments to D124703: [memprof] Don't instrument PGO and other compiler inserted variables.
Apr 29 2022, 5:35 PM · Restricted Project, Restricted Project

Apr 8 2022

snehasish committed rG6dd6a6161f3a: [memprof] Deduplicate and outline frame storage in the memprof profile. (authored by snehasish).
[memprof] Deduplicate and outline frame storage in the memprof profile.
Apr 8 2022, 9:15 AM · Restricted Project, Restricted Project
snehasish closed D123094: [memprof] Deduplicate and outline frame storage in the memprof profile..
Apr 8 2022, 9:15 AM · Restricted Project, Restricted Project

Apr 7 2022

snehasish added a comment to D123094: [memprof] Deduplicate and outline frame storage in the memprof profile..

Thanks for the detailed review as always. :)

Apr 7 2022, 1:23 PM · Restricted Project, Restricted Project
snehasish updated the diff for D123094: [memprof] Deduplicate and outline frame storage in the memprof profile..

Address comments.

Apr 7 2022, 1:22 PM · Restricted Project, Restricted Project
snehasish added a comment to D123094: [memprof] Deduplicate and outline frame storage in the memprof profile..

Thanks for the review, ptal!

Apr 7 2022, 11:42 AM · Restricted Project, Restricted Project
snehasish updated the diff for D123094: [memprof] Deduplicate and outline frame storage in the memprof profile..

Address comments.

Apr 7 2022, 11:33 AM · Restricted Project, Restricted Project

Apr 4 2022

snehasish requested review of D123094: [memprof] Deduplicate and outline frame storage in the memprof profile..
Apr 4 2022, 4:07 PM · Restricted Project, Restricted Project

Mar 22 2022

snehasish added a reverting change for rGf4b794427e80: Revert "[memprof] Store callsite metadata with memprof records.": rG27a4f2545f33: Reland "[memprof] Store callsite metadata with memprof records.".
Mar 22 2022, 2:45 PM · Restricted Project
snehasish committed rG27a4f2545f33: Reland "[memprof] Store callsite metadata with memprof records." (authored by snehasish).
Reland "[memprof] Store callsite metadata with memprof records."
Mar 22 2022, 2:45 PM · Restricted Project
snehasish committed rG61c75eb63727: [memprof] Initialize MemInfoBlock data. (authored by snehasish).
[memprof] Initialize MemInfoBlock data.
Mar 22 2022, 2:36 PM · Restricted Project
snehasish closed D122260: [memprof] Initialize MemInfoBlock data..
Mar 22 2022, 2:36 PM · Restricted Project, Restricted Project, Restricted Project
snehasish added a comment to D122260: [memprof] Initialize MemInfoBlock data..

PTAl, thanks!

Mar 22 2022, 2:31 PM · Restricted Project, Restricted Project, Restricted Project
snehasish updated the diff for D122260: [memprof] Initialize MemInfoBlock data..

Address comments.

Mar 22 2022, 2:29 PM · Restricted Project, Restricted Project, Restricted Project
snehasish requested review of D122260: [memprof] Initialize MemInfoBlock data..
Mar 22 2022, 1:59 PM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

snehasish committed rG0d362c90d335: [memprof] Store callsite metadata with memprof records. (authored by snehasish).
[memprof] Store callsite metadata with memprof records.
Mar 21 2022, 1:59 PM · Restricted Project
snehasish closed D121179: [memprof] Store callsite metadata with memprof records..
Mar 21 2022, 1:58 PM · Restricted Project, Restricted Project
snehasish added a comment to D121179: [memprof] Store callsite metadata with memprof records..

With this patch on an internal binary, the time taken to merge indexed and raw profile increases to 85s (up from 48s in D120430). The zip profile size increases to ~520M (up from 247M in D118653). I'll look into de-duplicating the inline storage of callstacks and their frames in followup patches. Thanks for the review!

Mar 21 2022, 11:29 AM · Restricted Project, Restricted Project
snehasish committed rG5cfb1100902e: [DebugInfo][NFC] Add a comment on the ordering of DILineInfo frames. (authored by snehasish).
[DebugInfo][NFC] Add a comment on the ordering of DILineInfo frames.
Mar 21 2022, 10:42 AM · Restricted Project
snehasish committed rGc9a3d29613db: [memprof] Update the frame is inline logic and unittests. (authored by snehasish).
[memprof] Update the frame is inline logic and unittests.
Mar 21 2022, 10:42 AM · Restricted Project
snehasish closed D122033: [DebugInfo][NFC] Add a comment on the ordering of DILineInfo frames..
Mar 21 2022, 10:42 AM · Restricted Project, Restricted Project
snehasish closed D121830: [memprof] Update the frame is inline logic and unittests..
Mar 21 2022, 10:42 AM · Restricted Project, Restricted Project
snehasish updated the diff for D122033: [DebugInfo][NFC] Add a comment on the ordering of DILineInfo frames..

Update comment.

Mar 21 2022, 10:34 AM · Restricted Project, Restricted Project

Mar 18 2022

snehasish added a comment to D121830: [memprof] Update the frame is inline logic and unittests..

lgtm

Unfortunately the ordering is not documented on the DIInliningInfo class. And confusingly, one piece of code sets an Inlined flag by the check "I > 0" (https://github.com/llvm/llvm-project/blob/49c048add4c980936fc2918838288ae2d795587d/llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp#L198).
However, if I look at how that flag is used, it is used to print "(inlined by)" *before* the current frame's function name, so it seems to apply to the I-1 frame, which actually means that all but the last frame are inlined - consistent with the change you have made here. Consider making a separate NFC change to add a comment to DIInliningInfo?

Mar 18 2022, 1:38 PM · Restricted Project, Restricted Project
snehasish requested review of D122033: [DebugInfo][NFC] Add a comment on the ordering of DILineInfo frames..
Mar 18 2022, 1:36 PM · Restricted Project, Restricted Project
snehasish added a comment to D121179: [memprof] Store callsite metadata with memprof records..

Updated the patch to track callsites for all functions in the frame. PTAL, thanks!

Mar 18 2022, 1:29 PM · Restricted Project, Restricted Project
snehasish updated the diff for D121179: [memprof] Store callsite metadata with memprof records..

Fix lit test and some cleanup.

Mar 18 2022, 1:28 PM · Restricted Project, Restricted Project
snehasish updated the diff for D121179: [memprof] Store callsite metadata with memprof records..

Address comments.

Mar 18 2022, 1:16 PM · Restricted Project, Restricted Project

Mar 16 2022

snehasish added a comment to D121179: [memprof] Store callsite metadata with memprof records..

@tejohnson I've updated the logic to track and annotate additional functions with the allocation site profiles. Please take a look at the example in MemProfTest.cpp L176 to see if it matches your expectations. Thanks!

Mar 16 2022, 4:30 PM · Restricted Project, Restricted Project
snehasish updated the diff for D121179: [memprof] Store callsite metadata with memprof records..

Update allocsite and callsite profile contents.

Mar 16 2022, 4:26 PM · Restricted Project, Restricted Project
snehasish requested review of D121830: [memprof] Update the frame is inline logic and unittests..
Mar 16 2022, 10:34 AM · Restricted Project, Restricted Project
snehasish committed rG49c048add4c9: [memprof] Add a test to verify callstack order. (authored by snehasish).
[memprof] Add a test to verify callstack order.
Mar 16 2022, 10:11 AM · Restricted Project
snehasish closed D121759: [memprof] Add a test to verify callstack order..
Mar 16 2022, 10:11 AM · Restricted Project, Restricted Project

Mar 15 2022

snehasish added a comment to D121759: [memprof] Add a test to verify callstack order..

Updated the test documentation. PTAL, thanks!

Mar 15 2022, 5:12 PM · Restricted Project, Restricted Project
snehasish updated the diff for D121759: [memprof] Add a test to verify callstack order..

Address comments.

Mar 15 2022, 5:11 PM · Restricted Project, Restricted Project
snehasish updated the diff for D121759: [memprof] Add a test to verify callstack order..

Rebase, lint and fix test invocation.

Mar 15 2022, 5:00 PM · Restricted Project, Restricted Project
snehasish requested review of D121759: [memprof] Add a test to verify callstack order..
Mar 15 2022, 4:55 PM · Restricted Project, Restricted Project

Mar 9 2022

snehasish planned changes to D121179: [memprof] Store callsite metadata with memprof records..

Discussed with @tejohnson offline how we can make the matching more robust.

Mar 9 2022, 4:15 PM · Restricted Project, Restricted Project
snehasish added a comment to D121179: [memprof] Store callsite metadata with memprof records..

Thanks for the detailed review! PTAL.

Mar 9 2022, 9:38 AM · Restricted Project, Restricted Project
snehasish updated the diff for D121179: [memprof] Store callsite metadata with memprof records..

Address comments.

Mar 9 2022, 9:12 AM · Restricted Project, Restricted Project

Mar 7 2022

snehasish updated the diff for D121179: [memprof] Store callsite metadata with memprof records..

Add a comment and remove some commented code.

Mar 7 2022, 6:52 PM · Restricted Project, Restricted Project
snehasish requested review of D121179: [memprof] Store callsite metadata with memprof records..
Mar 7 2022, 6:45 PM · Restricted Project, Restricted Project

Mar 4 2022

snehasish committed rG11314f405903: [memprof] Filter out callstack frames which cannot be symbolized. (authored by snehasish).
[memprof] Filter out callstack frames which cannot be symbolized.
Mar 4 2022, 11:11 AM · Restricted Project
snehasish closed D120860: [memprof] Filter out callstack frames which cannot be symbolized..
Mar 4 2022, 11:11 AM · Restricted Project, Restricted Project

Mar 3 2022

snehasish added inline comments to D120860: [memprof] Filter out callstack frames which cannot be symbolized..
Mar 3 2022, 5:02 PM · Restricted Project, Restricted Project
snehasish added a comment to D120860: [memprof] Filter out callstack frames which cannot be symbolized..

PTAL, thanks!

Mar 3 2022, 4:40 PM · Restricted Project, Restricted Project
snehasish updated the diff for D120860: [memprof] Filter out callstack frames which cannot be symbolized..

Add TODO to update summary print.

Mar 3 2022, 4:37 PM · Restricted Project, Restricted Project
snehasish updated the diff for D120860: [memprof] Filter out callstack frames which cannot be symbolized..

Address comments.

Mar 3 2022, 4:21 PM · Restricted Project, Restricted Project
snehasish committed rGdda7b74967cc: [memprof] Symbolize and cache stack frames. (authored by snehasish).
[memprof] Symbolize and cache stack frames.
Mar 3 2022, 11:01 AM · Restricted Project
snehasish closed D120430: [memprof] Symbolize and cache stack frames..
Mar 3 2022, 11:01 AM · Restricted Project, Restricted Project
snehasish updated the diff for D120860: [memprof] Filter out callstack frames which cannot be symbolized..

Simplify discarded vaddrs check, rename method to indicate filtering and add comments.

Mar 3 2022, 9:54 AM · Restricted Project, Restricted Project

Mar 2 2022

snehasish added a comment to D120430: [memprof] Symbolize and cache stack frames..

Updated the patch with comments. PTAL, thanks!

Mar 2 2022, 6:27 PM · Restricted Project, Restricted Project
snehasish updated the diff for D120430: [memprof] Symbolize and cache stack frames..

Address comment.

Mar 2 2022, 5:57 PM · Restricted Project, Restricted Project
snehasish requested review of D120860: [memprof] Filter out callstack frames which cannot be symbolized..
Mar 2 2022, 5:51 PM · Restricted Project, Restricted Project

Feb 23 2022

snehasish committed rGb6817999384e: [instrprof] Rename the profile kind types to be more descriptive. (authored by snehasish).
[instrprof] Rename the profile kind types to be more descriptive.
Feb 23 2022, 1:16 PM
snehasish closed D120092: [instrprof] Rename the profile kind types to be more descriptive..
Feb 23 2022, 1:16 PM · Restricted Project
snehasish added a comment to D120092: [instrprof] Rename the profile kind types to be more descriptive..

Thanks for the reviews.

Feb 23 2022, 1:13 PM · Restricted Project
snehasish updated the diff for D120092: [instrprof] Rename the profile kind types to be more descriptive..

Move the InstrProfKind::MemProf comment above the decl to be consistent.

Feb 23 2022, 1:12 PM · Restricted Project
snehasish requested review of D120430: [memprof] Symbolize and cache stack frames..
Feb 23 2022, 12:44 PM · Restricted Project, Restricted Project
snehasish added a comment to D120092: [instrprof] Rename the profile kind types to be more descriptive..

ping @ellis @davidxl :)

Feb 23 2022, 9:27 AM · Restricted Project

Feb 18 2022

snehasish committed rG3c8fc215cc28: [memprof] Remove packed qualifier for MemprofRecord::Frame. (authored by snehasish).
[memprof] Remove packed qualifier for MemprofRecord::Frame.
Feb 18 2022, 2:08 PM
snehasish closed D120147: [memprof] Remove packed qualifier for MemprofRecord::Frame..
Feb 18 2022, 2:08 PM · Restricted Project
snehasish added a comment to D120147: [memprof] Remove packed qualifier for MemprofRecord::Frame..

What about the other uses of PACKED e.g. in MemProfData.inc? Should/can they be removed?

Feb 18 2022, 1:50 PM · Restricted Project
snehasish requested review of D120147: [memprof] Remove packed qualifier for MemprofRecord::Frame..
Feb 18 2022, 10:37 AM · Restricted Project

Feb 17 2022

snehasish added a comment to D120103: Reland "[memprof] Extend the index prof format to include memory profiles.".

This was reviewed separately in https://reviews.llvm.org/D120093 and https://reviews.llvm.org/D120103. Not sure why this draft revision was tagged. Sorry for the noise!

Feb 17 2022, 10:13 PM · Restricted Project, Restricted Project
snehasish committed rG0a4184909a8c: Reland "[memprof] Extend the index prof format to include memory profiles." (authored by snehasish).
Reland "[memprof] Extend the index prof format to include memory profiles."
Feb 17 2022, 10:12 PM
snehasish closed D120103: Reland "[memprof] Extend the index prof format to include memory profiles.".
Feb 17 2022, 10:11 PM · Restricted Project, Restricted Project
snehasish added a reverting change for rG19bdf44d8508: Revert "Reland "[memprof] Extend the index prof format to include memory…: D120103: Reland "[memprof] Extend the index prof format to include memory profiles.".
Feb 17 2022, 5:11 PM