lgtm

LGTM, please wait a bit in case others have any concerns.

lgtm

Fix lgtm.

lgtm

lgtm

lgtm

lgtm, remaining comments are (mostly) cosmetic.

lgtm

Should we update this too https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/llvm-tli-checker/ps4-tli-check.yaml#L41

lgtm

Looks good overall, still thinking if we can make assignFunctions less monolithic and easier to follow.

lgtm

lgtm

Still need to look into assignFunctions but before I do I'm wondering if this patch can be split into two with applyImport and assignFunctions in separate patches. What do you think?

lgtm

Rebase, address comment.

Thanks for the quick review!

Address comments.

Remove unused include.

Can you leave an example of the warnings in the review discussion here for posterity? Thanks!

lgtm since I think this change is safe for existing profiles. @huangjd please confirm before submitting, thanks!

lgtm

lgtm

Looks good overall, added a few comments which are mostly cosmetic.

lgtm, I assume you will reduce these test cases too?

Rebase, remove var only used in assert.

Thanks for the review!

Address comments.

PTAL, thanks!

Address comments.

lgtm, overall. The remaining comments are minor and thanks for the explanations in the tests.

Can you split out the uint64_t type changes into a separate patch?

Still working my way through updateStackNodes. Here are some of the comments I have so far --

lgtm, thanks for documenting the metadata format.

Update the unittest in compiler-rt which was caught by the build bot failures.

Reopening since I missed the updates to the memprof unit tests in compiler-rt. This was caught by the buildbots. As part of the changes I modified the SerializeToRawProfile API slightly to make it easier to test. Also regenerated the raw profiles and binaries again since the runtime changed.

Update test regex.

In D145190#4181789, @snehasish wrote:

In D145190#4181608, @tejohnson wrote:

lgtm - but does this depend on D145644 and require some additional test changes?

Yes, I will rebase this patch once that is submitted. I need to look at the LLVM.Transforms/PGOProfile::memprof.ll test failures.

Update raw profiles, add another test for buildids only.

I'll go ahead and push this. @dblaikie Let me know if you have any comments and I'll follow up separately. Thanks!

In D145644#4182239, @tejohnson wrote:

Generally lgtm, but why did the raw profiles change size from what is currently committed?

Update the script in test/tool/llvm-profdata/Inputs.

Update the script for Transforms/PGOProfile/memprof.ll.

In D145190#4181608, @tejohnson wrote:

lgtm - but does this depend on D145644 and require some additional test changes?

Perhaps a script to easily update things for new versions would be adequate?

Took a stab at it in D145644, PTAL thanks!

In D145428#4175870, @snehasish wrote:

I don't recall why we set this to false at this specific point, it seems like it should be ok to delay it. And then I wonder if we can combine memprof_init_is_running with memprof_init_done?

Delaying it seems to be fine on the small tests, let me look into what the other flags do and try to simplify if we can.

clang-format, rebase.

Failing build on Windows seems to be unrelated:

Yeah, that seems like the best option.

Sent D145521 to match filenames which define interceptors.

In D145212#4174199, @kristof.beyls wrote:

It seems to me that this patch would also need:

• Some regression test to test it actually changes code generation (only?) when targeting Arm.
• As is, this patch will not result in changed code generation IIUC?

I don't recall why we set this to false at this specific point, it seems like it should be ok to delay it. And then I wonder if we can combine memprof_init_is_running with memprof_init_done?

Also looking into why we have these extra interceptions, it looks like we set memprof_init_is_running to false and a subsequent call to Symbolizer::LateInitialize is intercepted [1].

I assumed it was due to optimizations however after looking more closely, the behaviour is due to a difference in debug information for the compiler-rt runtime. For the basic test case with the code below --

Rebase.