User Details
- User Since
- Jun 10 2017, 12:15 PM (311 w, 4 d)
Fri, May 26
lgtm
Mon, May 8
LGTM, please wait a bit in case others have any concerns.
Thu, May 4
lgtm
Wed, May 3
Fix lgtm.
Tue, May 2
lgtm
lgtm
lgtm
lgtm, remaining comments are (mostly) cosmetic.
May 1 2023
lgtm
Apr 28 2023
Should we update this too https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/llvm-tli-checker/ps4-tli-check.yaml#L41
Apr 27 2023
Apr 26 2023
lgtm
Looks good overall, still thinking if we can make assignFunctions less monolithic and easier to follow.
Apr 25 2023
lgtm
Apr 20 2023
lgtm
Apr 19 2023
Still need to look into assignFunctions but before I do I'm wondering if this patch can be split into two with applyImport and assignFunctions in separate patches. What do you think?
lgtm
Apr 17 2023
Rebase, address comment.
Apr 14 2023
Thanks for the quick review!
Address comments.
Apr 13 2023
Remove unused include.
Can you leave an example of the warnings in the review discussion here for posterity? Thanks!
lgtm since I think this change is safe for existing profiles. @huangjd please confirm before submitting, thanks!
Apr 12 2023
lgtm
Apr 10 2023
Apr 6 2023
lgtm
Looks good overall, added a few comments which are mostly cosmetic.
Mar 21 2023
lgtm, I assume you will reduce these test cases too?
Rebase, remove var only used in assert.
Thanks for the review!
Address comments.
PTAL, thanks!
Address comments.
Mar 20 2023
lgtm, overall. The remaining comments are minor and thanks for the explanations in the tests.
Mar 16 2023
Can you split out the uint64_t type changes into a separate patch?
Mar 15 2023
Still working my way through updateStackNodes. Here are some of the comments I have so far --
Mar 14 2023
lgtm, thanks for documenting the metadata format.
Mar 13 2023
Update the unittest in compiler-rt which was caught by the build bot failures.
Reopening since I missed the updates to the memprof unit tests in compiler-rt. This was caught by the buildbots. As part of the changes I modified the SerializeToRawProfile API slightly to make it easier to test. Also regenerated the raw profiles and binaries again since the runtime changed.
Mar 9 2023
Update test regex.
Update raw profiles, add another test for buildids only.
I'll go ahead and push this. @dblaikie Let me know if you have any comments and I'll follow up separately. Thanks!
Update the script in test/tool/llvm-profdata/Inputs.
Update the script for Transforms/PGOProfile/memprof.ll.
Mar 8 2023
Perhaps a script to easily update things for new versions would be adequate?
Took a stab at it in D145644, PTAL thanks!
Mar 7 2023
clang-format, rebase.
Failing build on Windows seems to be unrelated:
Yeah, that seems like the best option.
Sent D145521 to match filenames which define interceptors.
I don't recall why we set this to false at this specific point, it seems like it should be ok to delay it. And then I wonder if we can combine memprof_init_is_running with memprof_init_done?
Mar 6 2023
Also looking into why we have these extra interceptions, it looks like we set memprof_init_is_running to false and a subsequent call to Symbolizer::LateInitialize is intercepted [1].
I assumed it was due to optimizations however after looking more closely, the behaviour is due to a difference in debug information for the compiler-rt runtime. For the basic test case with the code below --
Rebase.