Page MenuHomePhabricator

snehasish (Snehasish Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2017, 12:15 PM (311 w, 4 d)

Recent Activity

Fri, May 26

snehasish accepted D151593: [MemProf] Clean up MemProf instrumentation pass invocation.

lgtm

Fri, May 26, 4:28 PM · Restricted Project, Restricted Project, Restricted Project

Mon, May 8

snehasish added inline comments to D150148: [IPO] Opt-in local clones for thinlto imports.
Mon, May 8, 5:08 PM · Restricted Project, Restricted Project
snehasish added inline comments to D150148: [IPO] Opt-in local clones for thinlto imports.
Mon, May 8, 4:42 PM · Restricted Project, Restricted Project
snehasish accepted D148872: [llvm-profdata] ProfileReader cleanup - preparation for MD5 refactoring - 2.

LGTM, please wait a bit in case others have any concerns.

Mon, May 8, 9:50 AM · Restricted Project, Restricted Project

Thu, May 4

snehasish accepted D149924: [MemProf] Use MapVector to avoid non-determinism.

lgtm

Thu, May 4, 10:29 PM · Restricted Project, Restricted Project

Wed, May 3

snehasish accepted D141077: [MemProf] Context disambiguation cloning pass [patch 3/4].

Fix lgtm.

Wed, May 3, 6:26 PM · Restricted Project, Restricted Project

Tue, May 2

snehasish added inline comments to D147812: [InstrProf] Use BalancedPartitioning to order temporal profiling trace data.
Tue, May 2, 2:53 PM · Restricted Project, Restricted Project
snehasish accepted D149684: [MemProf] Use profiled lifetime access density directly.

lgtm

Tue, May 2, 1:38 PM · Restricted Project, Restricted Project
snehasish accepted D149215: [MemProf] Control availability of hot/cold operator new from LTO link.

lgtm

Tue, May 2, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
snehasish accepted D149669: [MemProf] Removed unused allocation type.

lgtm

Tue, May 2, 11:50 AM · Restricted Project, Restricted Project
snehasish accepted D141077: [MemProf] Context disambiguation cloning pass [patch 3/4].

lgtm, remaining comments are (mostly) cosmetic.

Tue, May 2, 11:48 AM · Restricted Project, Restricted Project

May 1 2023

snehasish accepted D149600: [MemProf] Recognize hot/cold operator new as replaceable allocations.

lgtm

May 1 2023, 11:29 AM · Restricted Project, Restricted Project

Apr 28 2023

snehasish accepted D149475: [MemProf] Use updated version of hot/cold operator new.

Should we update this too https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/llvm-tli-checker/ps4-tli-check.yaml#L41

Apr 28 2023, 12:14 PM · Restricted Project, Restricted Project

Apr 27 2023

snehasish committed rG1176d97598a9: [memprof][NFC] Update a stale comment about symbolization. (authored by snehasish).
[memprof][NFC] Update a stale comment about symbolization.
Apr 27 2023, 12:00 PM · Restricted Project, Restricted Project
snehasish closed D149370: [memprof][NFC] Update a stale comment about symbolization..
Apr 27 2023, 11:59 AM · Restricted Project, Restricted Project
snehasish requested review of D149370: [memprof][NFC] Update a stale comment about symbolization..
Apr 27 2023, 11:57 AM · Restricted Project, Restricted Project

Apr 26 2023

snehasish accepted D149117: [MemProf] Context disambiguation cloning pass [patch 4/4].

lgtm

Apr 26 2023, 4:38 PM · Restricted Project, Restricted Project
snehasish added a comment to D141077: [MemProf] Context disambiguation cloning pass [patch 3/4].

Looks good overall, still thinking if we can make assignFunctions less monolithic and easier to follow.

Apr 26 2023, 12:59 PM · Restricted Project, Restricted Project

Apr 25 2023

snehasish accepted D149192: [IR] Add interface to remove a CallBase string function attribute.

lgtm

Apr 25 2023, 2:15 PM · Restricted Project, Restricted Project

Apr 20 2023

snehasish accepted D140949: [MemProf] Context disambiguation cloning pass [patch 2/3].

lgtm

Apr 20 2023, 12:51 PM · Restricted Project, Restricted Project

Apr 19 2023

snehasish added a comment to D141077: [MemProf] Context disambiguation cloning pass [patch 3/4].

Still need to look into assignFunctions but before I do I'm wondering if this patch can be split into two with applyImport and assignFunctions in separate patches. What do you think?

Apr 19 2023, 5:33 PM · Restricted Project, Restricted Project
snehasish accepted D148718: [MemProf] Optionally pass hot/cold hints to operator new.

lgtm

Apr 19 2023, 12:43 PM · Restricted Project, Restricted Project
snehasish added inline comments to D148718: [MemProf] Optionally pass hot/cold hints to operator new.
Apr 19 2023, 10:38 AM · Restricted Project, Restricted Project

Apr 17 2023

snehasish committed rG932d7b9ddd23: [memprof] Print out profile build ids in the error message. (authored by snehasish).
[memprof] Print out profile build ids in the error message.
Apr 17 2023, 10:54 AM · Restricted Project, Restricted Project
snehasish closed D148301: [memprof] Print out profile build ids in the error message..
Apr 17 2023, 10:54 AM · Restricted Project, Restricted Project
snehasish updated the diff for D148301: [memprof] Print out profile build ids in the error message..

Rebase, address comment.

Apr 17 2023, 10:34 AM · Restricted Project, Restricted Project

Apr 14 2023

snehasish added a comment to D148301: [memprof] Print out profile build ids in the error message..

Thanks for the quick review!

Apr 14 2023, 2:01 PM · Restricted Project, Restricted Project
snehasish updated the diff for D148301: [memprof] Print out profile build ids in the error message..

Address comments.

Apr 14 2023, 1:49 PM · Restricted Project, Restricted Project

Apr 13 2023

snehasish updated the diff for D148301: [memprof] Print out profile build ids in the error message..

Remove unused include.

Apr 13 2023, 10:17 PM · Restricted Project, Restricted Project
snehasish requested review of D148301: [memprof] Print out profile build ids in the error message..
Apr 13 2023, 10:16 PM · Restricted Project, Restricted Project
snehasish accepted D148259: Fix warnings in InstrProfTest.cpp.

Can you leave an example of the warnings in the review discussion here for posterity? Thanks!

Apr 13 2023, 11:15 AM · Restricted Project, Restricted Project
snehasish accepted D146182: [llvm-profdata] Fixed various issue with Sample Profile Reader.

lgtm since I think this change is safe for existing profiles. @huangjd please confirm before submitting, thanks!

Apr 13 2023, 10:36 AM · Restricted Project, Restricted Project

Apr 12 2023

snehasish accepted D148150: [InstrProf][Temporal] Add weight field to traces.
Apr 12 2023, 8:17 PM · Restricted Project, Restricted Project, Restricted Project
snehasish accepted D148150: [InstrProf][Temporal] Add weight field to traces.

lgtm

Apr 12 2023, 5:08 PM · Restricted Project, Restricted Project, Restricted Project
snehasish added inline comments to D148150: [InstrProf][Temporal] Add weight field to traces.
Apr 12 2023, 1:15 PM · Restricted Project, Restricted Project, Restricted Project

Apr 10 2023

snehasish added inline comments to D140949: [MemProf] Context disambiguation cloning pass [patch 2/3].
Apr 10 2023, 2:49 PM · Restricted Project, Restricted Project

Apr 6 2023

snehasish accepted D147287: [InstrProf] Temporal Profiling.

lgtm

Apr 6 2023, 6:25 PM · Restricted Project, Restricted Project, Restricted Project
snehasish added inline comments to D147287: [InstrProf] Temporal Profiling.
Apr 6 2023, 4:26 PM · Restricted Project, Restricted Project, Restricted Project
snehasish added a comment to D147287: [InstrProf] Temporal Profiling.

Looks good overall, added a few comments which are mostly cosmetic.

Apr 6 2023, 11:30 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2023

snehasish accepted D145836: [MemProf] Context disambiguation cloning pass [patch 1b/3].

lgtm, I assume you will reduce these test cases too?

Mar 21 2023, 2:22 PM · Restricted Project, Restricted Project
snehasish committed rGcef71d0105c5: [memprof] Support symbolization of PIE binaries. (authored by snehasish).
[memprof] Support symbolization of PIE binaries.
Mar 21 2023, 1:13 PM · Restricted Project, Restricted Project
snehasish closed D146181: [memprof] Support symbolization of PIE binaries..
Mar 21 2023, 1:13 PM · Restricted Project, Restricted Project
snehasish updated the diff for D146181: [memprof] Support symbolization of PIE binaries..

Rebase, remove var only used in assert.

Mar 21 2023, 1:09 PM · Restricted Project, Restricted Project
snehasish added a comment to D146181: [memprof] Support symbolization of PIE binaries..

Thanks for the review!

Mar 21 2023, 12:58 PM · Restricted Project, Restricted Project
snehasish updated the diff for D146181: [memprof] Support symbolization of PIE binaries..

Address comments.

Mar 21 2023, 12:56 PM · Restricted Project, Restricted Project
snehasish added a comment to D146181: [memprof] Support symbolization of PIE binaries..

PTAL, thanks!

Mar 21 2023, 11:37 AM · Restricted Project, Restricted Project
snehasish updated the diff for D146181: [memprof] Support symbolization of PIE binaries..

Address comments.

Mar 21 2023, 11:36 AM · Restricted Project, Restricted Project
snehasish added inline comments to D140908: [MemProf] Context disambiguation cloning pass [patch 1a/3].
Mar 21 2023, 10:02 AM · Restricted Project, Restricted Project

Mar 20 2023

snehasish accepted D140908: [MemProf] Context disambiguation cloning pass [patch 1a/3].

lgtm, overall. The remaining comments are minor and thanks for the explanations in the tests.

Mar 20 2023, 2:31 PM · Restricted Project, Restricted Project

Mar 16 2023

snehasish requested changes to D146182: [llvm-profdata] Fixed various issue with Sample Profile Reader.

Can you split out the uint64_t type changes into a separate patch?

Mar 16 2023, 12:37 PM · Restricted Project, Restricted Project

Mar 15 2023

snehasish requested review of D146181: [memprof] Support symbolization of PIE binaries..
Mar 15 2023, 5:11 PM · Restricted Project, Restricted Project
snehasish added a comment to D140908: [MemProf] Context disambiguation cloning pass [patch 1a/3].

Still working my way through updateStackNodes. Here are some of the comments I have so far --

Mar 15 2023, 4:55 PM · Restricted Project, Restricted Project

Mar 14 2023

snehasish committed rGa1bbf5ac3cbd: [memprof] Record BuildIDs in the raw profile. (authored by snehasish).
[memprof] Record BuildIDs in the raw profile.
Mar 14 2023, 11:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
snehasish closed D145190: [memprof] Record BuildIDs in the raw profile..
Mar 14 2023, 11:16 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
snehasish accepted D146007: [docs] Document MemProf metadata in LangRef.

lgtm, thanks for documenting the metadata format.

Mar 14 2023, 10:37 AM · Restricted Project, Restricted Project

Mar 13 2023

snehasish updated the diff for D145190: [memprof] Record BuildIDs in the raw profile..

Update the unittest in compiler-rt which was caught by the build bot failures.

Mar 13 2023, 4:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
snehasish reopened D145190: [memprof] Record BuildIDs in the raw profile..

Reopening since I missed the updates to the memprof unit tests in compiler-rt. This was caught by the buildbots. As part of the changes I modified the SerializeToRawProfile API slightly to make it easier to test. Also regenerated the raw profiles and binaries again since the runtime changed.

Mar 13 2023, 4:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
snehasish added a reverting change for rG287177a47a39: [memprof] Record BuildIDs in the raw profile.: rGdebe80cb8d50: Revert "[memprof] Record BuildIDs in the raw profile.".
Mar 13 2023, 1:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
snehasish committed rGdebe80cb8d50: Revert "[memprof] Record BuildIDs in the raw profile." (authored by snehasish).
Revert "[memprof] Record BuildIDs in the raw profile."
Mar 13 2023, 1:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
snehasish added a reverting change for D145190: [memprof] Record BuildIDs in the raw profile.: rGdebe80cb8d50: Revert "[memprof] Record BuildIDs in the raw profile.".
Mar 13 2023, 1:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
snehasish committed rG287177a47a39: [memprof] Record BuildIDs in the raw profile. (authored by snehasish).
[memprof] Record BuildIDs in the raw profile.
Mar 13 2023, 12:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
snehasish closed D145190: [memprof] Record BuildIDs in the raw profile..
Mar 13 2023, 12:28 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 9 2023

snehasish updated the diff for D145190: [memprof] Record BuildIDs in the raw profile..

Update test regex.

Mar 9 2023, 3:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
snehasish added a comment to D145190: [memprof] Record BuildIDs in the raw profile..

lgtm - but does this depend on D145644 and require some additional test changes?

Yes, I will rebase this patch once that is submitted. I need to look at the LLVM.Transforms/PGOProfile::memprof.ll test failures.

Mar 9 2023, 2:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
snehasish updated the diff for D145190: [memprof] Record BuildIDs in the raw profile..

Update raw profiles, add another test for buildids only.

Mar 9 2023, 2:27 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
snehasish committed rGe99b5ad38381: [memprof] Add scripts to automate testdata regeneration. (authored by snehasish).
[memprof] Add scripts to automate testdata regeneration.
Mar 9 2023, 11:54 AM · Restricted Project, Restricted Project, Restricted Project
snehasish closed D145644: [memprof] Add scripts to automate testdata regeneration..
Mar 9 2023, 11:54 AM · Restricted Project, Restricted Project, Restricted Project
snehasish added a comment to D145644: [memprof] Add scripts to automate testdata regeneration..

I'll go ahead and push this. @dblaikie Let me know if you have any comments and I'll follow up separately. Thanks!

Mar 9 2023, 11:47 AM · Restricted Project, Restricted Project, Restricted Project
snehasish added a comment to D145644: [memprof] Add scripts to automate testdata regeneration..

Generally lgtm, but why did the raw profiles change size from what is currently committed?

Mar 9 2023, 11:38 AM · Restricted Project, Restricted Project, Restricted Project
snehasish updated the diff for D145644: [memprof] Add scripts to automate testdata regeneration..

Update the script in test/tool/llvm-profdata/Inputs.

Mar 9 2023, 11:23 AM · Restricted Project, Restricted Project, Restricted Project
snehasish added inline comments to D145644: [memprof] Add scripts to automate testdata regeneration..
Mar 9 2023, 10:53 AM · Restricted Project, Restricted Project, Restricted Project
snehasish updated the diff for D145644: [memprof] Add scripts to automate testdata regeneration..

Update the script for Transforms/PGOProfile/memprof.ll.

Mar 9 2023, 10:49 AM · Restricted Project, Restricted Project, Restricted Project
snehasish added a comment to D145190: [memprof] Record BuildIDs in the raw profile..

lgtm - but does this depend on D145644 and require some additional test changes?

Mar 9 2023, 8:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 8 2023

snehasish added a comment to D145023: [memprof] Refactor tests to generate binaries and profiles on the fly..

Perhaps a script to easily update things for new versions would be adequate?

Took a stab at it in D145644, PTAL thanks!

Mar 8 2023, 8:09 PM · Restricted Project, Restricted Project, Restricted Project
snehasish requested review of D145644: [memprof] Add scripts to automate testdata regeneration..
Mar 8 2023, 8:04 PM · Restricted Project, Restricted Project, Restricted Project
snehasish abandoned D145428: [memprof] Restrict memprof profile generation to clang only..
Mar 8 2023, 11:25 AM · Restricted Project, Restricted Project
snehasish added a comment to D145428: [memprof] Restrict memprof profile generation to clang only..

I don't recall why we set this to false at this specific point, it seems like it should be ok to delay it. And then I wonder if we can combine memprof_init_is_running with memprof_init_done?

Delaying it seems to be fine on the small tests, let me look into what the other flags do and try to simplify if we can.

Mar 8 2023, 11:25 AM · Restricted Project, Restricted Project
snehasish committed rG79ebb6385b3a: [memprof] Simplify initialized flags. (authored by snehasish).
[memprof] Simplify initialized flags.
Mar 8 2023, 10:02 AM · Restricted Project, Restricted Project
snehasish closed D145528: [memprof] Simplify initialized flags..
Mar 8 2023, 10:02 AM · Restricted Project, Restricted Project
snehasish added inline comments to D145528: [memprof] Simplify initialized flags..
Mar 8 2023, 10:01 AM · Restricted Project, Restricted Project

Mar 7 2023

snehasish updated the diff for D145528: [memprof] Simplify initialized flags..

clang-format, rebase.

Mar 7 2023, 5:09 PM · Restricted Project, Restricted Project
snehasish added inline comments to D145528: [memprof] Simplify initialized flags..
Mar 7 2023, 4:02 PM · Restricted Project, Restricted Project
snehasish added a reviewer for D145528: [memprof] Simplify initialized flags.: tejohnson.
Mar 7 2023, 3:45 PM · Restricted Project, Restricted Project
snehasish requested review of D145528: [memprof] Simplify initialized flags..
Mar 7 2023, 3:44 PM · Restricted Project, Restricted Project
snehasish committed rGbcebadeba75f: [memprof] Update the isRuntime symbolization check. (authored by snehasish).
[memprof] Update the isRuntime symbolization check.
Mar 7 2023, 12:16 PM · Restricted Project, Restricted Project
snehasish closed D145521: [memprof] Update the isRuntime symbolization check..
Mar 7 2023, 12:16 PM · Restricted Project, Restricted Project
snehasish added a comment to D145521: [memprof] Update the isRuntime symbolization check..

Failing build on Windows seems to be unrelated:

Mar 7 2023, 12:15 PM · Restricted Project, Restricted Project
snehasish added a comment to D145428: [memprof] Restrict memprof profile generation to clang only..

Yeah, that seems like the best option.

Sent D145521 to match filenames which define interceptors.

Mar 7 2023, 11:39 AM · Restricted Project, Restricted Project
snehasish requested review of D145521: [memprof] Update the isRuntime symbolization check..
Mar 7 2023, 11:37 AM · Restricted Project, Restricted Project
snehasish added a comment to D145212: Only split cold blocks with more than a given number of instructions.

It seems to me that this patch would also need:

  • Some regression test to test it actually changes code generation (only?) when targeting Arm.
  • As is, this patch will not result in changed code generation IIUC?
Mar 7 2023, 11:01 AM · Restricted Project, Restricted Project
snehasish added a comment to D145428: [memprof] Restrict memprof profile generation to clang only..

I don't recall why we set this to false at this specific point, it seems like it should be ok to delay it. And then I wonder if we can combine memprof_init_is_running with memprof_init_done?

Mar 7 2023, 10:57 AM · Restricted Project, Restricted Project

Mar 6 2023

snehasish added a comment to D145428: [memprof] Restrict memprof profile generation to clang only..

Also looking into why we have these extra interceptions, it looks like we set memprof_init_is_running to false and a subsequent call to Symbolizer::LateInitialize is intercepted [1].

Mar 6 2023, 6:58 PM · Restricted Project, Restricted Project
snehasish added a comment to D145428: [memprof] Restrict memprof profile generation to clang only..

I assumed it was due to optimizations however after looking more closely, the behaviour is due to a difference in debug information for the compiler-rt runtime. For the basic test case with the code below --

Mar 6 2023, 5:44 PM · Restricted Project, Restricted Project
snehasish added a reverting change for rG599b7690fa91: [memprof] Refactor tests to generate binaries and profiles on the fly.: rGe1b569b96a06: Revert "[memprof] Refactor tests to generate binaries and profiles on the fly.".
Mar 6 2023, 3:52 PM · Restricted Project, Restricted Project, Restricted Project
snehasish committed rGe1b569b96a06: Revert "[memprof] Refactor tests to generate binaries and profiles on the fly." (authored by snehasish).
Revert "[memprof] Refactor tests to generate binaries and profiles on the fly."
Mar 6 2023, 3:52 PM · Restricted Project, Restricted Project, Restricted Project
snehasish added a reverting change for D145023: [memprof] Refactor tests to generate binaries and profiles on the fly.: rGe1b569b96a06: Revert "[memprof] Refactor tests to generate binaries and profiles on the fly.".
Mar 6 2023, 3:52 PM · Restricted Project, Restricted Project, Restricted Project
snehasish requested review of D145428: [memprof] Restrict memprof profile generation to clang only..
Mar 6 2023, 2:23 PM · Restricted Project, Restricted Project
snehasish committed rG599b7690fa91: [memprof] Refactor tests to generate binaries and profiles on the fly. (authored by snehasish).
[memprof] Refactor tests to generate binaries and profiles on the fly.
Mar 6 2023, 1:25 PM · Restricted Project, Restricted Project, Restricted Project
snehasish closed D145023: [memprof] Refactor tests to generate binaries and profiles on the fly..
Mar 6 2023, 1:24 PM · Restricted Project, Restricted Project, Restricted Project
snehasish updated the diff for D145023: [memprof] Refactor tests to generate binaries and profiles on the fly..

Rebase.

Mar 6 2023, 1:22 PM · Restricted Project, Restricted Project, Restricted Project