- User Since
- Jun 10 2017, 12:15 PM (263 w, 4 d)
Mon, Jun 27
Fri, Jun 24
Thanks for the quick review.
Add test description.
Wed, Jun 22
I'm still going through PGOInstrumentation.cpp ...
Tue, Jun 21
lgtm with a couple of minor comments.
Wed, Jun 15
Tue, Jun 14
Update binary names to be consistent.
Wed, Jun 1
Split out the segment information print in D126840.
Remove summary changes from this patch.
Add another field which tracks the number of mibs we have.
May 25 2022
Thanks for the review.
May 24 2022
Remove unnecessary blank lines.
May 4 2022
May 2 2022
Apr 29 2022
Apr 8 2022
Apr 7 2022
Thanks for the detailed review as always. :)
Thanks for the review, ptal!
Apr 4 2022
Mar 22 2022
Mar 21 2022
With this patch on an internal binary, the time taken to merge indexed and raw profile increases to 85s (up from 48s in D120430). The zip profile size increases to ~520M (up from 247M in D118653). I'll look into de-duplicating the inline storage of callstacks and their frames in followup patches. Thanks for the review!
Mar 18 2022
Updated the patch to track callsites for all functions in the frame. PTAL, thanks!
Fix lit test and some cleanup.
Mar 16 2022
@tejohnson I've updated the logic to track and annotate additional functions with the allocation site profiles. Please take a look at the example in MemProfTest.cpp L176 to see if it matches your expectations. Thanks!
Update allocsite and callsite profile contents.
Mar 15 2022
Updated the test documentation. PTAL, thanks!
Rebase, lint and fix test invocation.
Mar 9 2022
Discussed with @tejohnson offline how we can make the matching more robust.
Thanks for the detailed review! PTAL.
Mar 7 2022
Add a comment and remove some commented code.
Mar 4 2022
Mar 3 2022
Add TODO to update summary print.
Simplify discarded vaddrs check, rename method to indicate filtering and add comments.
Mar 2 2022
Updated the patch with comments. PTAL, thanks!
Feb 23 2022
Thanks for the reviews.
Move the InstrProfKind::MemProf comment above the decl to be consistent.