HIP may be installed into /usr or /usr/local on a variety of Linux
operating systems. It may become unwieldy to list them all.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Ubuntu Lunar (23.04) has released, which is the first version of Ubuntu with ROCm support in the universe repos. With respect to ROCm, it is basically a snapshot of Debian Sid. However, since LLVM detects HIP package differently on Ubuntu than on Debian, there are additional flags required on Ubuntu that are not needed on Debian. This patch removes the differences in behaviour between distros. An alternative approach would be just to add || Dist.IsGentoo() || Dist.IsUbuntu() to the existing check, but that may still fail on Ubuntu-derived distros such as Linux Mint.
As far as I know, I cannot commit this change myself as I do not have write access for LLVM trunk. Please feel free to submit this change for me once it has all necessary approvals.
clang-format not found in user’s local PATH; not linting file.