This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][Wrapper] Fix off-by-one when parsing 'cmp' output
ClosedPublic

Authored by jobnoorman on Apr 24 2023, 2:35 AM.

Details

Summary

The byte offsets in the output of 'cmp' start from 1, not from 0 as the
current parser assumes. This caused mismatched bytes to sometimes be
attributed to the wrong section.

Diff Detail

Event Timeline

jobnoorman created this revision.Apr 24 2023, 2:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2023, 2:35 AM
jobnoorman requested review of this revision.Apr 24 2023, 2:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2023, 2:35 AM
rafauler accepted this revision.Apr 24 2023, 11:02 AM
This revision is now accepted and ready to land.Apr 24 2023, 11:02 AM