This is an archive of the discontinued LLVM Phabricator instance.

[Demangle] fix windows tests
ClosedPublic

Authored by nickdesaulniers on Apr 20 2023, 3:43 PM.

Details

Summary

My reland of https://reviews.llvm.org/D148546 has caused a few windows
demangler tests to fail when run with -DLLVM_ENABLE_EXPENSIVE_CHECKS=ON
on windows.

I have a sneaking suspicion that MSVC's
std::string_view::iterator::operator* may be missing a nullptr check.

Link: https://lab.llvm.org/buildbot/#/builders/42/builds/9723/steps/7/logs/stdio

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 3:43 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
nickdesaulniers requested review of this revision.Apr 20 2023, 3:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 3:43 PM
llvm/lib/Demangle/MicrosoftDemangle.cpp
811–813

I think this is potentially backwards. I'll add some asserts and flip it.

ayzhao accepted this revision.Apr 20 2023, 3:57 PM

LGTM, all the failing tests seem to be passing on my Windows workstation.

This revision is now accepted and ready to land.Apr 20 2023, 3:57 PM
  • add assert, change Count
This revision was landed with ongoing or failed builds.Apr 20 2023, 4:41 PM
This revision was automatically updated to reflect the committed changes.