In D150122#4388978, @ayzhao wrote:

In D150122#4388972, @cor3ntin wrote:

I guess we should land that now @erichkeane ?

Sorry, but there's actually one more crash that was just reported earlier this week: https://github.com/llvm/llvm-project/issues/63008. We should wait until the backport PR has been approved.

In D150122#4388972, @cor3ntin wrote:

I guess we should land that now @erichkeane ?

rebasing, CI seems to be fixed now

rebase to see if this fixes CI

Status update on backports:

FYI this is causing ninja check-bolt to fail with the following error:

Thanks!

We're starting to see build failures due to interception_failure_test.cpp unexpectedly passing on Windows: https://crbug.com/1443891

In D42600#4329528, @sushgokh wrote:

In D42600#4327970, @ayzhao wrote:

This is causing lld to crash on Chrome builds when PGO and ThinLTO are enabled: https://crbug.com/1443635

@ayzhao I request you to please provide me following information:

1. Reproducer of the function causing the assert failure

rebase

In D150122#4329401, @aaron.ballman wrote:

I believe we are having another release of Clang 16, but @tstellar can confirm or deny that.

AIUI, there were a few issues holding us back from claiming complete support (added @ayzhao as a reviewer in case he has a different opinion):
https://github.com/llvm/llvm-project/issues/61145 (backported to 16.x)
https://github.com/llvm/llvm-project/issues/62296 (backported to 16.x)
https://github.com/llvm/llvm-project/issues/62266 (not backported)
https://github.com/llvm/llvm-project/issues/61567 (not backported)

If we backport the two other issues to 16, then I think the changes in this review are fine. If we don't backport those two, I think we should claim Clang 17 to be conservative.

This is causing lld to crash on Chrome builds when PGO and ThinLTO are enabled: https://crbug.com/1443635

add comment

rebase + fix merge conflicts

In D149389#4303966, @shafik wrote:

So the change makes sense but the original issue: https://github.com/llvm/llvm-project/issues/62266 it worked for the first once but not the second, it also worked for the non-paren aggregate init. So I feel like the explanation is missing some details.

rebase + add release notes

add release note

code review comments + pull in D149301

In D149301#4302621, @aaron.ballman wrote:

I think you should add a release note for this when landing,

add release note

add another test

add another test and fix whitespace

code review comments + rebase

LGTM, confirmed this fixes the remaining broken tests on Windows:

LGTM, all the failing tests seem to be passing on my Windows workstation.

LGTM, looks like this builds on Windows now:

A new conversion issue popped up:

This still fails to build on Windows with MSVC's cl.exe compiler:

code review comments + rebase

remove unrelated formatting changes

rebase

fix comments

Address code review comments and (try) to fix Windows bot failure

fix missing EOF newline

In D137707#4256648, @ayzhao wrote:

In D137707#4253764, @serge-sans-paille wrote:

In D137707#4253255, @ayzhao wrote:

This is also causing another regression in Chrome that is *not* fixed by rGad9ad3735c48: https://crbug.com/1431366#c3

Can you provide a minimal reproducer?

Currently working on it, but I'd like to point out that this is also causing another (unrelated?) failure in Chrome/V8: https://crbug.com/1431489

In D137707#4253764, @serge-sans-paille wrote:

In D137707#4253255, @ayzhao wrote:

This is also causing another regression in Chrome that is *not* fixed by rGad9ad3735c48: https://crbug.com/1431366#c3

Can you provide a minimal reproducer?

This is also causing another regression in Chrome that is *not* fixed by rGad9ad3735c48: https://crbug.com/1431366#c3

In D137707#4243969, @serge-sans-paille wrote:

In D137707#4243796, @leonardchan wrote:

Hi. I think the reland broke our mac builder at https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-host_test_only-mac-subbuild/b8784753709492580801/overview with:

Assertion failed: (!I.isVolatile() && "auto init instructions cannot be volatile."), function runMoveAutoInit, file llvm/lib/Transforms/Utils/MoveAutoInit.cpp, line 112.

Thanks for reporting—I thought this situation wasn't possible— I'll send a fix that just skips these instructions for now.

fix stray whitespace change

use ParenListExpr and fix getSubExprAsWritten(...)

In D146675#4219987, @Mordante wrote:

I have not looked closely at the patch, can you please add the paper number in the summary and update the status page
libcxx/doc/Status? That makes reviewing the changes a lot easier.

In D146675#4215557, @thakis wrote:

Ms stl uses this construction to make the warning grouped under -Wdeprecated-declarations: https://github.com/search?q=repo%3Amicrosoft%2FSTL%20_CXX17_DEPRECATE_C_HEADER&type=code

Many worth doing?

code review comments

remove quotes from warning message

update warning message per review comments

Abandoning this revision as right now we're working on

remove extra semicolon

clean up test

I'm continuing to see the same unit test failure as https://crbug.com/1420824#c2 after including the latest commit

I tested the updated version of this patch to see if it fixes the Chrome test failures. Unfortunately, Clang now crashes when compiling an unrelated file in Chrome:

FYI this is causing (yet another) bug on Chrome/Chrome OS: https://crbug.com/1422033

FYI this patch also caused some of Chrome's unit tests to fail - see https://crbug.com/1420824

fix up the history a little bit so (hopefully) git will recognize the rename

Thanks for your effort on this!