This is an archive of the discontinued LLVM Phabricator instance.

[BOLT] Robustify compile-time config check
ClosedPublic

Authored by urnathan on Apr 20 2023, 11:46 AM.

Details

Summary

When working on the BOLT runtime config stuff, I noticed its common.h header file is a little lax in checking its own config. As we're hard coding system call numbers, let's be a little more paranoid. So,

*) Verify x86_64
*) Use linux to enable linux bits
*) Use APPLE to enable apple bits
*) #error when these are not available

IMHO This makes it very clear this is for a specific pair of systems.

Diff Detail

Event Timeline

urnathan created this revision.Apr 20 2023, 11:46 AM
urnathan requested review of this revision.Apr 20 2023, 11:46 AM
This revision is now accepted and ready to land.Apr 20 2023, 7:33 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 9:38 AM