This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add lowering for fp minimum/maximum
AbandonedPublic

Authored by skatkov on Apr 19 2023, 12:34 AM.

Details

Summary

Add lowering for floating point minimum and maximum intrinsics.

Diff Detail

Event Timeline

skatkov created this revision.Apr 19 2023, 12:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 12:34 AM
skatkov requested review of this revision.Apr 19 2023, 12:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 12:34 AM

Thanks for pointing - will take a look.

Yep! Looks like a duplicate but implemented in combine instead of lowering. Let reviewers to choose what is better. Will keep it for a while and then close as duplicate in case that patch is landed.

Again, thanks for pointing to.

skatkov abandoned this revision.Apr 19 2023, 1:47 AM

ok, in a review of https://reviews.llvm.org/D145634 it is explicitly mentioned that lowering is better than combining, so abandon tis in favor of that.