This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen] Add pre-commit tests for D148558
ClosedPublic

Authored by igor.kirillov on Apr 17 2023, 11:19 AM.

Details

Summary

This patch adds four new tests for upcoming functionality in LLVM:

  • complex-deinterleaving-add-mull-fixed-contract.ll
  • complex-deinterleaving-add-mull-scalable-contract.ll
  • complex-deinterleaving-add-mull-fixed-fast.ll
  • complex-deinterleaving-add-mull-scalable-fast.ll.

These tests were generated from the IR of vectorizable loops, which were
compiled from C++ code using different optimization flags in Clang. Each pair
of tests corresponds to Neon and SVE architectures, respectively, and
each pair contains tests compiled with -Ofast and -O3 -ffp-contract=fast
-ffinite-math-only optimization flags.
The tests were stripped of nnan and ninf flags as they have no impact on the
output.
The primary objective of these tests is to show the various sequences of
complex computations that may be encountered and to demonstrate the ability
of ComplexDeinterleaving to support any ordering.

Depends on D147451

Diff Detail

Event Timeline

igor.kirillov created this revision.Apr 17 2023, 11:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 11:19 AM
igor.kirillov requested review of this revision.Apr 17 2023, 11:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 11:19 AM
mgabka added inline comments.Apr 18 2023, 1:42 AM
llvm/test/CodeGen/AArch64/complex-deinterleaving-add-mull-fixed-contract.ll
7

maybe worth to add a comment explaining why the input IR in this and other files you add here looks like that?

I also noticed that this file and complex-deinterleaving-add-mull-scalable-contract.ll is not modified in the follow up patch, so maybe worth to explain it in the commit message, why.

igor.kirillov retitled this revision from [CodeGen] Add pre-commit tests for handling -Ofast generated code in ComplexDeinterleaving pass to [CodeGen] Add pre-commit tests for D148558.
igor.kirillov edited the summary of this revision. (Show Details)

Update commit message to better reflect the purpose of these tests

igor.kirillov edited reviewers, added: dmgreen; removed: greened.Apr 19 2023, 6:53 AM

Add one more pre-commit test

NickGuy accepted this revision.May 25 2023, 6:53 AM
This revision is now accepted and ready to land.May 25 2023, 6:53 AM
This revision was landed with ongoing or failed builds.May 30 2023, 4:51 AM
This revision was automatically updated to reflect the committed changes.