Change to system assembler to compile assembly files even -fintegrated-as is specified.
We don't have a good Clang as for now for assembly files on AIX.
Details
- Reviewers
hubert.reinterpretcast nemanjai Esme qiucf - Group Reviewers
Restricted Project - Commits
- rG4b27ad735c8d: [AIX] use system assembler for assembly files
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/test/Driver/aix-assembler.s | ||
---|---|---|
23 | I am not sure you need 6 RUN lines to test this. Whether a target uses integrated assembler has an existing test file and you can reuse that. |
I am not sure you need 6 RUN lines to test this. Whether a target uses integrated assembler has an existing test file and you can reuse that.
I don't have strong prefer which one we should use, a new file or reuse file. Since you point out, I change to reuse a legacy one in same dir. Please notice that there are some other targets that has their own assembler test file, like mips-as.s, systemz-as.s, arm64-as.s.
Thanks. It makes sense to check whether reusing a test file (possibly renaming it) makes sense.
https://maskray.me/blog/2021-08-08-toolchain-testing "an existing test can be enhanced"
Some existing tests can be improved. You may improve the testing without cargo culting:)
clang/test/Driver/target-as.s | ||
---|---|---|
1 ↗ | (On Diff #521233) | aix-as.c will be more appropriate. |
clang/test/Driver/target-as.s | ||
---|---|---|
1 ↗ | (On Diff #521233) | Do you mean we change this file to aix-as.s or we change back to previous version? The file target-as.s can not be renamed to aix-as.s, it also contains tests for i386, see the first run line. |
clang/test/Driver/target-as.s | ||
---|---|---|
1 ↗ | (On Diff #521233) | You can add the new tests to the existing aix-as.s. The behavior is about assemblers on AIX. aix-as.s seems more appropriate than target-as.s. |
clang/test/Driver/target-as.s | ||
---|---|---|
1 ↗ | (On Diff #521233) | hmm, we want to use assembly file for test. There is aix-as.c but no aix-as.s. |
clang/test/Driver/target-as.s | ||
---|---|---|
1 ↗ | (On Diff #521233) | You can use -x assembler. It's fairly common to use -x c++ xxx.c to test C++ with a C file. |
What is left for this to be reverted, in the quest to fully enable IAS for AIX?
See XCOFFAsmParser::ParseDirectiveCSect() and I think qual symbol names in AIX assembly(quite common for AIX assembly) can also not be parsed with llvm's asm parser.
Empty line?