This is an archive of the discontinued LLVM Phabricator instance.

[mlir][vector] Fix integer promotion type mismatch
ClosedPublic

Authored by antiagainst on Apr 16 2023, 8:51 AM.

Details

Summary

We need to create a new type with transposed shape after
transposing the operand in CanonicalizeContractMatmulToMMT.

Diff Detail

Event Timeline

antiagainst created this revision.Apr 16 2023, 8:51 AM
Herald added a project: Restricted Project. · View Herald Transcript
antiagainst requested review of this revision.Apr 16 2023, 8:51 AM
kuhar accepted this revision.Apr 16 2023, 10:27 AM

Thanks for fixing!

mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
1082

nit: prefer the free cast functions

This revision is now accepted and ready to land.Apr 16 2023, 10:27 AM
dcaballe accepted this revision.Apr 17 2023, 10:59 AM
dcaballe added inline comments.
mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
1090

Probably easier to just use the VectorType::get factory.

This revision was automatically updated to reflect the committed changes.
antiagainst marked 2 inline comments as done.