This is an archive of the discontinued LLVM Phabricator instance.

[mlir][affine] Split `reifyValueBound` in two functions

Authored by springerm on Apr 10 2023, 7:42 PM.



There are now two entry points. One for shaped values and one for index-typed values. This addresses a comment in D146524.

Diff Detail

Event Timeline

springerm created this revision.Apr 10 2023, 7:42 PM
Herald added a project: Restricted Project. · View Herald Transcript
springerm requested review of this revision.Apr 10 2023, 7:42 PM

I don't think an API deprecation can be marked NFC

springerm retitled this revision from [mlir][affine][NFC] Split `reifyValueBound` in two functions to [mlir][affine] Split `reifyValueBound` in two functions.Apr 10 2023, 8:12 PM
dcaballe accepted this revision.Apr 18 2023, 12:04 AM
dcaballe added inline comments.

expect -> except? (2x)

This revision is now accepted and ready to land.Apr 18 2023, 12:04 AM
This revision was landed with ongoing or failed builds.Apr 18 2023, 12:41 AM
This revision was automatically updated to reflect the committed changes.
springerm marked an inline comment as done.