This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add a test to show bad compilation to set_inactive
ClosedPublic

Authored by ruiling on Apr 5 2023, 11:44 PM.

Details

Summary

The set_inactive was originally inside a if branch, but was incorrectly
hoisted out of the loop. So the lanes that were disabled later after the
if() branch inside the loop were not set correctly. It should stay in
the if branch.

Diff Detail

Event Timeline

ruiling created this revision.Apr 5 2023, 11:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 11:44 PM
ruiling requested review of this revision.Apr 5 2023, 11:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 11:44 PM
foad accepted this revision.Apr 6 2023, 1:52 AM
This revision is now accepted and ready to land.Apr 6 2023, 1:52 AM
This revision was landed with ongoing or failed builds.Apr 6 2023, 6:11 PM
This revision was automatically updated to reflect the committed changes.