This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add tests for loads and stores of illegal fixed length vectors
ClosedPublic

Authored by luke on Apr 5 2023, 5:45 AM.

Details

Summary

I was investigating why getMemoryOpCost was so expensive for these fixed length vector types, so I've added these tests to see what was going on.
It looks like there's some room for codegen improvement before we adjust the cost model.

Diff Detail

Event Timeline

luke created this revision.Apr 5 2023, 5:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 5:45 AM
luke requested review of this revision.Apr 5 2023, 5:45 AM
luke retitled this revision from [RISCV] Add tests for loads and stores of irregular fixed length vectors to [RISCV] Add tests for loads and stores of illegal fixed length vectors.Apr 5 2023, 7:49 AM
craig.topper added inline comments.Apr 5 2023, 9:54 AM
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-load.ll
24

This seems to be loading 8 bytes in the generated code. Should probably test with an explicit align 1 on the load too.

luke updated this revision to Diff 511158.Apr 5 2023, 11:02 AM

Add test case for loads and stores with align 1

This revision is now accepted and ready to land.Apr 5 2023, 4:04 PM
This revision was landed with ongoing or failed builds.Apr 6 2023, 9:40 AM
This revision was automatically updated to reflect the committed changes.