[mlir] [Linalg] Limit Detensorize pass to FunctionOpInterface

[ubfx]

Summary

The linalg-detensorize Pass can only be run on FunctionOpInterface Ops and will crash when run on other ops. The TableGen definition of the pass did not enforce that.

Github issue here: https://github.com/llvm/llvm-project/issues/61845

[mehdi_amini]

Is the cast still needed now? I would think that getOperation() returns directly the interface now

[ubfx]

Remove the cast because getOperation() already returns the Interface.

[ubfx]

In D147384#4238659, @mehdi_amini wrote:

Is the cast still needed now? I would think that getOperation() returns directly the interface now

Thank you for the hint, I removed the cast.

[ubfx]

Could someone with repository access push this patch? Thanks in advance :)

0002-mlir-Linalg-Limit-Detensorize-pass-to-FunctionOpInte.patch2 KBDownload

mlir/include/mlir/Dialect/Linalg/Passes.td

 }
 
 def LinalgGeneralization : Pass<"linalg-generalize-named-ops", "func::FuncOp"> {
   let summary = "Convert named ops into generic ops";
   let constructor = "mlir::createLinalgGeneralizationPass()";
   let dependentDialects = ["linalg::LinalgDialect"];
 }
 
-def LinalgDetensorize : Pass<"linalg-detensorize", ""> {
+def LinalgDetensorize : InterfacePass<"linalg-detensorize", "FunctionOpInterface"> {
   let summary = "Detensorize linalg ops";
   let constructor = "mlir::createLinalgDetensorizePass()";
   let dependentDialects = [];
 
   let description = [{
     Detensoring is the process through which a tensor value is converted to one
     or potentially more primitive value(s). During this process, operations with
     such detensored operands are also converted to an equivalent form that works