Page MenuHomePhabricator

[mlir] [Linalg] Limit Detensorize pass to FunctionOpInterface
ClosedPublic

Authored by ubfx on Apr 1 2023, 12:39 PM.

Details

Summary

The linalg-detensorize Pass can only be run on FunctionOpInterface Ops and will crash when run on other ops. The TableGen definition of the pass did not enforce that.

Github issue here: https://github.com/llvm/llvm-project/issues/61845

Diff Detail

Event Timeline

ubfx created this revision.Apr 1 2023, 12:39 PM
ubfx requested review of this revision.Apr 1 2023, 12:39 PM
mehdi_amini accepted this revision.Apr 1 2023, 12:58 PM

Is the cast still needed now? I would think that getOperation() returns directly the interface now

This revision is now accepted and ready to land.Apr 1 2023, 12:58 PM
ubfx updated this revision to Diff 510259.Apr 1 2023, 1:14 PM

Remove the cast because getOperation() already returns the Interface.

ubfx added a comment.Apr 1 2023, 1:14 PM

Is the cast still needed now? I would think that getOperation() returns directly the interface now

Thank you for the hint, I removed the cast.

ubfx added a comment.EditedApr 2 2023, 11:59 AM

Could someone with repository access push this patch? Thanks in advance :)

This revision was automatically updated to reflect the committed changes.