This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][libomptarget][NFC] Make private mapping test more explicit on failure
ClosedPublic

Authored by doru1004 on Mar 24 2023, 7:24 AM.

Details

Summary

The private_mapping.c test fails intermittently on the buildbot. To learn from these failures which cannot be reproduced locally we make the private mapping test more explicit on failure. This patch does not bring in any functional changes to the test itself.

Diff Detail

Event Timeline

doru1004 created this revision.Mar 24 2023, 7:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2023, 7:24 AM
doru1004 requested review of this revision.Mar 24 2023, 7:24 AM

when the test detects the error, can we dump out all the arrays data1, data2, data3, and sum . and then break ...

doru1004 updated this revision to Diff 508100.Mar 24 2023, 8:05 AM

In case folks are worried about this debug content:
this patch will have a short life span, once we see the dump from the BOT, we can revert it.

jhuber6 accepted this revision.Mar 24 2023, 8:36 AM

LG as long as we can fix it later once the bot picks it up.

This revision is now accepted and ready to land.Mar 24 2023, 8:36 AM

LG as long as we can fix it later once the bot picks it up.

That's the intention.