This is an archive of the discontinued LLVM Phabricator instance.

Differential D146807

[flang][Driver] Fix lto-flags.f90 on Solaris
ClosedPublic

Authored by ro on Mar 24 2023, 5:47 AM.

Details

Reviewers
mnadeem
awarzynski
kiranchandramohan
sscalpone
Commits
rG65c4aceb735b: [flang][Driver] Fix lto-flags.f90 on Solaris
Summary

The Flang :: Driver/lto-flags.f90 test FAILs on Solaris:

/vol/llvm/src/llvm-project/dist/flang/test/Driver/lto-flags.f90:30:13: error: THIN-LTO: expected string not found in input
! THIN-LTO: "-plugin-opt=thinlto"
            ^

This is no wonder since the native Solaris ld doesn't support the linker plugin interface at all, so this patch marks the test as UNSUPPORTED.

Tested on amd64-pc-solaris2.11 and x86_64-pc-linux-gnu.

Diff Detail

Event Timeline

ro created this revision.Mar 24 2023, 5:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2023, 5:47 AM
Herald added subscribers: sunshaoce, ormris, jdoerfert and 5 others. · View Herald Transcript
ro requested review of this revision.Mar 24 2023, 5:47 AM
awarzynski accepted this revision.Mar 24 2023, 5:51 AM

LGTM, thanks!

This revision is now accepted and ready to land.Mar 24 2023, 5:51 AM
Harbormaster completed remote builds in B221564: Diff 508061.Mar 24 2023, 6:07 AM
Closed by commit rG65c4aceb735b: [flang][Driver] Fix lto-flags.f90 on Solaris (authored by ro). · Explain WhyMar 24 2023, 6:25 AM
This revision was automatically updated to reflect the committed changes.
ro added a commit: rG65c4aceb735b: [flang][Driver] Fix lto-flags.f90 on Solaris.

Revision Contents

PathSize
flang/
test/
Driver/
3 lines

Diff 508069

flang/test/Driver/lto-flags.f90

! UNSUPPORTED: system-windows ! Solaris ld doesn't support the linker plugin interface
! UNSUPPORTED: system-windows, system-solaris
! RUN: %flang -### -S %s 2>&1 | FileCheck %s --check-prefix=NO-LTO ! RUN: %flang -### -S %s 2>&1 | FileCheck %s --check-prefix=NO-LTO
! RUN: %flang -### -S -fno-lto %s 2>&1 | FileCheck %s --check-prefix=NO-LTO ! RUN: %flang -### -S -fno-lto %s 2>&1 | FileCheck %s --check-prefix=NO-LTO
! Full LTO and aliases. ! Full LTO and aliases.
! RUN: %flang -### -S -flto %s 2>&1 | FileCheck %s --check-prefix=FULL-LTO ! RUN: %flang -### -S -flto %s 2>&1 | FileCheck %s --check-prefix=FULL-LTO
! RUN: %flang -### -S -flto=full %s 2>&1 | FileCheck %s --check-prefix=FULL-LTO ! RUN: %flang -### -S -flto=full %s 2>&1 | FileCheck %s --check-prefix=FULL-LTO
! RUN: %flang -### -S -flto=auto %s 2>&1 | FileCheck %s --check-prefix=FULL-LTO ! RUN: %flang -### -S -flto=auto %s 2>&1 | FileCheck %s --check-prefix=FULL-LTO
! RUN: %flang -### -S -flto=jobserver %s 2>&1 | FileCheck %s --check-prefix=FULL-LTO ! RUN: %flang -### -S -flto=jobserver %s 2>&1 | FileCheck %s --check-prefix=FULL-LTO
Show All 23 Lines