User Details
- User Since
- Nov 29 2020, 10:02 PM (147 w, 2 d)
Mon, Sep 4
Redundant after https://reviews.llvm.org/D150796 and https://reviews.llvm.org/D153768
Aug 16 2023
ping
May 18 2023
May 16 2023
Hi, this patch is creating malformed IR for some cases. Test case here: https://github.com/llvm/llvm-project/issues/62756
@nikic Please feel free to take over/commandeer this revision.
May 1 2023
ping
Apr 15 2023
ping
Apr 12 2023
Hi, I am seeing an 8% degradation in SPEC 2006 Soplex after this patch. Created an issue here: https://github.com/llvm/llvm-project/issues/62100
Apr 7 2023
Added an exception for constant dereferenceable pointers and changed canReplacePointersIfEqual to not look at the Uses.
Mar 27 2023
Hi, I am seeing some inefficient codegen after this patch for AArch64 SVE, created a github issue: https://github.com/llvm/llvm-project/issues/61742
Mar 23 2023
ping
Mar 20 2023
Mar 18 2023
- Use diagnostics (reused existing diag)
- Add a test
Mar 17 2023
Mar 16 2023
- Guard addToLeaderTable with the pointer replacement check.
Mar 12 2023
There is an existing test flang/test/Driver/target-cpu-features.f90 added in D137995
Mar 10 2023
Mar 9 2023
Thanks awarzynski, I have been a bit busy but I will try to land this today after making the test changes.
In the future I'll try to communicate any planning beforehand, using discourse, to make reviewing easier. (I'm still a relatively new contributor to LLVM so still learning :) )
Mar 2 2023
Feb 28 2023
update comments in the test and add newline at the end
Feb 27 2023
Fix the check for PHI nodes and add some reduced tests relevant to the case.
Ported all changes to the patch I previously added as the child revision.
Removing from reviewer's ready to review list for now. Will come back to this patch when/if time permits.
Removing from reviewer's ready to review list for now. Will come back to this patch when/if time permits.
Removing from reviewer's ready to review list for now. Will come back to this patch when/if time permits.
Removing from reviewer's ready to review list for now.
Add LTO bitcode test.
clang format
Feb 25 2023
- Added a new method replaceDominatedUsesWithIf() that takes a callback.
- Updated canReplacePointersIfEqual() to return true for the following:
- Uses in ICmpInst and PtrToIntInst
- Replacements with null
- When underlying objects are the same
- Update tests.
- New LLVM test suite bitcode diff using O3 (assembly files were more difficult to analyze): https://github.com/UsmanNadeem/vigilant-octo-journey/commit/65a770a65eca4ed2cb37f6ff6a36ec6193fe8b73
Feb 20 2023
Feb 9 2023
@nikic
I was looking at https://llvm.org/devmtg/2018-04/slides/Lopes-Sbirlea-Pointers,%20Alias%20and%20ModRef%20Analyses.pdf page 15, which says that replacement with null ptr is safe. So I did two runs, one where we do pointer replacement only when they have same underlying objects, and the another where we also replace pointers with null.
Feb 7 2023
Feb 2 2023
Feb 1 2023
Jan 28 2023
Jan 27 2023
Add the new warning to a group to fix clang test failure.
- Address comments.
- Fix formatting for some old code as well.
- Update commit message.
Jan 26 2023
Jan 25 2023
ping
Jan 23 2023
Jan 21 2023
Jan 18 2023
- Use fewer barriers and existing acquire/release instruction sequence.
- Add a shouldInsertTrailingFenceForAtomicStore() function.
Jan 17 2023
Jan 13 2023
Dec 2 2022
Dec 1 2022
- Address comments.
- Add fc1 tests.