Update to use the same triple as MEMTAG

• Update tests
• Check for TargetTriple.supportsCOMDAT() and use the any comdat by default

In D127455#3573920, @rnk wrote:

Does the MLIR LLVM dialect not have comdats? That seems like a missing feature, a lack of fidelity that would prevent lossless conversion from LLVM IR to MLIR & back. Clang uses comdat groups for some esoteric features, the D5 destructor alias group, and MSVC RTTI.

Seeing this cmake error for ARM32 after this patch.

Seeing a crash after this. Created a bug report here: https://github.com/llvm/llvm-project/issues/53781

In D112675#3093663

I'm still not clear if the FMF propagation is behaving as well as it could. For example, if the select has nsz, then can it always be added to the fneg?
https://alive2.llvm.org/ce/z/2Qq6Pz

In D112509#3090349, @spatel wrote:

This seems ok, but I'm having a hard time keeping all of the variations straight (predicates, fsub vs fneg, FMF propagation).

Can you make a patch for just the first code block (that's 4 variations by itself?) and include Alive2 links to show it agrees?

precommitted the tests and some cleanup as suggested

Added more tests as per comments.

I was looking at the LICM Fdiv hoisting issue when I came across this patch but this seems to be stuck.

In D109807#3008300, @spatel wrote:

I think I looked at this as a problem for -reassociate a long time ago. It makes changes on larger patterns like:
https://alive2.llvm.org/ce/z/UD56tJ
...but misses the shorter sequences.

(and this patch would not help match that example in -instcombine alone IIUC)

I think this patch also misses cases where we have a logic op with a wide constant:
https://alive2.llvm.org/ce/z/Ls8hXZ

Do you plan to extend it to deal with those patterns too?

remove base instruction's check for one use

rebase on precommited tests

Use SVEAllActive

Address comments.

Address comments, handle cases where either side of the binary op is a splat and the other is a reverse.

dup.x is now canonicalized to IR splat so reverse shouldn't be an issue now.
Reverses of ptrue can still be optimized, will get back to it when I get time.

• - Make flto an alias of flto=full.
• - Make foffload-lto an alias of foffload-lto=full.
• - Make flto_EQ_jobserver, flto_EQ_auto aliases of flto=full, since they are being treated as full lto right now.
• - Clean up the code for parseLTOMode and setLTOMode.
• - Replace uses of OPT_flto with OPT_flto_EQ.

In D108881#2973735, @steven_wu wrote:

In D108881#2973719, @mnadeem wrote:

In D108881#2973516, @steven_wu wrote:

I will do a cleanup of parseLTOMode function since we don't need a OptPos parameter anymore. There are few minor places references OPT_flto or OPT_foffload_lto can be cleaned up too.

Will you incorporate the functional changes in this patch? Or is there still a need for this change?

The current change set in this review is functional change while the cleanup I want is not functional after the rewrite the old option as Alias. Once flto is the alias, there is no need to handle that in the driver and those might actually become source of bug in the future.

I think it would be good to do the cleanup in the same commit unless you have compelling reason not to.

Updated acle tests and added an explicit test.

In D108881#2973516, @steven_wu wrote:

I will do a cleanup of parseLTOMode function since we don't need a OptPos parameter anymore. There are few minor places references OPT_flto or OPT_foffload_lto can be cleaned up too.

Update Options.td as suggested by steven_wu

Combined with the code in else if (Triple.isAMDGPU()) since the code is identical.
Removed the code to add -flto in favour of -flto=full since both are equivalent: https://clang.llvm.org/docs/CommandGuide/clang.html#cmdoption-flto