This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Vector] NFC - Reorganize vector patterns
ClosedPublic

Authored by nicolasvasilache on Mar 23 2023, 9:52 AM.

Details

Summary

Vector dialect patterns have grown enormously in the past year to a point where they are now impenetrable.
Start reorganizing them towards finer-grained control.

Diff Detail

Event Timeline

Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
nicolasvasilache requested review of this revision.Mar 23 2023, 9:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 9:52 AM
nicolasvasilache planned changes to this revision.Mar 23 2023, 10:12 AM
This revision is now accepted and ready to land.Mar 23 2023, 11:02 AM
nicolasvasilache requested review of this revision.Mar 23 2023, 11:03 AM
ThomasRaoux accepted this revision.Mar 23 2023, 11:17 AM

The re-oragnization looks good to me. I assume no changes in the patterns so I haven't looked into them.

This revision is now accepted and ready to land.Mar 23 2023, 11:17 AM

The re-oragnization looks good to me. I assume no changes in the patterns so I haven't looked into them.

Thanks! indeed no change to the patterns (see the yellow bar on the left that shows code moving).

Bazel build fixes

This revision was landed with ongoing or failed builds.Mar 23 2023, 11:30 AM
This revision was automatically updated to reflect the committed changes.