This is an archive of the discontinued LLVM Phabricator instance.

Differential D146038

[AMDGPU] Don't run `llc-pipeline.ll` when expensive_checks are enabled
ClosedPublic

Authored by Pierre-vh on Mar 14 2023, 5:49 AM.

Details

Reviewers
arsenm
Commits
rG0ea6f0e15878: [AMDGPU] Don't run `llc-pipeline.ll` when expensive_checks are enabled
Summary

AMDGPU ISel can add extra passes when expensive checks are enabled. This means the pipeline can be reordered and the checks may fail.

Diff Detail

Event Timeline

Pierre-vh created this revision.Mar 14 2023, 5:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2023, 5:49 AM
Herald added subscribers: kosarev, kerbowa, tpr and 4 others. · View Herald Transcript
Pierre-vh requested review of this revision.Mar 14 2023, 5:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2023, 5:49 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
arsenm accepted this revision.Mar 14 2023, 6:06 AM
This revision is now accepted and ready to land.Mar 14 2023, 6:06 AM
This revision was landed with ongoing or failed builds.Mar 14 2023, 6:12 AM
Closed by commit rG0ea6f0e15878: [AMDGPU] Don't run `llc-pipeline.ll` when expensive_checks are enabled (authored by Pierre-vh). · Explain Why
This revision was automatically updated to reflect the committed changes.
Pierre-vh added a commit: rG0ea6f0e15878: [AMDGPU] Don't run `llc-pipeline.ll` when expensive_checks are enabled.
Harbormaster completed remote builds in B219326: Diff 505058.Mar 14 2023, 7:29 AM

Revision Contents

PathSize
llvm/
test/
CodeGen/
AMDGPU/
13 lines

Diff 505069

llvm/test/CodeGen/AMDGPU/llc-pipeline.ll

; When EXPENSIVE_CHECKS are enabled, the machine verifier appears between each ; UNSUPPORTED: expensive_checks
; pass. Ignore it with 'grep -v'.
; RUN: llc -O0 -mtriple=amdgcn--amdhsa -disable-verify -debug-pass=Structure < %s 2>&1 \ ; RUN: llc -O0 -mtriple=amdgcn--amdhsa -disable-verify -debug-pass=Structure < %s 2>&1 \
; RUN: | grep -v 'Verify generated machine code' | FileCheck -match-full-lines -strict-whitespace -check-prefix=GCN-O0 %s ; RUN: | FileCheck -match-full-lines -strict-whitespace -check-prefix=GCN-O0 %s
; RUN: llc -O1 -mtriple=amdgcn--amdhsa -disable-verify -debug-pass=Structure < %s 2>&1 \ ; RUN: llc -O1 -mtriple=amdgcn--amdhsa -disable-verify -debug-pass=Structure < %s 2>&1 \
; RUN: | grep -v 'Verify generated machine code' | FileCheck -match-full-lines -strict-whitespace -check-prefix=GCN-O1 %s ; RUN: | FileCheck -match-full-lines -strict-whitespace -check-prefix=GCN-O1 %s
; RUN: llc -O1 -mtriple=amdgcn--amdhsa -disable-verify -amdgpu-scalar-ir-passes -amdgpu-sdwa-peephole \ ; RUN: llc -O1 -mtriple=amdgcn--amdhsa -disable-verify -amdgpu-scalar-ir-passes -amdgpu-sdwa-peephole \
; RUN: -amdgpu-load-store-vectorizer -amdgpu-enable-pre-ra-optimizations -debug-pass=Structure < %s 2>&1 \ ; RUN: -amdgpu-load-store-vectorizer -amdgpu-enable-pre-ra-optimizations -debug-pass=Structure < %s 2>&1 \
; RUN: | grep -v 'Verify generated machine code' | FileCheck -match-full-lines -strict-whitespace -check-prefix=GCN-O1-OPTS %s ; RUN: | FileCheck -match-full-lines -strict-whitespace -check-prefix=GCN-O1-OPTS %s
; RUN: llc -O2 -mtriple=amdgcn--amdhsa -disable-verify -debug-pass=Structure < %s 2>&1 \ ; RUN: llc -O2 -mtriple=amdgcn--amdhsa -disable-verify -debug-pass=Structure < %s 2>&1 \
; RUN: | grep -v 'Verify generated machine code' | FileCheck -match-full-lines -strict-whitespace -check-prefix=GCN-O2 %s ; RUN: | FileCheck -match-full-lines -strict-whitespace -check-prefix=GCN-O2 %s
; RUN: llc -O3 -mtriple=amdgcn--amdhsa -disable-verify -debug-pass=Structure < %s 2>&1 \ ; RUN: llc -O3 -mtriple=amdgcn--amdhsa -disable-verify -debug-pass=Structure < %s 2>&1 \
; RUN: | grep -v 'Verify generated machine code' | FileCheck -match-full-lines -strict-whitespace -check-prefix=GCN-O3 %s ; RUN: | FileCheck -match-full-lines -strict-whitespace -check-prefix=GCN-O3 %s
; REQUIRES: asserts ; REQUIRES: asserts
; GCN-O0:Target Library Information ; GCN-O0:Target Library Information
; GCN-O0-NEXT:Target Pass Configuration ; GCN-O0-NEXT:Target Pass Configuration
; GCN-O0-NEXT:Machine Module Information ; GCN-O0-NEXT:Machine Module Information
; GCN-O0-NEXT:Target Transform Information ; GCN-O0-NEXT:Target Transform Information
; GCN-O0-NEXT:Assumption Cache Tracker ; GCN-O0-NEXT:Assumption Cache Tracker
▲ Show 20 Lines • Show All 1,351 Lines • Show Last 20 Lines