This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Update mul.ll with auto-generated checks
ClosedPublic

Authored by kmitropoulou on Mar 13 2023, 2:59 PM.

Diff Detail

Event Timeline

kmitropoulou created this revision.Mar 13 2023, 2:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 2:59 PM
kmitropoulou requested review of this revision.Mar 13 2023, 2:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 2:59 PM

Updating D145990: [AMDGPU] Update mul.ll with auto-generated checks

foad added a comment.Mar 14 2023, 2:57 AM

Looks good with nits.

llvm/test/CodeGen/AMDGPU/mul.ll
4

If the checks are not shared between different RUN lines then there is no reason to call them "GFX*PLUS". Just call them GFX9 and GFX10.

72–73

Keep this comment.

kmitropoulou marked 2 inline comments as done.

Updating D145990: [AMDGPU] Update mul.ll with auto-generated checks

foad accepted this revision.Mar 15 2023, 3:47 AM

Thanks!

This revision is now accepted and ready to land.Mar 15 2023, 3:47 AM

Updating D145990: [AMDGPU] Update mul.ll with auto-generated checks

This revision was landed with ongoing or failed builds.Mar 15 2023, 8:17 AM
This revision was automatically updated to reflect the committed changes.