This is an archive of the discontinued LLVM Phabricator instance.

Differential D145979

[RISC-V] Add test case for -fsanitize=shadow-call-stack
AbandonedPublic

Authored by hiraditya on Mar 13 2023, 12:34 PM.

Details

Reviewers
samitolvanen
vitalybuka
asb

Diff Detail

Event Timeline

hiraditya created this revision.Mar 13 2023, 12:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 12:34 PM
Herald added subscribers: VincentWu, vkmr, luismarques and 8 others. · View Herald Transcript
hiraditya requested review of this revision.Mar 13 2023, 12:34 PM
Herald added a subscriber: • pcwang-thead. · View Herald TranscriptMar 13 2023, 12:34 PM
hiraditya added a reviewer: asb.Mar 13 2023, 12:35 PM
samitolvanen added a comment.Mar 13 2023, 1:28 PM

Is this related to coverage? If not, should the test go to sanitizer-ld.c instead?

Harbormaster completed remote builds in B219141: Diff 504804.Mar 13 2023, 4:10 PM
hiraditya updated this revision to Diff 504881.Mar 13 2023, 4:13 PM

Moved the testcase as suggested by @samitolvanen

samitolvanen added inline comments.Mar 13 2023, 4:48 PM
clang/test/Driver/sanitizer-ld.c
746 ↗(On Diff #504881)

-ffixed-x18 isn't needed after D145999. Can you drop the flag and land that patch first?

747 ↗(On Diff #504881)

Perhaps CHECK-SHADOWCALLSTACK-ANDROID-RISCV64 to match the naming convention in the file?

748 ↗(On Diff #504881)

Should we also check for -NOT: error: like the Fuchsia test below?

samitolvanen mentioned this in D145999: [RISCV] Reserve X18 by default for Android.Mar 13 2023, 4:49 PM
Harbormaster completed remote builds in B219200: Diff 504881.Mar 13 2023, 6:03 PM
hiraditya abandoned this revision.Mar 14 2023, 9:58 PM

I'll fold this to D145999.

Revision Contents

PathSize
clang/
test/
Driver/
3 lines

Diff 504804

clang/test/Driver/fsanitize-coverage.c

Show All 12 Lines
// CHECK-NO-SAFESTACK-NOT: unknown argument // CHECK-NO-SAFESTACK-NOT: unknown argument
// CHECK-NO-SAFESTACK-NOT: -fsanitize=safe-stack // CHECK-NO-SAFESTACK-NOT: -fsanitize=safe-stack
// CHECK-NO-SAFESTACK: -fsanitize-coverage-trace-pc-guard // CHECK-NO-SAFESTACK: -fsanitize-coverage-trace-pc-guard
// RUN: %clang -target x86_64-linux-gnu -fsanitize=shadow-call-stack -fsanitize-coverage=trace-pc-guard %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VS-SHADOWCALLSTACK // RUN: %clang -target x86_64-linux-gnu -fsanitize=shadow-call-stack -fsanitize-coverage=trace-pc-guard %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VS-SHADOWCALLSTACK
// CHECK-VS-SHADOWCALLSTACK: -fsanitize-coverage-trace-pc-guard // CHECK-VS-SHADOWCALLSTACK: -fsanitize-coverage-trace-pc-guard
// CHECK-VS-SHADOWCALLSTACK: -fsanitize=shadow-call-stack // CHECK-VS-SHADOWCALLSTACK: -fsanitize=shadow-call-stack
// RUN: %clang -target riscv64-linux-android -fsanitize=shadow-call-stack -ffixed-x18 %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-RV64-SHADOWCALLSTACK
// CHECK-RV64-SHADOWCALLSTACK: "-target-feature" "+reserve-x18"
// RUN: %clang -target x86_64-linux-gnu -fsanitize=shadow-call-stack -fsanitize-coverage=trace-pc-guard -fno-sanitize=shadow-call-stack %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-NO-SAFESTACK // RUN: %clang -target x86_64-linux-gnu -fsanitize=shadow-call-stack -fsanitize-coverage=trace-pc-guard -fno-sanitize=shadow-call-stack %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-NO-SAFESTACK
// CHECK-NO-SHADOWCALLSTACK-NOT: error: // CHECK-NO-SHADOWCALLSTACK-NOT: error:
// CHECK-NO-SHADOWCALLSTACK-NOT: warning: // CHECK-NO-SHADOWCALLSTACK-NOT: warning:
// CHECK-NO-SHADOWCALLSTACK-NOT: argument unused // CHECK-NO-SHADOWCALLSTACK-NOT: argument unused
// CHECK-NO-SHADOWCALLSTACK-NOT: unknown argument // CHECK-NO-SHADOWCALLSTACK-NOT: unknown argument
// CHECK-NO-SHADOWCALLSTACK-NOT: -fsanitize=shadow-call-stack // CHECK-NO-SHADOWCALLSTACK-NOT: -fsanitize=shadow-call-stack
// CHECK-NO-SHADOWCALLSTACK: -fsanitize-coverage-trace-pc-guard // CHECK-NO-SHADOWCALLSTACK: -fsanitize-coverage-trace-pc-guard
Context not available.