Page MenuHomePhabricator

samitolvanen (Sami Tolvanen)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 17 2020, 10:04 AM (125 w, 1 d)

Recent Activity

Thu, Jul 28

samitolvanen added a comment to D119296: KCFI sanitizer.

Some minor suggestions/not so relevant:

  • Change the name of CFIType to CFIHash, as it is probably more descriptive.
Thu, Jul 28, 3:13 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.
  • Ensured that we don't emit ENDBR64/32 as the type hash on X86.
Thu, Jul 28, 3:13 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 25

samitolvanen added a comment to D119296: KCFI sanitizer.

It seems that we can miss the branch to have more time mature the feature and have it for 16.0.

Mon, Jul 25, 2:37 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the summary of D119296: KCFI sanitizer.
Mon, Jul 25, 2:37 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.

Addressed conflicts with X86 retbleed mitigations (https://lore.kernel.org/lkml/20220716230344.239749011@linutronix.de/):

Mon, Jul 25, 2:36 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Jul 22

samitolvanen planned changes to D119296: KCFI sanitizer.

Based on the recent LKML discussions about X86 retbleed mitigations (https://lore.kernel.org/lkml/20220716230344.239749011@linutronix.de/), we're going to need some changes to the code generated for X86.

Fri, Jul 22, 4:12 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 18

samitolvanen updated the diff for D119296: KCFI sanitizer.
  • Simplified AArch64 by dropping the KCFI_CHECK_BTI pseudo and just using a different caller-saved temporary register if needed.
  • Added -verify-machineinstrs to llc tests.
Mon, Jul 18, 8:43 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jul 13

samitolvanen added inline comments to D119296: KCFI sanitizer.
Wed, Jul 13, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.

Addressed Fangrui's feedback.

Wed, Jul 13, 12:48 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 12

samitolvanen updated the diff for D119296: KCFI sanitizer.
  • Added a missing equivalency check to MachineInstr.
Tue, Jul 12, 11:19 AM · Restricted Project, Restricted Project, Restricted Project

Jul 7 2022

samitolvanen added inline comments to D119296: KCFI sanitizer.
Jul 7 2022, 12:46 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.

Addressed the rest of Fangrui's comments after clarifying the open questions with him offline.

Jul 7 2022, 12:05 PM · Restricted Project, Restricted Project, Restricted Project

Jul 6 2022

samitolvanen added a comment to D119296: KCFI sanitizer.

It uses LLVM prefix data to store a type identifier for each function and injects verification code before indirect calls.

Is "prefix data" stale now?

Jul 6 2022, 11:26 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.

Addressed Fangrui's feedback.

Jul 6 2022, 11:26 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the summary of D119296: KCFI sanitizer.
Jul 6 2022, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Jun 30 2022

samitolvanen added a comment to D119296: KCFI sanitizer.

I see you modified the mir parser & printer; consider adding a .mir test.

Jun 30 2022, 4:08 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.

Added a MIR parser test for cfi-type, address Nick's other feedback.

Jun 30 2022, 4:07 PM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2022

samitolvanen added inline comments to D119296: KCFI sanitizer.
Jun 27 2022, 2:10 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.
  • Moved to a standalone function for generating KCFI type hashes in Clang.
  • Switched from pseudo instructions to a MachineInstr::ExtraInfo + SDNode attributes.
  • Added KCFI passes for emitting the indirect call checks.
Jun 27 2022, 2:10 PM · Restricted Project, Restricted Project, Restricted Project

Jun 24 2022

samitolvanen planned changes to D119296: KCFI sanitizer.
Jun 24 2022, 10:45 AM · Restricted Project, Restricted Project, Restricted Project

Jun 22 2022

samitolvanen updated the diff for D119296: KCFI sanitizer.

Fixed the debug output in InstCombine to use metadata as well.

Jun 22 2022, 1:00 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.

Switched from prefix data + attribute to a metadata node based on previous discussion. This seems to be a cleaner solution overall.

Jun 22 2022, 11:05 AM · Restricted Project, Restricted Project, Restricted Project

Jun 17 2022

samitolvanen updated the diff for D119296: KCFI sanitizer.

Rebased after ToT member function name changes.

Jun 17 2022, 12:43 PM · Restricted Project, Restricted Project, Restricted Project

Jun 10 2022

samitolvanen added inline comments to D119296: KCFI sanitizer.
Jun 10 2022, 9:18 AM · Restricted Project, Restricted Project, Restricted Project

Jun 9 2022

samitolvanen updated the summary of D119296: KCFI sanitizer.
Jun 9 2022, 2:22 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.
  • Per Fangrui's request, added comments explaining the X86 preamble format, and a note about it to the patch summary.
  • Switched back to .weak for the __kcfi_typeid_ symbols to fix compatibility with LTO. Whether we need a warning for symbol value mismatches and how this should be implemented can be addressed later. The warning isn't critical for the functionality and mismatches should be extremely rare.
Jun 9 2022, 2:21 PM · Restricted Project, Restricted Project, Restricted Project

Jun 7 2022

samitolvanen added a comment to D119296: KCFI sanitizer.

ELF linkers don't error for two SHN_ABS STB_GLOBAL symbols of the same st_value.
When the st_value fields differ, there will be a diagnostic. If needed, the specialized diagnostic can be added there.

Jun 7 2022, 4:22 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the summary of D119296: KCFI sanitizer.
Jun 7 2022, 3:36 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added inline comments to D119296: KCFI sanitizer.
Jun 7 2022, 3:35 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.
  • Addressed Fangrui's feedback.
  • Renamed KCFI_* DAG nodes and pseudo instructions to CFI_* for now based on Joao's feedback. Still looking for more feedback on the best way to implement this part.
Jun 7 2022, 3:35 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a comment to D119296: KCFI sanitizer.

a) Naming

About the 'k' prefix: this is generic and does not need to be coupled with "kernel",
but perhaps an argument can be made that the 'k' does not need to refer to "kernel".

Jun 7 2022, 9:43 AM · Restricted Project, Restricted Project, Restricted Project

Jun 2 2022

samitolvanen added inline comments to D119296: KCFI sanitizer.
Jun 2 2022, 3:59 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added inline comments to D119296: KCFI sanitizer.
Jun 2 2022, 2:17 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added inline comments to D119296: KCFI sanitizer.
Jun 2 2022, 11:22 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added inline comments to D119296: KCFI sanitizer.
Jun 2 2022, 10:56 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the summary of D119296: KCFI sanitizer.
Jun 2 2022, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.
  • Changed Clang to emit operand bundles for indirect calls as pcc suggested, and dropped the llvm.kcfi.check intrinsic.
  • Based on further LKML discussion, implemented arch-specific lowering that ensures the KCFI check can be placed immediately before the call instruction on X86.
  • Switched to relative offsets in .kcfi_traps and fixed the __cfi_ preamble linkage on X86.
Jun 2 2022, 10:42 AM · Restricted Project, Restricted Project, Restricted Project

May 10 2022

samitolvanen updated the diff for D119296: KCFI sanitizer.

Added a test for the Clang -O2 pipeline dropping unneeded checks.

May 10 2022, 3:38 PM · Restricted Project, Restricted Project, Restricted Project

May 9 2022

samitolvanen updated the diff for D119296: KCFI sanitizer.
  • Handle FP, LR, and XZR register arguments in the AArch64 llvm.kcfi.check lowering.
May 9 2022, 3:00 PM · Restricted Project, Restricted Project, Restricted Project

May 6 2022

samitolvanen updated the summary of D119296: KCFI sanitizer.
May 6 2022, 3:10 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.

Based on LKML feedback:

  • Fixed a bug in Twine usage.
  • Changed AArch64 to encode register information into the ESR and dropped .kcfi_traps generation for the arch.
  • Changed X86 to generate valid instructions for the type data.
  • Dropped the .kcfi_types section entirely.
May 6 2022, 3:02 PM · Restricted Project, Restricted Project, Restricted Project

May 3 2022

samitolvanen abandoned D124211: Add __builtin_kcfi_call_unchecked.

OK, I confirmed that we won't need this after all. I'll abandon this patch and revisit if it becomes necessary in future.

May 3 2022, 10:34 AM · Restricted Project, Restricted Project

Apr 29 2022

samitolvanen added a comment to D124211: Add __builtin_kcfi_call_unchecked.

LKML RFC: https://lore.kernel.org/lkml/20220429203644.2868448-1-samitolvanen@google.com/

Apr 29 2022, 1:40 PM · Restricted Project, Restricted Project
samitolvanen retitled D124211: Add __builtin_kcfi_call_unchecked from Add __builtin_call_kcfi_unchecked to Add __builtin_kcfi_call_unchecked.
Apr 29 2022, 10:55 AM · Restricted Project, Restricted Project
samitolvanen updated the diff for D124211: Add __builtin_kcfi_call_unchecked.
  • Renamed the builtin.
  • Addressed Nick's comments.
Apr 29 2022, 10:53 AM · Restricted Project, Restricted Project

Apr 28 2022

samitolvanen added a comment to D119296: KCFI sanitizer.

At first I was on the boat of KCFI being implemented in the IR level because being architecture agnostic is certainly a great plus.

Apr 28 2022, 6:49 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a comment to D119296: KCFI sanitizer.

Yes, I suspect this might be an issue with Clang's existing CFI schemes too, and would probably require an additional pass to drop checks before calls that were either inlined or optimized into direct calls.

IIRC, this wasn't really an issue for -fsanitize=cfi because 99% of the time indirect calls that were going to resolve to direct calls had already done so by the time we got to the LowerTypeTests pass (which was only run during LTO).

Apr 28 2022, 6:36 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.
  • Moved the KCFI pass to InstCombine
Apr 28 2022, 6:35 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a comment to D124211: Add __builtin_kcfi_call_unchecked.

Perhaps it's time to start a discussion on LKML then, before landing this?

Apr 28 2022, 4:46 PM · Restricted Project, Restricted Project
samitolvanen added a comment to D124211: Add __builtin_kcfi_call_unchecked.

Can you link to the lore thread on discussions around the builtin?

Apr 28 2022, 11:33 AM · Restricted Project, Restricted Project

Apr 27 2022

samitolvanen updated the diff for D119296: KCFI sanitizer.
  • Added an LLVM pass to remove unneeded llvm.kcfi.check calls.
  • Switched from zeros to 0xcc for x86 type identifier padding.
Apr 27 2022, 4:35 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a comment to D119296: KCFI sanitizer.

Oh, one other tiny detail I forgot to mention. I noticed that the tag is pushing the functions 6 bytes forward, regardless of any prepending padding nops that were added to ensure 16b alignment. It would be cool to care about the proper function alignment and also to not emit dummy padding nops when the padding area can be filled with the tag itself.

Apr 27 2022, 4:23 PM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2022

samitolvanen added a comment to D119296: KCFI sanitizer.

I played a little bit with kcfi and here are some thoughts:

  • under -Os I saw functions being inlined, regardless of the source code calling them indirectly. In these scenarios, the KCFI check was still in place, even though there was not a pointer involved in the call. Although not semantically incorrect, it would be great to prevent the unnecessary overhead (see attached source/compile it with -Os and -fsanitize=kcfi).
Apr 22 2022, 9:17 AM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

samitolvanen requested review of D124211: Add __builtin_kcfi_call_unchecked.
Apr 21 2022, 3:49 PM · Restricted Project, Restricted Project

Apr 20 2022

samitolvanen added inline comments to D119296: KCFI sanitizer.
Apr 20 2022, 3:14 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added inline comments to D119296: KCFI sanitizer.
Apr 20 2022, 2:37 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added inline comments to D119296: KCFI sanitizer.
Apr 20 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.

Addressed another round of comments.

Apr 20 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2022

samitolvanen updated the summary of D119296: KCFI sanitizer.
Apr 19 2022, 3:28 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a comment to D119296: KCFI sanitizer.

Please add a test where calls to @llvm.kcfi.check produce KCFI_CHECK during instruction selection. (You can use -stop-before=finalize-isel to dump the IR prior to isel; this can stay a .ll test, I think, rather than .mir).

Apr 19 2022, 3:27 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.

Addressed Nick's comments.

Apr 19 2022, 3:27 PM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2022

samitolvanen updated the diff for D119296: KCFI sanitizer.

Dropped -fsanitize-kcfi-offset and added an error when used with -fpatchable-function-entry=N,M, where M > 0.

Apr 13 2022, 4:15 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen abandoned D122673: Add kcfi_unchecked attribute.

Alright, thanks for the feedback everyone! I'll abandon this patch and look into adding a built-in function instead.

Apr 13 2022, 11:38 AM · Restricted Project, Restricted Project

Apr 11 2022

samitolvanen added a comment to D122673: Add kcfi_unchecked attribute.

I tend to be very wary of modifying the type system with attributes -- questions always arise of what the type system effects are of the attribute. e.g., does it impact overload sets or template specialization? Name mangling? If it doesn't have type system impacts... why does it need to be in the type system at all? This also matters because adding more bits to types can have unintended side effects like accidentally reducing the depth of template instantiations we can process (because of the extra memory pressure). So while I'm not certain what you and @pcc talked about, it does seem like an approach at least worth thinking about, especially because this patch needs to bump the size of Type.

Apr 11 2022, 12:05 PM · Restricted Project, Restricted Project

Apr 7 2022

samitolvanen added a comment to D119296: KCFI sanitizer.

Note that if additional data has been injected between the KCFI
type identifier and the start of the function, e.g. by using
-fpatchable-function-entry, the offset in bytes must be specified
using -fsanitize-kcfi-offset=<value> to avoid errors. The offset
must be the same for all indirectly called functions in every
translation unit.

On x86 the specific constant 6 is necessary to ensure that the constant embedded in the cmpl operand can't be used as a gadget. So any value other than 6 will potentially impact the security of KCFI.

I would prefer not to design an interaction between -fpatchable-function-entry and KCFI until the specific use case is known.

Apr 7 2022, 5:28 PM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

samitolvanen added a comment to D122673: Add kcfi_unchecked attribute.

Note that this was split from D119296.

Mar 29 2022, 11:21 AM · Restricted Project, Restricted Project
samitolvanen requested review of D122673: Add kcfi_unchecked attribute.
Mar 29 2022, 11:15 AM · Restricted Project, Restricted Project
samitolvanen updated the summary of D119296: KCFI sanitizer.
Mar 29 2022, 11:14 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a reviewer for D119296: KCFI sanitizer: joaomoreira.
Mar 29 2022, 11:13 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D119296: KCFI sanitizer.
  • Split the kcfi_unchecked attribute into a separate patch.
  • Based on feedback from kernel developers, switched to 32-bit type identifiers, added the llvm.kcfi.check intrinsic with arch-specific lowering, and added sections for locating both type identifiers and traps.
  • Addressed the remaining review comments.
Mar 29 2022, 11:12 AM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2022

samitolvanen planned changes to D119296: KCFI sanitizer.

Thanks for the pointers, Aaron. I'll rework the attribute code and also address the issues Nick pointed out in the next revision.

Feb 9 2022, 11:51 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added inline comments to D119296: KCFI sanitizer.
Feb 9 2022, 11:49 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added inline comments to D119296: KCFI sanitizer.
Feb 9 2022, 11:45 AM · Restricted Project, Restricted Project, Restricted Project

Feb 8 2022

samitolvanen added reviewers for D119296: KCFI sanitizer: pcc, nickdesaulniers, ardb, kees.
Feb 8 2022, 3:31 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen requested review of D119296: KCFI sanitizer.
Feb 8 2022, 3:30 PM · Restricted Project, Restricted Project, Restricted Project

Dec 20 2021

samitolvanen committed rGec2e26eaf635: [Clang] Add __builtin_function_start (authored by samitolvanen).
[Clang] Add __builtin_function_start
Dec 20 2021, 1:11 PM
samitolvanen committed rG5dc8aaac39c5: [llvm][IR] Add no_cfi constant (authored by samitolvanen).
[llvm][IR] Add no_cfi constant
Dec 20 2021, 1:11 PM
samitolvanen closed D108479: [Clang] Add __builtin_addressof_nocfi.
Dec 20 2021, 1:11 PM · Restricted Project
samitolvanen closed D108478: [llvm][IR] Add no_cfi constant.
Dec 20 2021, 1:11 PM · Restricted Project

Dec 10 2021

samitolvanen updated the diff for D108478: [llvm][IR] Add no_cfi constant.

Addressed Nick's comments about NoCFIValue::handleOperandChangeImpl.

Dec 10 2021, 4:21 PM · Restricted Project
samitolvanen abandoned D112761: cfi-icall: Add -fsanitize-cfi-promotion-aliases.

See https://reviews.llvm.org/D113613.

Dec 10 2021, 12:36 PM · Restricted Project, Restricted Project
samitolvanen committed rG9a74c753fe3f: [ThinLTO][MC] Use conditional assignments for promotion aliases (authored by samitolvanen).
[ThinLTO][MC] Use conditional assignments for promotion aliases
Dec 10 2021, 12:34 PM
samitolvanen closed D113613: [ThinLTO][MC] Use conditional assignments for promotion aliases.
Dec 10 2021, 12:33 PM · Restricted Project
samitolvanen updated the diff for D113613: [ThinLTO][MC] Use conditional assignments for promotion aliases.

Applied pcc's changes.

Dec 10 2021, 9:07 AM · Restricted Project

Dec 9 2021

samitolvanen updated the diff for D113613: [ThinLTO][MC] Use conditional assignments for promotion aliases.

Based on more offline feedback from pcc, moved the conditional assignment handling from MCStreamer to MCObjectStreamer. This allows us to drop the emittedSymbols set as MCAssembler already keeps track of the symbols. As MCAsmStreamer now passes through the .lto_set_conditional directives, changed the tests to look at the generated objects instead.

Dec 9 2021, 3:23 PM · Restricted Project

Dec 3 2021

samitolvanen updated the diff for D113613: [ThinLTO][MC] Use conditional assignments for promotion aliases.

Changed the key of the pendingAssignments map to const MCSymbol * and switched from StringMap/Set to DenseMap/Set based on feedback from pcc.

Dec 3 2021, 6:35 PM · Restricted Project

Dec 1 2021

samitolvanen updated the diff for D108479: [Clang] Add __builtin_addressof_nocfi.

Addressed comments.

Dec 1 2021, 4:05 PM · Restricted Project

Nov 29 2021

samitolvanen updated the diff for D108479: [Clang] Add __builtin_addressof_nocfi.

Use standard l-value conversions, and add a test case for constexpr.

Nov 29 2021, 4:23 PM · Restricted Project

Nov 24 2021

samitolvanen planned changes to D108479: [Clang] Add __builtin_addressof_nocfi.

Your builtin is using custom type-checking (t), which suppresses all the normal conversions that happen on expressions. Specifically, it skips lvalue-to-rvalue conversion, so in this example the argument ends up being an l-value reference to a variable rather than an r-value loaded from that variable.

Nov 24 2021, 10:07 AM · Restricted Project

Nov 23 2021

samitolvanen added inline comments to D108479: [Clang] Add __builtin_addressof_nocfi.
Nov 23 2021, 3:54 PM · Restricted Project
samitolvanen updated the diff for D108479: [Clang] Add __builtin_addressof_nocfi.

Changed the code to evaluate the argument as a constant expression.

Nov 23 2021, 3:54 PM · Restricted Project
samitolvanen planned changes to D108479: [Clang] Add __builtin_addressof_nocfi.

I worked around this for now by explicitly allowing __builtin_function_start in CheckLValueConstantExpression, but this seems terribly hacky. What would be the correct way to solve this issue?

Try to generalize what we do for __builtin___CFStringMakeConstantString.

Nov 23 2021, 10:33 AM · Restricted Project
samitolvanen added a comment to D108479: [Clang] Add __builtin_addressof_nocfi.

Sure, I can take a look at how that would work. Basically, in PointerExprEvaluator::VisitBuiltinCallExpr we should not evaluate the l-value and just leave it at Result.set(E)?

Yes, exactly. Since the builtin already requires a constant operand in non-dependent contexts, that should be enough.

Nov 23 2021, 9:51 AM · Restricted Project
samitolvanen updated the diff for D108479: [Clang] Add __builtin_addressof_nocfi.

Refactored to avoid evaluating the expression into an l-value.

Nov 23 2021, 9:51 AM · Restricted Project

Nov 19 2021

samitolvanen updated the diff for D113613: [ThinLTO][MC] Use conditional assignments for promotion aliases.

Renamed to .lto_set_conditional.

Nov 19 2021, 11:50 AM · Restricted Project
samitolvanen added inline comments to D113613: [ThinLTO][MC] Use conditional assignments for promotion aliases.
Nov 19 2021, 8:54 AM · Restricted Project
samitolvanen updated the diff for D113613: [ThinLTO][MC] Use conditional assignments for promotion aliases.

Updated tests to use # and reordered the CHECKs for clarity.

Nov 19 2021, 8:52 AM · Restricted Project

Nov 18 2021

samitolvanen planned changes to D108479: [Clang] Add __builtin_addressof_nocfi.

If we do need to support constant expressions of this

Yes, we need this also in constant expressions.

Okay. I assume just static initializers, and not things like template arguments?

Nov 18 2021, 12:50 PM · Restricted Project
samitolvanen updated the diff for D108478: [llvm][IR] Add no_cfi constant.

Rebased.

Nov 18 2021, 9:55 AM · Restricted Project
samitolvanen added a comment to D108479: [Clang] Add __builtin_addressof_nocfi.

If we do need to support constant expressions of this

Nov 18 2021, 9:52 AM · Restricted Project