Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

samitolvanen (Sami Tolvanen)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 17 2020, 10:04 AM (184 w, 3 d)

Recent Activity

Jul 19 2023

samitolvanen added a comment to D155756: -fsanitize={function,kcfi}: Switch to xxh3_64bits.

Changing the hash function breaks compatibility with the Rust KCFI implementation. I would personally like to avoid changing how KCFI type hashes are computed unless there's a very compelling reason to switch away from xxHash64.

Jul 19 2023, 3:06 PM · Restricted Project, Restricted Project

Jul 7 2023

samitolvanen committed rG930635271f81: [Clang] Emit KCFI type hashes for member functions (authored by samitolvanen).
[Clang] Emit KCFI type hashes for member functions
Jul 7 2023, 9:51 AM · Restricted Project, Restricted Project

Jun 29 2023

samitolvanen accepted D154125: MachineFunction: -fsanitize={function,kcfi}: ensure 4-byte alignment.
Jun 29 2023, 3:20 PM · Restricted Project, Restricted Project
samitolvanen accepted D154125: MachineFunction: -fsanitize={function,kcfi}: ensure 4-byte alignment.

Thanks for fixing this! This approach looks good to me.

Jun 29 2023, 1:32 PM · Restricted Project, Restricted Project

Jun 23 2023

samitolvanen committed rG83835e22c7cd: [RISCV] Implement KCFI operand bundle lowering (authored by samitolvanen).
[RISCV] Implement KCFI operand bundle lowering
Jun 23 2023, 3:58 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a reverting change for rG62fa708ceb02: [RISCV] Implement KCFI operand bundle lowering: rGe809ebeb6c8b: Revert "[RISCV] Implement KCFI operand bundle lowering".
Jun 23 2023, 2:45 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen committed rGe809ebeb6c8b: Revert "[RISCV] Implement KCFI operand bundle lowering" (authored by samitolvanen).
Revert "[RISCV] Implement KCFI operand bundle lowering"
Jun 23 2023, 2:45 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a reverting change for D148385: [RISCV] Implement KCFI operand bundle lowering: rGe809ebeb6c8b: Revert "[RISCV] Implement KCFI operand bundle lowering".
Jun 23 2023, 2:44 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen committed rG62fa708ceb02: [RISCV] Implement KCFI operand bundle lowering (authored by samitolvanen).
[RISCV] Implement KCFI operand bundle lowering
Jun 23 2023, 11:41 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen closed D148385: [RISCV] Implement KCFI operand bundle lowering.
Jun 23 2023, 11:40 AM · Restricted Project, Restricted Project, Restricted Project

Jun 14 2023

samitolvanen accepted D152782: [CodeGen] Remove unused declaration/function GetOrCreateRTTIProxyGlobalVariable.
Jun 14 2023, 1:31 PM · Restricted Project, Restricted Project
samitolvanen added a comment to D148385: [RISCV] Implement KCFI operand bundle lowering.

Needs some thoughts to merge the above paragraphs with the existing one

Jun 14 2023, 1:17 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the summary of D148385: [RISCV] Implement KCFI operand bundle lowering.
Jun 14 2023, 1:17 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D148385: [RISCV] Implement KCFI operand bundle lowering.

Addressed feedback.

Jun 14 2023, 1:16 PM · Restricted Project, Restricted Project, Restricted Project

Jun 12 2023

samitolvanen committed rGce4bb083c043: [KCFI] Fix hash offset calculation in Thumb mode (authored by samitolvanen).
[KCFI] Fix hash offset calculation in Thumb mode
Jun 12 2023, 12:44 PM · Restricted Project, Restricted Project
samitolvanen closed D152484: [KCFI] Fix hash offset calculation in Thumb mode.
Jun 12 2023, 12:44 PM · Restricted Project, Restricted Project

Jun 8 2023

samitolvanen added reviewers for D152484: [KCFI] Fix hash offset calculation in Thumb mode: nickdesaulniers, MaskRay.
Jun 8 2023, 4:19 PM · Restricted Project, Restricted Project
samitolvanen requested review of D152484: [KCFI] Fix hash offset calculation in Thumb mode.
Jun 8 2023, 4:18 PM · Restricted Project, Restricted Project

Jun 6 2023

samitolvanen added a comment to D148385: [RISCV] Implement KCFI operand bundle lowering.

KCFI_CHECK lowering has some complexity to allocate a temporary register. This needs to follow the calling convention which can be modified by many compiler options and function attributes.

Jun 6 2023, 8:59 AM · Restricted Project, Restricted Project, Restricted Project

Jun 5 2023

samitolvanen committed rG5a64a826b9f0: [Driver] Allow -fsanitize=kcfi with -fsanitize-minimal-runtime (authored by samitolvanen).
[Driver] Allow -fsanitize=kcfi with -fsanitize-minimal-runtime
Jun 5 2023, 1:41 PM · Restricted Project, Restricted Project

Jun 2 2023

samitolvanen updated the summary of D148385: [RISCV] Implement KCFI operand bundle lowering.
Jun 2 2023, 1:08 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen committed rG2831a271c8be: [KCFI] Emit debugtrap to make indirect call checks recoverable (authored by samitolvanen).
[KCFI] Emit debugtrap to make indirect call checks recoverable
Jun 2 2023, 1:00 PM · Restricted Project, Restricted Project

May 16 2023

samitolvanen accepted D148785: -fsanitize=function: use type hashes instead of RTTI objects.

Looks good to me, but maybe worth waiting for someone more familiar with compiler-rt to take a look as well.

May 16 2023, 4:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 9 2023

samitolvanen added inline comments to D149915: [CodeGen][KCFI] Move cfi-type lowering to TargetLowering.
May 9 2023, 4:42 PM · Restricted Project, Restricted Project
samitolvanen committed rG9e869efc1b0a: [KCFI] Expand the KCFI term in comments (NFC) (authored by samitolvanen).
[KCFI] Expand the KCFI term in comments (NFC)
May 9 2023, 4:20 PM · Restricted Project, Restricted Project
samitolvanen added inline comments to D149915: [CodeGen][KCFI] Move cfi-type lowering to TargetLowering.
May 9 2023, 1:45 PM · Restricted Project, Restricted Project
samitolvanen updated the diff for D148385: [RISCV] Implement KCFI operand bundle lowering.

Dropped the arch-specific KCFI machine function pass.

May 9 2023, 12:51 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen committed rGe9569748def8: [CodeGen][KCFI] Move cfi-type lowering to TargetLowering (authored by samitolvanen).
[CodeGen][KCFI] Move cfi-type lowering to TargetLowering
May 9 2023, 11:43 AM · Restricted Project, Restricted Project
samitolvanen closed D149915: [CodeGen][KCFI] Move cfi-type lowering to TargetLowering.
May 9 2023, 11:43 AM · Restricted Project, Restricted Project

May 4 2023

samitolvanen planned changes to D148385: [RISCV] Implement KCFI operand bundle lowering.

Uploaded D149915 to remove the arch-specific KCFI passes. I'll update this patch once we clean that up.

May 4 2023, 3:51 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen requested review of D149915: [CodeGen][KCFI] Move cfi-type lowering to TargetLowering.
May 4 2023, 3:50 PM · Restricted Project, Restricted Project

Apr 18 2023

samitolvanen accepted D148671: [Driver] Make -fsanitize=kcfi,function incompatible.
Apr 18 2023, 4:05 PM · Restricted Project, Restricted Project
samitolvanen retitled D148385: [RISCV] Implement KCFI operand bundle lowering from [RISCV] Implement KCFI operand bundle lowering for RV64 to [RISCV] Implement KCFI operand bundle lowering.
Apr 18 2023, 11:45 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D148385: [RISCV] Implement KCFI operand bundle lowering.

Addressed most of the feedback.

Apr 18 2023, 11:45 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen planned changes to D148385: [RISCV] Implement KCFI operand bundle lowering.
Apr 18 2023, 11:30 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a comment to D148385: [RISCV] Implement KCFI operand bundle lowering.

I can't help but feel the core of this should be target-independent, with TLI or similar hooks to actually do the target-specific bits?

Apr 18 2023, 11:30 AM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2023

samitolvanen added reviewers for D148385: [RISCV] Implement KCFI operand bundle lowering: nickdesaulniers, MaskRay, pcc, joaomoreira, kees.
Apr 14 2023, 3:15 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen requested review of D148385: [RISCV] Implement KCFI operand bundle lowering.
Apr 14 2023, 3:14 PM · Restricted Project, Restricted Project, Restricted Project

Mar 13 2023

samitolvanen accepted D145999: [RISCV] Reserve X18 by default for Android.

LGTM. Folding D145979 into this one might also make sense.

Mar 13 2023, 4:49 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added inline comments to D145979: [RISC-V] Add test case for -fsanitize=shadow-call-stack.
Mar 13 2023, 4:48 PM · Restricted Project
samitolvanen added a comment to D145979: [RISC-V] Add test case for -fsanitize=shadow-call-stack.

Is this related to coverage? If not, should the test go to sanitizer-ld.c instead?

Mar 13 2023, 1:28 PM · Restricted Project

Feb 23 2023

samitolvanen planned changes to D142163: [LLD][ELF] Add --lto-export-symbol-list.
Feb 23 2023, 8:13 AM · Restricted Project, Restricted Project

Feb 21 2023

samitolvanen added a comment to D134831: [Clang][Sema] Add -Wcast-function-type-strict.

Is this intended to warn on code that casts a function taking a pointer to some non-void type to a function that takes a void*?

Feb 21 2023, 8:12 AM · Restricted Project, Restricted Project

Feb 15 2023

samitolvanen committed rGa851d46e07c1: [Clang][Driver] Fix integer normalization with KCFI (authored by samitolvanen).
[Clang][Driver] Fix integer normalization with KCFI
Feb 15 2023, 4:23 PM · Restricted Project, Restricted Project

Feb 8 2023

samitolvanen committed rG71c7313f42d2: Add CFI integer types normalization (authored by rcvalle).
Add CFI integer types normalization
Feb 8 2023, 2:25 PM · Restricted Project, Restricted Project
samitolvanen closed D139395: Add CFI integer types normalization.
Feb 8 2023, 2:25 PM · Restricted Project, Restricted Project
samitolvanen accepted D139395: Add CFI integer types normalization.

Thanks for fixing the MSan issue, Ramon. There's still a clang-format error that trips the Debian build above, but it's trivial so I can fix it when relanding the patch.

Feb 8 2023, 2:23 PM · Restricted Project, Restricted Project

Feb 3 2023

samitolvanen updated the summary of D138337: Add support for kcfi-seal optimization with LTO.
Feb 3 2023, 3:22 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D138337: Add support for kcfi-seal optimization with LTO.

Don't drop type hashes from VisibleToRegularObj symbols.

Feb 3 2023, 3:21 PM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2023

samitolvanen committed rGb1e9ab7438a0: Add CFI integer types normalization (authored by rcvalle).
Add CFI integer types normalization
Feb 1 2023, 9:48 AM · Restricted Project, Restricted Project
samitolvanen closed D139395: Add CFI integer types normalization.
Feb 1 2023, 9:48 AM · Restricted Project, Restricted Project

Jan 27 2023

samitolvanen added a comment to D142163: [LLD][ELF] Add --lto-export-symbol-list.

So, I looked into applying this to all object files with by adding similar code to Writer<ELFT>::finalizeSections(). This is not quite what we want in the kernel though. The primary goal is to better optimize bitcode during a relocatable link, and while we can conveniently generate a list of functions exported to kernel modules, we don't necessarily have a complete list of symbols (typically defined in stand-alone assembly) that are later needed in linker scripts or whose bindings objtool etc. assume to remain untouched, for example. In order to avoid additional hacks in the kernel, I would prefer to keep this flag specific to LTO. I do see the value in having a similar option for all object files, but perhaps that can be a separate option?

Jan 27 2023, 2:46 PM · Restricted Project, Restricted Project
samitolvanen updated the diff for D142163: [LLD][ELF] Add --lto-export-symbol-list.

Don't apply to isUsedInRegularObj symbols.

Jan 27 2023, 2:46 PM · Restricted Project, Restricted Project

Jan 25 2023

samitolvanen accepted D139395: Add CFI integer types normalization.

Thanks, LGTM. @pcc, does this version look fine to you?

Jan 25 2023, 1:29 PM · Restricted Project, Restricted Project
samitolvanen added a comment to D138337: Add support for kcfi-seal optimization with LTO.

If you're referring to ibt-seal, I assume a similar optimization could be added for BTI too.

Yes, please. Does it make sense to add to this patch, or a follow up on top?

Jan 25 2023, 10:42 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a comment to D138337: Add support for kcfi-seal optimization with LTO.

The test is for x86, does this also work for aarch64 with BTI?

Jan 25 2023, 10:36 AM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a comment to D138337: Add support for kcfi-seal optimization with LTO.

Is https://reviews.llvm.org/D142163 a blocker for this?

Jan 25 2023, 7:58 AM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2023

samitolvanen added a comment to D142163: [LLD][ELF] Add --lto-export-symbol-list.

What do you think about making this apply not only to LTO but to other -r links as well?

Jan 24 2023, 11:52 AM · Restricted Project, Restricted Project

Jan 20 2023

samitolvanen added a comment to D139395: Add CFI integer types normalization.

I discussed this out of band with Ramon and we agreed that the new option should be marked as experimental because the rustc implementation is not yet finalized. I think that the criteria for removing the experimental marking should be that there is a full implementation of integer normalization for Rust (or some other language) that has been tested against a large codebase that uses FFI.

Jan 20 2023, 4:37 PM · Restricted Project, Restricted Project

Jan 19 2023

samitolvanen added reviewers for D142163: [LLD][ELF] Add --lto-export-symbol-list: pcc, nickdesaulniers, joaomoreira, kees.

@pcc, @MaskRay, based on earlier discussions (e.g. https://github.com/ClangBuiltLinux/linux/issues/1737), does something like this look like a reasonable approach?

Jan 19 2023, 3:49 PM · Restricted Project, Restricted Project
samitolvanen requested review of D142163: [LLD][ELF] Add --lto-export-symbol-list.
Jan 19 2023, 3:48 PM · Restricted Project, Restricted Project
samitolvanen added a comment to D139395: Add CFI integer types normalization.

Thanks for the patch, Ramon. This looks like a reasonable approach to me, and just for reference, here appears to be the corresponding rustc change:

Jan 19 2023, 12:58 PM · Restricted Project, Restricted Project

Jan 11 2023

samitolvanen committed rGfd5e26270660: [ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions (authored by samitolvanen).
[ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions
Jan 11 2023, 4:01 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen closed D141172: [ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions.
Jan 11 2023, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen committed rGa78cfd590902: [GCOV] Set !kcfi_type metadata for indirectly called functions (authored by samitolvanen).
[GCOV] Set !kcfi_type metadata for indirectly called functions
Jan 11 2023, 3:05 PM · Restricted Project, Restricted Project
samitolvanen closed D141444: [GCOV] Set !kcfi_type metadata for indirectly called functions.
Jan 11 2023, 3:05 PM · Restricted Project, Restricted Project
samitolvanen added a comment to D141444: [GCOV] Set !kcfi_type metadata for indirectly called functions.

Ensuring that every instrumentation works with kcfi is a lot of work on the compiler side (think that another instrumentation technique comes up, we need to update O(n) existing instrumentation passes) and I don't quite agree that it's compiler's responsibility.
But if sanitizers and gcov are all, I think it's fine...

Jan 11 2023, 10:53 AM · Restricted Project, Restricted Project
samitolvanen updated the diff for D141444: [GCOV] Set !kcfi_type metadata for indirectly called functions.

Addressed comments.

Jan 11 2023, 10:53 AM · Restricted Project, Restricted Project

Jan 10 2023

samitolvanen added reviewers for D141444: [GCOV] Set !kcfi_type metadata for indirectly called functions: nickdesaulniers, MaskRay.
Jan 10 2023, 4:26 PM · Restricted Project, Restricted Project
samitolvanen requested review of D141444: [GCOV] Set !kcfi_type metadata for indirectly called functions.
Jan 10 2023, 4:26 PM · Restricted Project, Restricted Project

Jan 9 2023

samitolvanen added inline comments to D141172: [ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions.
Jan 9 2023, 12:56 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen updated the diff for D141172: [ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions.

Addressed feedback.

Jan 9 2023, 12:56 PM · Restricted Project, Restricted Project, Restricted Project

Jan 6 2023

samitolvanen added reviewers for D141172: [ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions: MaskRay, nickdesaulniers.
Jan 6 2023, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen requested review of D141172: [ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions.
Jan 6 2023, 4:45 PM · Restricted Project, Restricted Project, Restricted Project

Dec 22 2022

samitolvanen accepted D140363: Remove incorrectly implemented -mibt-seal.

I agree, it's probably best to temporarily revert this until Joao has time to address the issues you mentioned. The Linux kernel doesn't use -mibt-seal yet, so dropping the feature for now shouldn't be a problem.

Dec 22 2022, 10:44 AM · Restricted Project, Restricted Project, Restricted Project

Dec 15 2022

samitolvanen accepted D140035: [X86] Prevent -mibt-seal to work together with -flto=thin.

Regarding not being able to reproduce this in kernel -- never mind... I was misled by setup issues while running IBT kernels in QEMU. I managed to fix the setup and confirm that kernel won't boot.

Dec 15 2022, 11:48 AM · Restricted Project, Restricted Project, Restricted Project

Dec 14 2022

samitolvanen added a comment to D140035: [X86] Prevent -mibt-seal to work together with -flto=thin.

Regarding https://github.com/ClangBuiltLinux/linux/issues/1737:

Weirdly enough, I double-tested the behavior for -flto=thin + -mibt-seal; the kernel did boot fine on my setup, but when dumped/grep'ed for ENDBRs, it had ~500 less ENDBRs throughout the binary

Dec 14 2022, 10:49 AM · Restricted Project, Restricted Project, Restricted Project

Dec 8 2022

samitolvanen committed rG3b14862f0a96: [ModuleUtils][KCFI] Set !kcfi_type metadata for sanitizer constructors (authored by samitolvanen).
[ModuleUtils][KCFI] Set !kcfi_type metadata for sanitizer constructors
Dec 8 2022, 4:27 PM · Restricted Project, Restricted Project
samitolvanen closed D138945: [ModuleUtils][KCFI] Set !kcfi_type metadata for sanitizer constructors.
Dec 8 2022, 4:27 PM · Restricted Project, Restricted Project

Dec 6 2022

samitolvanen updated subscribers of D139395: Add CFI integer types normalization.
Dec 6 2022, 8:16 AM · Restricted Project, Restricted Project

Dec 5 2022

samitolvanen planned changes to D138337: Add support for kcfi-seal optimization with LTO.
Dec 5 2022, 3:48 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a comment to D138337: Add support for kcfi-seal optimization with LTO.

Isn't that just a bug in the optimization? It shouldn't be applying this to symbols where VisibleToRegularObj is set.

Dec 5 2022, 3:48 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen added a comment to D138337: Add support for kcfi-seal optimization with LTO.

Can't this be implicit if LTO is being used?

Dec 5 2022, 1:22 PM · Restricted Project, Restricted Project, Restricted Project

Dec 2 2022

samitolvanen updated the diff for D138945: [ModuleUtils][KCFI] Set !kcfi_type metadata for sanitizer constructors.

Really fix the indentation this time...

Dec 2 2022, 5:25 PM · Restricted Project, Restricted Project
samitolvanen updated the diff for D138945: [ModuleUtils][KCFI] Set !kcfi_type metadata for sanitizer constructors.

Addressed feedback.

Dec 2 2022, 4:33 PM · Restricted Project, Restricted Project
samitolvanen updated the diff for D138945: [ModuleUtils][KCFI] Set !kcfi_type metadata for sanitizer constructors.

Added a test.

Dec 2 2022, 12:34 PM · Restricted Project, Restricted Project

Nov 29 2022

samitolvanen added a reviewer for D138945: [ModuleUtils][KCFI] Set !kcfi_type metadata for sanitizer constructors: nathanchance.
Nov 29 2022, 1:09 PM · Restricted Project, Restricted Project
samitolvanen added reviewers for D138945: [ModuleUtils][KCFI] Set !kcfi_type metadata for sanitizer constructors: nickdesaulniers, joaomoreira, MaskRay, kees, pcc.
Nov 29 2022, 1:07 PM · Restricted Project, Restricted Project
samitolvanen requested review of D138945: [ModuleUtils][KCFI] Set !kcfi_type metadata for sanitizer constructors.
Nov 29 2022, 1:07 PM · Restricted Project, Restricted Project

Nov 22 2022

samitolvanen committed rGcacd3e73d7f8: Add generic KCFI operand bundle lowering (authored by samitolvanen).
Add generic KCFI operand bundle lowering
Nov 22 2022, 3:02 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen closed D135411: Add generic KCFI operand bundle lowering.
Nov 22 2022, 3:01 PM · Restricted Project, Restricted Project, Restricted Project
samitolvanen committed rG5a3d6ce956c4: [Clang][Driver] Add KCFI to SupportsCoverage (authored by samitolvanen).
[Clang][Driver] Add KCFI to SupportsCoverage
Nov 22 2022, 10:20 AM · Restricted Project, Restricted Project
samitolvanen closed D138458: [Clang][Driver] Add KCFI to SupportsCoverage.
Nov 22 2022, 10:20 AM · Restricted Project, Restricted Project
samitolvanen updated the diff for D138458: [Clang][Driver] Add KCFI to SupportsCoverage.

Switched to [[#]].

Nov 22 2022, 9:24 AM · Restricted Project, Restricted Project

Nov 21 2022

samitolvanen updated the summary of D138458: [Clang][Driver] Add KCFI to SupportsCoverage.
Nov 21 2022, 3:06 PM · Restricted Project, Restricted Project
samitolvanen added inline comments to D138458: [Clang][Driver] Add KCFI to SupportsCoverage.
Nov 21 2022, 3:05 PM · Restricted Project, Restricted Project
samitolvanen updated the diff for D138458: [Clang][Driver] Add KCFI to SupportsCoverage.

Addressed feedback.

Nov 21 2022, 3:05 PM · Restricted Project, Restricted Project
samitolvanen added reviewers for D138458: [Clang][Driver] Add KCFI to SupportsCoverage: nickdesaulniers, nathanchance, MaskRay.
Nov 21 2022, 1:30 PM · Restricted Project, Restricted Project
samitolvanen requested review of D138458: [Clang][Driver] Add KCFI to SupportsCoverage.
Nov 21 2022, 1:29 PM · Restricted Project, Restricted Project

Nov 18 2022

samitolvanen added reviewers for D138337: Add support for kcfi-seal optimization with LTO: nickdesaulniers, pcc, MaskRay, kees, joaomoreira.

ClangBuiltLinux issue: https://github.com/ClangBuiltLinux/linux/issues/1737

Nov 18 2022, 4:15 PM · Restricted Project, Restricted Project, Restricted Project