As we only care about fixing inline assembly references, mangled names are
not that important in the first place. This version skips any functions
that have unusual characters in their names that would otherwise require
quotes, which includes any functions with MSVC compatible name mangling.

Folded in D106392.

Nick suggested reverting until we figure out if this is the ideal fix here. I'll fold this to the original patch.

In D104058#2891551, @morehouse wrote:

This patch broke the sanitizer-windows bot: https://lab.llvm.org/buildbot/#/builders/127/builds/14257

Failed Tests (4):
  cfi-devirt-lld-thinlto-x86_64 :: anon-namespace.cpp
  cfi-devirt-lld-thinlto-x86_64 :: simple-pass.cpp
  cfi-standalone-lld-thinlto-x86_64 :: anon-namespace.cpp
  cfi-standalone-lld-thinlto-x86_64 :: simple-pass.cpp

Please revert or fix.

Added REQUIRES: x86-registered-target to tests.

The tests that now specify a target triple also need ; REQUIRES: x86-registered-target or they will obviously fail. I'll upload another revision.

In D104058#2883804, @nickdesaulniers wrote:

In D104058#2878083, @samitolvanen wrote:

In D104058#2877631, @nickdesaulniers wrote:

Change LGTM, but I don't understand why the following tests are modified:

• llvm/test/ThinLTO/X86/devirt2.ll

This is needed to fix two missing symbol resolution errors that are caused by the aliases we added.

I'm curious if this will lead to breakages with LTO in general? I suppose not, since it's llvm-lto2 that needs the explicit list of symbols that can be linked against.

In D104058#2877631, @nickdesaulniers wrote:

Change LGTM, but I don't understand why the following tests are modified:

• llvm/test/ThinLTO/X86/devirt2.ll

Moved the alias creation to module level inline assembly to avoid issues with LowerTypeTestsModule, based on pcc's suggestion.

Thanks for the revert, I'll take a look.

Fix a use-of-uninitialized-value error.

Moved the test to llvm/test/Transforms/ThinLTOBitcodeWriter.

Changed the message to refer to CallBase instead of CallInst.

Thanks, Nick. I don't have commit access, so would you mind committing the patch? I confirmed that check-all passes for me with the patch applied.

Thanks, Peter. I don't have commit access, so Nick, would you mind committing this for me? The Windows build failure looks unrelated.

In D103120#2791546, @nickdesaulniers wrote:

Is this related to b/158034873 or another reported bug?