This is an archive of the discontinued LLVM Phabricator instance.

Differential D145979

[RISC-V] Add test case for -fsanitize=shadow-call-stack
AbandonedPublic

Authored by hiraditya on Mar 13 2023, 12:34 PM.

Details

Reviewers
samitolvanen
vitalybuka
asb

Diff Detail

Event Timeline

hiraditya created this revision.Mar 13 2023, 12:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 12:34 PM
Herald added subscribers: VincentWu, vkmr, luismarques and 8 others. · View Herald Transcript
hiraditya requested review of this revision.Mar 13 2023, 12:34 PM
Herald added a subscriber: • pcwang-thead. · View Herald TranscriptMar 13 2023, 12:34 PM
hiraditya added a reviewer: asb.Mar 13 2023, 12:35 PM
samitolvanen added a comment.Mar 13 2023, 1:28 PM

Is this related to coverage? If not, should the test go to sanitizer-ld.c instead?

Harbormaster completed remote builds in B219141: Diff 504804.Mar 13 2023, 4:10 PM
hiraditya updated this revision to Diff 504881.Mar 13 2023, 4:13 PM

Moved the testcase as suggested by @samitolvanen

samitolvanen added inline comments.Mar 13 2023, 4:48 PM
clang/test/Driver/sanitizer-ld.c
746

-ffixed-x18 isn't needed after D145999. Can you drop the flag and land that patch first?

747

Perhaps CHECK-SHADOWCALLSTACK-ANDROID-RISCV64 to match the naming convention in the file?

748

Should we also check for -NOT: error: like the Fuchsia test below?

samitolvanen mentioned this in D145999: [RISCV] Reserve X18 by default for Android.Mar 13 2023, 4:49 PM
Harbormaster completed remote builds in B219200: Diff 504881.Mar 13 2023, 6:03 PM
hiraditya abandoned this revision.Mar 14 2023, 9:58 PM

I'll fold this to D145999.

Revision Contents

PathSize
clang/
test/
Driver/
4 lines

Diff 504881

clang/test/Driver/sanitizer-ld.c

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
// RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-ELF-RISCV32 %s // RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-ELF-RISCV32 %s
// CHECK-SHADOWCALLSTACK-ELF-RISCV32: '-fsanitize=shadow-call-stack' only allowed with '-ffixed-x18' // CHECK-SHADOWCALLSTACK-ELF-RISCV32: '-fsanitize=shadow-call-stack' only allowed with '-ffixed-x18'
// RUN: %clang -fsanitize=shadow-call-stack -### %s 2>&1 \ // RUN: %clang -fsanitize=shadow-call-stack -### %s 2>&1 \
// RUN: --target=riscv64-unknown-linux -fuse-ld=ld \ // RUN: --target=riscv64-unknown-linux -fuse-ld=ld \
// RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-RISCV64 %s // RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-RISCV64 %s
// CHECK-SHADOWCALLSTACK-LINUX-RISCV64: '-fsanitize=shadow-call-stack' only allowed with '-ffixed-x18' // CHECK-SHADOWCALLSTACK-LINUX-RISCV64: '-fsanitize=shadow-call-stack' only allowed with '-ffixed-x18'
// RUN: %clang -target riscv64-linux-android -fsanitize=shadow-call-stack -ffixed-x18 %s -### 2>&1 \
samitolvanenUnsubmitted
Not Done
ReplyInline Actions

-ffixed-x18 isn't needed after D145999. Can you drop the flag and land that patch first?

samitolvanen: `-ffixed-x18` isn't needed after D145999. Can you drop the flag and land that patch first?
// RUN: | FileCheck %s --check-prefix=CHECK-RV64-SHADOWCALLSTACK
samitolvanenUnsubmitted
Not Done
ReplyInline Actions

Perhaps CHECK-SHADOWCALLSTACK-ANDROID-RISCV64 to match the naming convention in the file?

samitolvanen: Perhaps `CHECK-SHADOWCALLSTACK-ANDROID-RISCV64` to match the naming convention in the file?
// CHECK-RV64-SHADOWCALLSTACK: "-target-feature" "+reserve-x18"
samitolvanenUnsubmitted
Not Done
ReplyInline Actions

Should we also check for -NOT: error: like the Fuchsia test below?

samitolvanen: Should we also check for `-NOT: error:` like the Fuchsia test below?
// RUN: %clang -fsanitize=shadow-call-stack -### %s 2>&1 \ // RUN: %clang -fsanitize=shadow-call-stack -### %s 2>&1 \
// RUN: --target=riscv64-unknown-fuchsia -fuse-ld=ld \ // RUN: --target=riscv64-unknown-fuchsia -fuse-ld=ld \
// RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-FUCHSIA-RISCV64 %s // RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-FUCHSIA-RISCV64 %s
// CHECK-SHADOWCALLSTACK-FUCHSIA-RISCV64-NOT: error: // CHECK-SHADOWCALLSTACK-FUCHSIA-RISCV64-NOT: error:
// RUN: %clang -fsanitize=shadow-call-stack -### %s 2>&1 \ // RUN: %clang -fsanitize=shadow-call-stack -### %s 2>&1 \
// RUN: --target=aarch64-unknown-linux -fuse-ld=ld -ffixed-x18 \ // RUN: --target=aarch64-unknown-linux -fuse-ld=ld -ffixed-x18 \
// RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-AARCH64-X18 %s // RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-AARCH64-X18 %s
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines