Page MenuHomePhabricator
Differential D145958

[clang-tidy] Fix minor bug in bugprone-too-small-loop-variable
ClosedPublic
Actions

Authored by PiotrZSL on Mon, Mar 13, 10:07 AM.

Details

Reviewers
njames93
aaron.ballman
carlosgalvezp
LegalizeAdulthood
Commits
rG113f0190dd38: [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable
Summary

Correct issue when incorrectly matched bitfield loop
variable would still be considered valid and equal to
base type, because check didnt compare size of bitfield.

Fixes issue introduced in: D142587

Diff Detail

Event Timeline

PiotrZSL created this revision.Mon, Mar 13, 10:07 AM
Herald added a reviewer: njames93. · View Herald TranscriptMon, Mar 13, 10:07 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: carlosgalvezp, xazax.hun. · View Herald Transcript
PiotrZSL requested review of this revision.Mon, Mar 13, 10:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Mar 13, 10:07 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Eugene.Zelenko added reviewers: aaron.ballman, carlosgalvezp.Mon, Mar 13, 11:02 AM
Harbormaster completed remote builds in B219091: Diff 504730.Mon, Mar 13, 1:18 PM
uabelho added a subscriber: uabelho.Tue, Mar 14, 12:31 AM
Henric added a subscriber: Henric.Tue, Mar 14, 1:18 AM
PiotrZSL added a reviewer: LegalizeAdulthood.Tue, Mar 14, 12:35 PM
carlosgalvezp accepted this revision.Sat, Mar 18, 3:10 AM
This revision is now accepted and ready to land.Sat, Mar 18, 3:10 AM
Closed by commit rG113f0190dd38: [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable (authored by PiotrZSL). · Explain WhySat, Mar 18, 4:28 AM
This revision was automatically updated to reflect the committed changes.
PiotrZSL added a commit: rG113f0190dd38: [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable.

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clang-tidy/
bugprone/
17 lines
test/
clang-tidy/
checkers/
bugprone/
17 lines

Diff 506285

View Options

clang-tools-extra/clang-tidy/bugprone/TooSmallLoopVariableCheck.cpp

Loading...
View Options

clang-tools-extra/test/clang-tidy/checkers/bugprone/too-small-loop-variable.cpp

Loading...