This is an archive of the discontinued LLVM Phabricator instance.

[flang] Add missing dependencies for flang/lib/Optimizer/Dialect
ClosedPublic

Authored by PeteSteinfeld on Mar 10 2023, 1:11 PM.

Details

Summary

Patch D145640 wasn't building for me because .cpp files in
flang/lib/Optimizer/Dialect depend on the files generated in
.../build/include/llfm/IR. But the .cpp file compilations were being
done before the needed include files were generated.

This patch fixes that by adding dependencies on "intrinsics_gen" to the
CMake files in two directories.

Diff Detail

Event Timeline

PeteSteinfeld created this revision.Mar 10 2023, 1:11 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 10 2023, 1:11 PM
PeteSteinfeld requested review of this revision.Mar 10 2023, 1:11 PM

What is intrinsics_gen?

What is intrinsics_gen?

I don't really know, other than it's the thing that builds the files in .../build/include/llvm/IR.

What is intrinsics_gen?

I don't really know, other than it's the thing that builds the files in .../build/include/llvm/IR.

That's the directory that contains the files that were missing when the .cpp compilations were failing.

sscalpone accepted this revision.Mar 10 2023, 1:27 PM
This revision is now accepted and ready to land.Mar 10 2023, 1:27 PM
PeteSteinfeld accepted this revision.Mar 10 2023, 1:40 PM

All builds and tests correctly and looks good.

This revision was landed with ongoing or failed builds.Mar 10 2023, 1:43 PM
This revision was automatically updated to reflect the committed changes.