This is an archive of the discontinued LLVM Phabricator instance.

llvm-exegesis: Only run X86 tests on X86 hosts
ClosedPublic

Authored by tstellar on Mar 9 2023, 9:11 PM.

Details

Summary

These tests were failing on SystemZ host, I don't think JIT'ing X86
modules on SystemZ is supported.

The tests were initiallay enabled on all arches by
7a76140220bd2c4730a2c39b6fd645402040f011.

Diff Detail

Event Timeline

tstellar created this revision.Mar 9 2023, 9:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 9:11 PM
tstellar requested review of this revision.Mar 9 2023, 9:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 9:11 PM
tstellar updated this revision to Diff 504029.Mar 9 2023, 10:33 PM

Fix PowerPC tests too.

courbet accepted this revision.Mar 10 2023, 1:24 AM

I don't think JIT'ing X86 modules on SystemZ is supported.

This is weird, right ? the JITing code should be purely target agnostic. Do you have a link to a failing test so I can have a look ?

In the meantime I'm fine submitting this, the main use case is to JIT and run on the same architecture.

This revision is now accepted and ready to land.Mar 10 2023, 1:24 AM

From what I can tell the problem is not the JIT'd code, but registering the EHFrames. Maybe the endian differences make libgcc not able to read the EHFrames since they are generated for x86. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108994#c14

gchatelet accepted this revision.Mar 10 2023, 4:11 AM
gchatelet added a subscriber: gchatelet.

Thx for the heads up / fix @tstellar !