This patch now enables full build.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libc/config/linux/app.h | ||
---|---|---|
40 ↗ | (On Diff #503412) | Do we need this change for full build? |
libc/include/llvm-libc-types/fenv_t.h | ||
---|---|---|
29 | I think the __riscv check should be above this |
libc/config/linux/app.h | ||
---|---|---|
40 ↗ | (On Diff #503412) | I'll double-check |
Comment Actions
- Removed unnecessary define from app.h (for full build)
- Fix riscv define in the wrong place in fenv_t.h
libc/include/llvm-libc-types/fenv_t.h | ||
---|---|---|
27 | I would *highly* recommend never using a typedef to a base type (or other existing type) like this. It's much better to define a struct with a single member, as you can see done for the ARM case above. This ensures that the API contract enforces that fenv_t and fenv_t* values are passed, rather than unsigned int or unsigned int*. On x86-64, ARM, and RISC-V, the calling convention for a struct like this is the same as for the bare integer type. |
I would *highly* recommend never using a typedef to a base type (or other existing type) like this. It's much better to define a struct with a single member, as you can see done for the ARM case above. This ensures that the API contract enforces that fenv_t and fenv_t* values are passed, rather than unsigned int or unsigned int*. On x86-64, ARM, and RISC-V, the calling convention for a struct like this is the same as for the bare integer type.