[libc] Support more functions in riscv

[mikhail.ramalho]

Out of more than 1600 tests (that run in my x86_64 machine), this patch enables 1057 of them.

[mikhail.ramalho]

Also, sorry for the big patch, the next ones shall be smaller/more directed to individual lib support.

[mikhail.ramalho]

Fixed copy & paste error in FMA.h:

LLVM_LIBC_SRC_SUPPORT_FPUTIL_AARCH64_FMA_H should've been LLVM_LIBC_SRC_SUPPORT_FPUTIL_RISCV64_FMA_H.

[sivachandra]

Hi, thanks for the patch. You have included thread functions but do they build and pass? Their linux implementation is very closely tied to the startup implementation which you have not included in this patch.

[sivachandra]

Also, can you split this up so that it is easy for me to test? Likewise, send the changes doing cleanups separately.

[mikhail.ramalho]

In D145444#4173462, @sivachandra wrote:

Also, can you split this up so that it is easy for me to test? Likewise, send the changes doing cleanups separately.

Sure, I'll split it and send the smaller ones tomorrow!

[sivachandra]

Two keep it easy to test and rollout, lets also first only add non-fullbuild functions. I have patches ready for this but since you have sent it before me, I will wait for you to send them out. For the syscall implementation in riscv64/syscall.h, lets follow the aarch64/syscall.h pattern.

[mikhail.ramalho]

Removed code implemented by D145452 and D145496

[mikhail.ramalho]

Enable math libs now that we have a working fenv

[sivachandra]

Hi,

Can you separate this out into following patches:

1. Just simple expansion of entrypoints.txt with functions that can now be included without any other changes. Do not include any commented out functions.
2. FMA patch.
3. sqrt patch.
4. Adding riscv fenv_t and singal.h macros. Enable full build also with this patch.

Thanks,
Siva Chandra

[mikhail.ramalho]

split the patch: this only adds the new supported functions now

[mikhail.ramalho]

In D145444#4178400, @sivachandra wrote:

Hi,

Can you separate this out into following patches:

1. Just simple expansion of entrypoints.txt with functions that can now be included without any other changes. Do not include any commented out functions.
2. FMA patch.
3. sqrt patch.
4. Adding riscv fenv_t and singal.h macros. Enable full build also with this patch.

Thanks,
Siva Chandra

No problem!

I only left the commented sin, cos and tan, if that's alright.

[mikhail.ramalho]

Added sched include

[sivachandra]

In D145444#4178442, @mikhail.ramalho wrote:

In D145444#4178400, @sivachandra wrote:

Hi,

Can you separate this out into following patches:

1. Just simple expansion of entrypoints.txt with functions that can now be included without any other changes. Do not include any commented out functions.
2. FMA patch.
3. sqrt patch.
4. Adding riscv fenv_t and singal.h macros. Enable full build also with this patch.

Thanks,
Siva Chandra

No problem!

I only left the commented sin, cos and tan, if that's alright.

I see more functions commented out. Commenting out is fine as long as we include a good reason why it has been commented out.

[mikhail.ramalho]

Enable snprintf

[sivachandra]

Feel free to land with the simpler description I have edited to.

libc/config/linux/riscv64/entrypoints.txt

set(TARGET_LIBC_ENTRYPOINTS
     libc.src.string.memset
     libc.src.string.stpcpy
     libc.src.string.stpncpy
     libc.src.string.strcasecmp
     libc.src.string.strcasestr
     libc.src.string.strcat
     libc.src.string.strchr
     libc.src.string.strcmp
+    libc.src.string.strcoll
     libc.src.string.strcpy
     libc.src.string.strcspn
     libc.src.string.strdup
     libc.src.string.strerror
     libc.src.string.strerror_r
+    libc.src.string.strdup
+    libc.src.string.strerror
+    libc.src.string.strerror_r
     libc.src.string.strlcat
     libc.src.string.strlcpy
     libc.src.string.strlen
     libc.src.string.strncasecmp
     libc.src.string.strncat
     libc.src.string.strncmp
     libc.src.string.strncpy
     libc.src.string.strndup
+    libc.src.string.strndup
     libc.src.string.strnlen
     libc.src.string.strpbrk
     libc.src.string.strrchr
     libc.src.string.strsignal
+    libc.src.string.strsignal
     libc.src.string.strspn
     libc.src.string.strstr
     libc.src.string.strtok
     libc.src.string.strtok_r
 
     # inttypes.h entrypoints
     libc.src.inttypes.imaxabs
     libc.src.inttypes.imaxdiv
     libc.src.inttypes.strtoimax
     libc.src.inttypes.strtoumax
- 
     # stdlib.h entrypoints
     libc.src.stdlib.abs
     libc.src.stdlib.atoi
     libc.src.stdlib.atof
     libc.src.stdlib.atol
     libc.src.stdlib.atoll
     libc.src.stdlib.bsearch
     libc.src.stdlib.div
     libc.src.stdlib.labs
     libc.src.stdlib.ldiv
     libc.src.stdlib.llabs
     libc.src.stdlib.lldiv
     libc.src.stdlib.qsort
+    libc.src.stdlib.rand
+    libc.src.stdlib.srand
     libc.src.stdlib.strtod
     libc.src.stdlib.strtof
     libc.src.stdlib.strtol
     libc.src.stdlib.strtold
     libc.src.stdlib.strtoll
     libc.src.stdlib.strtoul
     libc.src.stdlib.strtoull
 
     # stdlib.h external entrypoints
     libc.src.stdlib.malloc
     libc.src.stdlib.calloc
     libc.src.stdlib.realloc
     libc.src.stdlib.aligned_alloc
     libc.src.stdlib.free
 
     # stdio.h entrypoints
     libc.src.stdio.remove
+    libc.src.stdio.sprintf
+    libc.src.stdio.snprintf
 
     # sys/mman.h entrypoints
     libc.src.sys.mman.madvise
     libc.src.sys.mman.mmap
     libc.src.sys.mman.mprotect
     libc.src.sys.mman.munmap
     libc.src.sys.mman.posix_madvise
 
set(TARGET_LIBC_ENTRYPOINTS
 
     # unistd.h entrypoints
     libc.src.unistd.access
     libc.src.unistd.chdir
     libc.src.unistd.close
     libc.src.unistd.dup
     libc.src.unistd.dup2
     libc.src.unistd.dup3
+    libc.src.unistd.execve
     libc.src.unistd.fchdir
     libc.src.unistd.fsync
     libc.src.unistd.ftruncate
     libc.src.unistd.getcwd
     libc.src.unistd.geteuid
     libc.src.unistd.getpid
     libc.src.unistd.getppid
     libc.src.unistd.getuid
+    libc.src.unistd.isatty
     libc.src.unistd.link
     libc.src.unistd.linkat
     libc.src.unistd.lseek
     libc.src.unistd.pread
     libc.src.unistd.pwrite
     libc.src.unistd.read
     libc.src.unistd.readlink
     libc.src.unistd.readlinkat
set(TARGET_LIBM_ENTRYPOINTS
     libc.src.fenv.fesetenv
     libc.src.fenv.fesetexceptflag
     libc.src.fenv.fesetround
     libc.src.fenv.feraiseexcept
     libc.src.fenv.fetestexcept
     libc.src.fenv.feupdateenv
 
     # math.h entrypoints
+    libc.src.math.acosf
+    libc.src.math.acoshf
+    libc.src.math.asin
+    libc.src.math.asinf
+    libc.src.math.asinhf
+    libc.src.math.atanf
+    libc.src.math.atanhf
+    libc.src.math.copysign
+    libc.src.math.copysignf
+    libc.src.math.copysignl
+    libc.src.math.ceil
+    libc.src.math.ceilf
+    libc.src.math.ceill
+    # libc.src.math.cos
+    libc.src.math.coshf
+    libc.src.math.cosf
+    libc.src.math.expf
+    libc.src.math.exp10f
+    libc.src.math.exp2f
+    libc.src.math.expm1f
     libc.src.math.fabs
     libc.src.math.fabsf
     libc.src.math.fabsl
     libc.src.math.fdim
     libc.src.math.fdimf
     libc.src.math.fdiml
-    libc.src.math.fmax
-    libc.src.math.fmaxf
-    libc.src.math.fmaxl
+    libc.src.math.floor
+    libc.src.math.floorf
+    libc.src.math.floorl
+    libc.src.math.fma
+    libc.src.math.fmaf
     libc.src.math.fmin
     libc.src.math.fminf
     libc.src.math.fminl
+    libc.src.math.fmax
+    libc.src.math.fmaxf
+    libc.src.math.fmaxl
+    libc.src.math.fmod
+    libc.src.math.fmodf
+    libc.src.math.frexp
+    libc.src.math.frexpf
+    libc.src.math.frexpl
+    libc.src.math.hypot
+    libc.src.math.hypotf
+    libc.src.math.ilogb
+    libc.src.math.ilogbf
+    libc.src.math.ilogbl
+    libc.src.math.ldexp
+    libc.src.math.ldexpf
+    libc.src.math.ldexpl
+    libc.src.math.llrint
+    libc.src.math.llrintf
+    libc.src.math.llrintl
+    libc.src.math.llround
+    libc.src.math.llroundf
+    libc.src.math.llroundl
+    libc.src.math.log10
+    libc.src.math.log10f
+    libc.src.math.log1pf
+    libc.src.math.log2f
+    libc.src.math.logf
+    libc.src.math.logb
+    libc.src.math.logbf
+    libc.src.math.logbl
+    libc.src.math.lrint
+    libc.src.math.lrintf
+    libc.src.math.lrintl
+    libc.src.math.lround
+    libc.src.math.lroundf
+    libc.src.math.lroundl
+    libc.src.math.modf
+    libc.src.math.modff
+    libc.src.math.modfl
+    libc.src.math.nearbyint
+    libc.src.math.nearbyintf
+    libc.src.math.nearbyintl
+    libc.src.math.nextafter
+    libc.src.math.nextafterf
+    libc.src.math.nextafterl
+    libc.src.math.pow
+    libc.src.math.remainderf
+    libc.src.math.remainder
+    libc.src.math.remainderl
+    libc.src.math.remquof
+    libc.src.math.remquo
+    libc.src.math.remquol
+    libc.src.math.rint
+    libc.src.math.rintf
+    libc.src.math.rintl
+    libc.src.math.round
+    libc.src.math.roundf
+    libc.src.math.roundl
+    libc.src.math.scalbn
+    libc.src.math.scalbnf
+    libc.src.math.scalbnl
+    # libc.src.math.sin
+    libc.src.math.sincosf
+    libc.src.math.sinhf
+    libc.src.math.sinf
+    libc.src.math.sqrt
+    libc.src.math.sqrtf
+    libc.src.math.sqrtl
+    # libc.src.math.tan
+    libc.src.math.tanf
+    libc.src.math.tanhf
+    libc.src.math.trunc
+    libc.src.math.truncf
+    libc.src.math.truncl
 )
 
 set(TARGET_LLVMLIBC_ENTRYPOINTS
   ${TARGET_LIBC_ENTRYPOINTS}
   ${TARGET_LIBM_ENTRYPOINTS}
 )

libc/config/linux/riscv64/headers.txt

 set(TARGET_PUBLIC_HEADERS
     libc.include.ctype
     libc.include.errno
     libc.include.inttypes
     libc.include.math
+    libc.include.sched
     libc.include.stdlib
     libc.include.string
 )