This is an archive of the discontinued LLVM Phabricator instance.

[OPENMP]Fix PR59947: "Partially-triangular" loop collapse crashes.
ClosedPublic

Authored by ABataev on Mar 7 2023, 8:45 AM.

Details

Summary

The indeces of the dependent loops are properly ordered, just start from
1, so need just subtract 1 to get correct loop index.

Diff Detail

Event Timeline

ABataev created this revision.Mar 7 2023, 8:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2023, 8:45 AM
ABataev requested review of this revision.Mar 7 2023, 8:45 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 7 2023, 8:45 AM
jdoerfert added inline comments.Mar 7 2023, 10:28 AM
openmp/runtime/test/worksharing/for/omp_for_non_rectangular.c
33

should we test the count?

ABataev updated this revision to Diff 503114.Mar 7 2023, 11:38 AM

Address comment

jdoerfert accepted this revision.Mar 7 2023, 4:50 PM

This seems to pass our other tests, LG.

This revision is now accepted and ready to land.Mar 7 2023, 4:50 PM
This revision was landed with ongoing or failed builds.Mar 8 2023, 1:08 PM
This revision was automatically updated to reflect the committed changes.