This is an archive of the discontinued LLVM Phabricator instance.

Differential D145352

[flang][OpenMP] Verify support for private/firstprivate on unstructured sections
ClosedPublic

Authored by NimishMishra on Mar 5 2023, 10:21 PM.

Details

Reviewers
jdoerfert
kiranchandramohan
kiranktp
peixin
domada
TIFitis
Commits
rGe5aa6eeb4c47: [flang][OpenMP] Verify support for private/firstprivate on unstructured sections
Summary

Verification of support for lowering private/firstprivate clauses on unstructured sections

Depends on D143077

Diff Detail

Event Timeline

NimishMishra created this revision.Mar 5 2023, 10:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 10:21 PM
Herald added subscribers: sunshaoce, jdoerfert, guansong, yaxunl. · View Herald Transcript
NimishMishra requested review of this revision.Mar 5 2023, 10:21 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptMar 5 2023, 10:21 PM
Herald added a subscriber: sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B217494: Diff 502519.Mar 5 2023, 10:46 PM
NimishMishra added reviewers: kiranchandramohan, kiranktp, peixin.Mar 6 2023, 5:45 AM
NimishMishra added a reviewer: domada.
TIFitis accepted this revision.May 25 2023, 6:18 AM
TIFitis added a subscriber: TIFitis.

LGTM

This revision is now accepted and ready to land.May 25 2023, 6:18 AM
Herald added a subscriber: jplehr. · View Herald TranscriptMay 25 2023, 6:18 AM
Closed by commit rGe5aa6eeb4c47: [flang][OpenMP] Verify support for private/firstprivate on unstructured sections (authored by NimishMishra). · Explain WhyJun 1 2023, 3:36 AM
This revision was automatically updated to reflect the committed changes.
NimishMishra added a commit: rGe5aa6eeb4c47: [flang][OpenMP] Verify support for private/firstprivate on unstructured sections.

Revision Contents

PathSize
flang/
test/
Lower/
OpenMP/
43 lines

Diff 502519

flang/test/Lower/OpenMP/sections.f90

Show First 20 Lines • Show All 225 Lines • ▼ Show 20 Lines
!CHECK: %[[INNER_PRIVATE_X:.*]] = fir.load %[[PRIVATE_X]] : !fir.ref<i32> !CHECK: %[[INNER_PRIVATE_X:.*]] = fir.load %[[PRIVATE_X]] : !fir.ref<i32>
!CHECK: %[[const:.*]] = arith.constant 1 : i32 !CHECK: %[[const:.*]] = arith.constant 1 : i32
!CHECK: %[[result:.*]] = arith.addi %[[INNER_PRIVATE_X]], %[[const]] : i32 !CHECK: %[[result:.*]] = arith.addi %[[INNER_PRIVATE_X]], %[[const]] : i32
!CHECK: fir.store %[[result]] to %[[PRIVATE_X]] : !fir.ref<i32> !CHECK: fir.store %[[result]] to %[[PRIVATE_X]] : !fir.ref<i32>
!CHECK: %[[loaded_value:.*]] = fir.load %[[PRIVATE_X]] : !fir.ref<i32> !CHECK: %[[loaded_value:.*]] = fir.load %[[PRIVATE_X]] : !fir.ref<i32>
!CHECK: fir.store %[[loaded_value]] to %[[X]] : !fir.ref<i32> !CHECK: fir.store %[[loaded_value]] to %[[X]] : !fir.ref<i32>
!CHECK: omp.terminator !CHECK: omp.terminator
!CHECK: } !CHECK: }
!CHECK: return
!CHECK: } !CHECK: }
!$omp sections lastprivate(x) !$omp sections lastprivate(x)
!$omp section !$omp section
goto 30 goto 30
30 x = x + 1 30 x = x + 1
!$omp end sections !$omp end sections
end subroutine end subroutine
subroutine unstructured_sections_privatization()
!CHECK: %[[X:.*]] = fir.alloca f32 {bindc_name = "x", uniq_name = "_QFunstructured_sections_privatizationEx"}
!CHECK: omp.sections {
!CHECK: omp.section {
!CHECK: %[[PRIVATE_X:.*]] = fir.alloca f32 {bindc_name = "x", pinned, uniq_name = "_QFunstructured_sections_privatizationEx"}
!CHECK: cf.br ^bb1
!CHECK: ^bb1: // pred: ^bb0
!CHECK: %[[INNER_PRIVATE_X:.*]] = fir.load %[[PRIVATE_X]] : !fir.ref<f32>
!CHECK: %[[constant:.*]] = arith.constant 1.000000e+00 : f32
!CHECK: %[[result:.*]] = arith.addf %[[INNER_PRIVATE_X]], %[[constant]] fastmath<contract> : f32
!CHECK: fir.store %[[result]] to %[[PRIVATE_X]] : !fir.ref<f32>
!CHECK: omp.terminator
!CHECK: }
!CHECK: omp.terminator
!CHECK: }
!$omp sections private(x)
!$omp section
goto 40
40 x = x + 1
!$omp end sections
!CHECK: omp.sections {
!CHECK: omp.section {
!CHECK: %[[PRIVATE_X:.*]] = fir.alloca f32 {bindc_name = "x", pinned, uniq_name = "_QFunstructured_sections_privatizationEx"}
!CHECK: %[[temp:.*]] = fir.load %[[X]] : !fir.ref<f32>
!CHECK: fir.store %[[temp]] to %[[PRIVATE_X]] : !fir.ref<f32>
!CHECK: cf.br ^bb1
!CHECK: ^bb1: // pred: ^bb0
!CHECK: %[[INNER_PRIVATE_X:.*]] = fir.load %[[PRIVATE_X]] : !fir.ref<f32>
!CHECK: %[[constant:.*]] = arith.constant 1.000000e+00 : f32
!CHECK: %[[result:.*]] = arith.addf %[[INNER_PRIVATE_X]], %[[constant]] fastmath<contract> : f32
!CHECK: fir.store %[[result]] to %[[PRIVATE_X]] : !fir.ref<f32>
!CHECK: omp.terminator
!CHECK: }
!CHECK: omp.terminator
!CHECK: }
!$omp sections firstprivate(x)
!$omp section
goto 50
50 x = x + 1
!$omp end sections
end subroutine